From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/tee: refactor option processing
Date: Mon, 7 Jul 2025 18:00:12 +0200
Message-ID: <aGvvDJWWL2ZBpWKj@phare.normalesup.org> (raw)
In-Reply-To: <5B62BCC7-41CB-4BF6-89E6-D8B6EE89A421@gmail.com>
Marvin Scholz (HE12025-07-07):
> I never said not to check for it…
You gave that argument in reply to the code becoming more verbose.
> How is making an APIs return value adhere to its documentation
> "hypothetical reasons"?
It works.
> It clearly states "The returned entry key
> or value must not be changed, or it will cause undefined behavior."
> so it would be quite logical to make its return const to make it
> harder for someone to shoot themselves in the foot using the API.
Do you really have nothing better to do than argue with something that
works and that will not be changed in the foreseeable future?
--
Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-07-07 16:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 22:08 Marvin Scholz
2025-06-24 22:08 ` [FFmpeg-devel] [PATCH 2/2] avformat/tee: fix multiple bsfs in tee Marvin Scholz
2025-06-25 9:56 ` Nicolas George
2025-06-26 15:42 ` Marvin Scholz
2025-06-25 11:23 ` [FFmpeg-devel] [PATCH 1/2] avformat/tee: refactor option processing Nicolas George
2025-06-25 12:04 ` Marvin Scholz
2025-07-03 9:08 ` Nicolas George
2025-07-04 14:52 ` Marvin Scholz
2025-07-07 15:32 ` Nicolas George
2025-07-07 15:52 ` Marvin Scholz
2025-07-07 16:00 ` Nicolas George [this message]
2025-07-07 16:13 ` Marvin Scholz
2025-07-07 16:55 ` Nicolas George
2025-07-07 16:04 ` Vittorio Giovara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGvvDJWWL2ZBpWKj@phare.normalesup.org \
--to=george@nsup.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git