Re: [FFmpeg-devel] [PATCH 1/2] avformat/tee: refactor option processing

[Nicolas George <george@nsup.org>]

Marvin Scholz (HE12025-07-04):
> If copying two strings fails here, it is highly unlikely any of the following
> code, needing much more memory, would have any chance of succeeding.

> Yes it introducers two copies which could fail but the chance for that happening
> is so small that I dont think it justifies using hacks like this, which also introduce
> risk of turning into more serious issues when the AVDictionary code is changed and someone
> is unaware of this hack here.

Please tell us: How unlikely do you think it needs to be for us to
dispense with the checks? 1/1000? 1/1E6?

(Hint: the answer is 0.)

> We are talking about copying two option strings here, during setup,
> not per frame, not every few seconds.

You already gave that argument, and I already explained to you that
efficiency was the tiniest of my arguments. But it is still an argument.

> I disagree making this hack official.

Well, I disagree making the current code more verbose for hypothetical
reasons.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".