From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 6DDCF4FE3C for ; Thu, 3 Jul 2025 09:08:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8028268E892; Thu, 3 Jul 2025 12:08:07 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 510E968E82E for ; Thu, 3 Jul 2025 12:08:01 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 563980ib029099 for ; Thu, 3 Jul 2025 11:08:00 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id 98AA72EFE3; Thu, 3 Jul 2025 11:08:00 +0200 (CEST) Date: Thu, 3 Jul 2025 11:08:00 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20250624220805.50371-1-epirat07@gmail.com> <1B2B29DA-C587-4A6B-BCAB-DAFDA9DD6230@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1B2B29DA-C587-4A6B-BCAB-DAFDA9DD6230@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Thu, 03 Jul 2025 11:08:00 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/tee: refactor option processing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Marvin Scholz (HE12025-06-25): > Would you be fine with just the removal of the messing with > the AVDictionary entries then, leaving the macros in place, > essentially removing STEAL_OPTION and doing a copy in CONSUME_OPTION? > > IMHO saving two copies of a string does not justify abusing the > AVDictionary API in such a way. This isnt a hot code path either > where this would make sense... It is not just a matter of saving a few cycles. What you propose requires writing more code, including error checks and an occasion for failure. If it was new code, I would consider it, but changing existing code that has been working for years to make it more verbose, more failure prone and less efficient, no, thanks. Let us just document that it is a valid use. Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".