From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5070F501F5 for ; Wed, 9 Jul 2025 12:04:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 34A8268E107; Wed, 9 Jul 2025 15:04:12 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 2D36968DF0C for ; Wed, 9 Jul 2025 15:04:05 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 569C44WZ025289 for ; Wed, 9 Jul 2025 14:04:04 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id 0D02F2EFDF; Wed, 9 Jul 2025 14:04:04 +0200 (CEST) Date: Wed, 9 Jul 2025 14:04:03 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20250707103102.3477457-1-michael@niedermayer.cc> <20250707103102.3477457-2-michael@niedermayer.cc> <20250707145833.GG29660@pb2> <20250707200731.GH29660@pb2> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250707200731.GH29660@pb2> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Wed, 09 Jul 2025 14:04:04 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer (HE12025-07-07): > a file called self_ref.ffconcat, containing: > > ffconcat version 1.0 > file self_ref.ffconcat Oh, that. Thanks for explaining. I am not sure it is our responsibility to protect from this, there are many instance of similar pitfalls, for example a shell wrapper for a command with the same name that neglects to not call itself. But if it takes very little code like that, why not... OTOH, three problem I have with the code: ELOOP is not portable, and the message does not match the issue. It is better to have an error message that says nothing ("invalid value") than an error message that says something wrong ("symbolic links"? what symbolic links?). Why do you have to implement it in concat? AFAICS, the call to ff_copy_whiteblacklists() should be enough to trigger the protection you added in patch 1/2. You are abusing the ff_copy_whiteblacklists() function. Since it is private, it can be renamed. ff_prepare_nested_muxer()? Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".