From: Peter Ross <pross@xvid.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/g728dec: Remove AVCodec.sample_fmts
Date: Tue, 24 Jun 2025 02:40:28 +1000
Message-ID: <aFmDfJFNxMbH6oR5@97128e981a0fdc76c1c3e90f890ef837> (raw)
In-Reply-To: <GV1P250MB07377277565868EF7900C00B8F79A@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
[-- Attachment #1.1: Type: text/plain, Size: 1301 bytes --]
On Mon, Jun 23, 2025 at 12:43:54PM +0200, Andreas Rheinhardt wrote:
> Patch attached.
>
> - Andreas
> From e2b8892a583a09ca4aa607af8813b4947c2e6fc1 Mon Sep 17 00:00:00 2001
> From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> Date: Mon, 23 Jun 2025 12:41:36 +0200
> Subject: [PATCH] avcodec/g728dec: Remove AVCodec.sample_fmts
>
> It is unnecessary for decoders (they just set
> AVCodecContext.sample_fmt). This also fixes a warning
> with Clang (because sample_fmts is set directly,
> not via CODEC_SAMPLEFMTS).
ok
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavcodec/g728dec.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/libavcodec/g728dec.c b/libavcodec/g728dec.c
> index fdaf0a853e..edf45c589b 100644
> --- a/libavcodec/g728dec.c
> +++ b/libavcodec/g728dec.c
> @@ -215,6 +215,4 @@ const FFCodec ff_g728_decoder = {
> FF_CODEC_DECODE_CB(g728_decode_frame),
> .p.capabilities = AV_CODEC_CAP_CHANNEL_CONF |
> AV_CODEC_CAP_DR1,
> - .p.sample_fmts = (const enum AVSampleFormat[]) { AV_SAMPLE_FMT_FLT,
> - AV_SAMPLE_FMT_NONE },
> };
please apply
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-06-23 16:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 10:43 Andreas Rheinhardt
2025-06-23 16:40 ` Peter Ross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFmDfJFNxMbH6oR5@97128e981a0fdc76c1c3e90f890ef837 \
--to=pross@xvid.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git