From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Marton Balint <cus@passwd.hu>
Subject: Re: [FFmpeg-devel] [PATCH 2/7] avfilter/split: consume all frames before forwarding inlink status
Date: Wed, 18 Jun 2025 13:39:53 +0200
Message-ID: <aFKliXJ6gAMS8KMw@phare.normalesup.org> (raw)
In-Reply-To: <20250616224404.16142-2-cus@passwd.hu>
Marton Balint (HE12025-06-17):
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
> libavfilter/split.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavfilter/split.c b/libavfilter/split.c
> index bf004358d8..0557f54cce 100644
> --- a/libavfilter/split.c
> +++ b/libavfilter/split.c
> @@ -98,6 +98,7 @@ static int activate(AVFilterContext *ctx)
> av_frame_free(&in);
> if (ret < 0)
> return ret;
> + return 0;
> }
>
> if (ff_inlink_acknowledge_status(inlink, &status, &pts)) {
LGTM, good catch.
Regards,
--
Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-06-18 11:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 22:43 [FFmpeg-devel] [PATCH 1/7] fftools/ffmpeg_filter: simplify control flow in read_frames Marton Balint
2025-06-16 22:43 ` [FFmpeg-devel] [PATCH 2/7] avfilter/split: consume all frames before forwarding inlink status Marton Balint
2025-06-18 11:39 ` Nicolas George [this message]
2025-06-16 22:43 ` [FFmpeg-devel] [PATCH 3/7] avfilter/f_select: port to activate Marton Balint
2025-06-16 22:43 ` [FFmpeg-devel] [PATCH 4/7] avfilter/avfilter: simplify processing sinks without activate callback Marton Balint
2025-06-16 22:56 ` Andreas Rheinhardt
2025-06-16 23:02 ` Marton Balint
2025-06-16 23:54 ` Andreas Rheinhardt
2025-06-17 20:07 ` Marton Balint
2025-06-16 22:43 ` [FFmpeg-devel] [PATCH 5/7] avfilter/af_aresample: merge request_frame into activate function Marton Balint
2025-06-16 22:43 ` [FFmpeg-devel] [PATCH 6/7] avfilter/af_aresample: make aresample return FFERROR_NOT_READY when no progress can be made Marton Balint
2025-06-16 22:43 ` [FFmpeg-devel] [PATCH 7/7] avfilter/af_aresample: rework activate logic to follow the advised flow more strictly Marton Balint
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFKliXJ6gAMS8KMw@phare.normalesup.org \
--to=george@nsup.org \
--cc=cus@passwd.hu \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git