From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A382B4E4BC for ; Tue, 10 Jun 2025 00:30:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 0F6D468CDC2; Tue, 10 Jun 2025 03:29:58 +0300 (EEST) Received: from mx.sdf.org (mx.sdf.org [205.166.94.24]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id A7CDF68CD5F for ; Tue, 10 Jun 2025 03:29:51 +0300 (EEST) Received: from 6adec48d008b490a866cba579a4e4931 ([1.145.244.154]) (authenticated (0 bits)) by mx.sdf.org (8.18.1/8.14.3) with ESMTPSA id 55A0Tgnn019531 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO) for ; Tue, 10 Jun 2025 00:29:48 GMT Date: Tue, 10 Jun 2025 10:29:40 +1000 From: Peter Ross To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: <653c199c57434b5041cbaa34fe7c26f206a4bc90.1749463495.git.pross@xvid.org> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCHv3 7/8] avformat/aiff: G.728 muxing and demuxing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============9158108145896675711==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============9158108145896675711== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TYQeS1dfXLe5g7JR" Content-Disposition: inline --TYQeS1dfXLe5g7JR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 10, 2025 at 12:25:24AM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > --- > > libavformat/aiff.c | 1 + > > libavformat/aiffdec.c | 3 +++ > > 2 files changed, 4 insertions(+) > >=20 > > diff --git a/libavformat/aiff.c b/libavformat/aiff.c > > index 1ceac69a70..907f7d8d28 100644 > > --- a/libavformat/aiff.c > > +++ b/libavformat/aiff.c > > @@ -40,6 +40,7 @@ const AVCodecTag ff_codec_aiff_tags[] =3D { > > { AV_CODEC_ID_GSM, MKTAG('G','S','M',' ') }, > > { AV_CODEC_ID_ADPCM_G722, MKTAG('G','7','2','2') }, > > { AV_CODEC_ID_ADPCM_G726LE, MKTAG('G','7','2','6') }, > > + { AV_CODEC_ID_G728, MKTAG('G','7','2','8') }, > > { AV_CODEC_ID_PCM_S16BE, MKTAG('t','w','o','s') }, > > { AV_CODEC_ID_PCM_S16LE, MKTAG('s','o','w','t') }, > > { AV_CODEC_ID_ADPCM_IMA_QT, MKTAG('i','m','a','4') }, > > diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c > > index bd5bd2e4bb..aeb00cccd0 100644 > > --- a/libavformat/aiffdec.c > > +++ b/libavformat/aiffdec.c > > @@ -174,6 +174,9 @@ static int get_aiff_header(AVFormatContext *s, int6= 4_t size, > > case AV_CODEC_ID_GSM: > > par->block_align =3D 33; > > break; > > + case AV_CODEC_ID_G728: > > + par->block_align =3D 5; > > + break; > > default: > > aiff->block_duration =3D 1; > > break; > >=20 > Is this and the riff patch based on some spec or are you just inventing > things here? No inventions. The aiff patch is based on sample here: https://www.mmsp.ece.mcgill.ca/Documents/AudioFormats/AIFF/Samples.html Search for G.728. I am unsure what software was used to create that sample. The riff twocc's originate from binary G.728 ACM DLLs: kdg728.acm "Kedacom G.728" 0x0041=20 plcmg728.acm "Polycom G.728" 0xCD02 I have tested remuxing raw G.728 into riff wav using ffmpeg, and playing th= em back on windows using the ACM DLLs. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) --TYQeS1dfXLe5g7JR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSpB+AvpuUM0jTNINJnYHnFrEDdawUCaEd8cQAKCRBnYHnFrEDd a6zkAJ99x3X/BSS3q8eBH59R9KDOLthKBgCfc4zSDF8hr+2zqAXhrz3gFamgriQ= =8UCD -----END PGP SIGNATURE----- --TYQeS1dfXLe5g7JR-- --===============9158108145896675711== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============9158108145896675711==--