From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id E924C4CC43 for <ffmpegdev@gitmailbox.com>; Wed, 28 May 2025 07:52:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 50C6C68CC5D; Wed, 28 May 2025 10:52:05 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 05CF568CBC2 for <ffmpeg-devel@ffmpeg.org>; Wed, 28 May 2025 10:51:57 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 54S7puva011096 for <ffmpeg-devel@ffmpeg.org>; Wed, 28 May 2025 09:51:57 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id BE8C32EFE3; Wed, 28 May 2025 09:51:56 +0200 (CEST) Date: Wed, 28 May 2025 09:51:56 +0200 From: Nicolas George <george@nsup.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Message-ID: <aDbAnDvDWu0P0qin@phare.normalesup.org> References: <MEYP282MB18784DCA03D764E54E08FC8D88BB2@MEYP282MB1878.AUSP282.PROD.OUTLOOK.COM> <AS8P250MB0744B9A650221901E60022778F842@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> <MEYP282MB1878FF228716762A576B6BD38865A@MEYP282MB1878.AUSP282.PROD.OUTLOOK.COM> <MEYP282MB1878E2E6E43B5BA206A78E2F8865A@MEYP282MB1878.AUSP282.PROD.OUTLOOK.COM> <MEYP282MB18789A571C9E5354D966D4A08865A@MEYP282MB1878.AUSP282.PROD.OUTLOOK.COM> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <MEYP282MB18789A571C9E5354D966D4A08865A@MEYP282MB1878.AUSP282.PROD.OUTLOOK.COM> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Wed, 28 May 2025 09:51:57 +0200 (CEST) Subject: Re: [FFmpeg-devel] [FFmpeg-devel, v3, 0/2] avfilter: add PCM dumping between filters for audio debugging X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/aDbAnDvDWu0P0qin@phare.normalesup.org/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> Yibo Fang (HE12025-05-26): > > From: Yibo Fang <blueybf777@outlook.com> > Subject: [FFmpeg-devel,v3,0/2] avfilter: add PCM dumping between filters for audio debugging > Date: Wed, 23 Apr 2025 10:57:00 +0800 > Message-Id: <cover.0.2@ffmpeg> > > This series adds a debugging feature that lets developers dump raw > PCM audio between filters. The data are written to files in a user- > selected directory via two new commands: > > dump_raw_start file=/path/to/dir/ > dump_raw_stop > > Planar audio is automatically interleaved; only audio links are > affected. Patch 1/2 implements the feature, patch 2/2 documents it. Thanks for the changes. Unfortunately, you neglected to add documentation. User documentation is very important for features like that. Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".