From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id EAE2A4A536 for ; Tue, 20 May 2025 15:28:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id E554D68D9A1; Tue, 20 May 2025 18:27:56 +0300 (EEST) Received: from mail.treehouse.org.za (mail.treehouse.org.za [116.202.197.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id A3CB568D97B for ; Tue, 20 May 2025 18:27:55 +0300 (EEST) Received: from tim by mail.treehouse.org.za with local (Exim 4.97) (envelope-from ) id 1uHOsl-00000002XIv-15oK for ffmpeg-devel@ffmpeg.org; Tue, 20 May 2025 15:27:55 +0000 Date: Tue, 20 May 2025 17:27:55 +0200 To: ffmpeg-devel@ffmpeg.org Message-ID: MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH] Accept a colon in the path of a URI, instead of stripping preceding characters. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Timothy Allen via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Timothy Allen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Good day I wanted to offer a discussion of the referenced patch. I have found that, when a link in an extended M3U file (as used by HLS) includes a colon, FFmpeg will fail to load the file. The bug has already been reported: https://trac.ffmpeg.org/ticket/10679 The error reads: [hls @ 0x78dea4000c80] Failed to open segment 0 of playlist 0 [hls @ 0x78dea4000c80] Segment 0 of playlist 0 failed too many times, skipping The referenced patch fixes the issue. However, it is worth noting that the patch changes the behavior of one of the unit tests: - http://a/b/c/d;p?q g:h => g:h + http://a:b/c/d;p?q e => http://a:b/c/e The original unit test derives from the following two trac tickets: https://trac.ffmpeg.org/ticket/8813 https://trac.ffmpeg.org/ticket/8814 This is a breaking change, and, in particular, violates one specific example given in the rfc at https://tools.ietf.org/html/rfc3986#section-5.4 (the first example). In particular, it will affect cases where a URL consists only of host:port, with no scheme or path, and the base URL links to an unrelated host. Where before, the new link would take the form of "host:port", the new link will now use "host:port" as the last element of the path. I believe that this behaviour is more intuitive given modern use of URIs (and is replicated in many browsers), but I recognise this is a matter of taste. Thank you, Tim _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".