From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 346BD4E803
for <ffmpegdev@gitmailbox.com>; Wed, 7 May 2025 23:45:09 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1293568BFFD;
Thu, 8 May 2025 02:45:05 +0300 (EEST)
Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com
[209.85.128.47])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2CE7068B148
for <ffmpeg-devel@ffmpeg.org>; Thu, 8 May 2025 02:44:59 +0300 (EEST)
Received: by mail-wm1-f47.google.com with SMTP id
5b1f17b1804b1-43edecbfb46so3469375e9.0
for <ffmpeg-devel@ffmpeg.org>; Wed, 07 May 2025 16:44:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1746661498; x=1747266298; darn=ffmpeg.org;
h=user-agent:in-reply-to:content-disposition:mime-version:references
:mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc
:subject:date:message-id:reply-to;
bh=oS0AsCrtL2k2LgwSepD3BOQaI5WywAIH9f6991DiHmY=;
b=YL0vKttE+/hgQPg6gkv22kwFKp7WLqiZnlkMlGvPMBTNLJv6OVoyKqnepj5W4TTsSI
L2x6pTebb1Hzj/gB99ONeuOs9l6Gj42cC70WKqFE/P7zT36PR++J6i93FHI6TYEGLkCk
qZ2bqzZiuj6Xa8KvscdBpUWOQBH7kNNO0sm23fkyAAuQdNm1b3T8ZT7NrmxeXcv7LKvw
9r9Q2uaEBlkwi+C8tLlWsJWgJMyxyg/qiGw7MXMxKVUoH0ZLi3NlatIuXn/cigqHG0lr
vAuCTze0nIwev5R7b6Rnfvp2IEv+XSZn2ljTdVJL8kt8th2LkEmpTQMSEG4QIzJ3VZqz
y3xA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1746661498; x=1747266298;
h=user-agent:in-reply-to:content-disposition:mime-version:references
:mail-followup-to:message-id:subject:cc:to:from:date
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=oS0AsCrtL2k2LgwSepD3BOQaI5WywAIH9f6991DiHmY=;
b=WpQWjk/g4AvJG3QaKrtaV4Cj30EWQt4sCTQ/bXGYXlz/01YVCScLtNbSZZTVVVOdlV
XVY8hgbOwutlGa2fgTVi5gDoUAqrU7xCsasF5E65/+Uv1o/PheQ/2ibGJaO30p08G/4S
k6mWnJ/VIad2KNaa338q9OBiNk3RwRKblhvyPcV6MfH90Q6SbX2l1yov7jIVkphsi7Pg
87wnwwTo5a6cHEWp7YcJMEWJofVPaapkUbNKQLjAA34r+B6rGHdEkI9ZMOX2DNQzC05/
kdNbnXEKonRHlK57EQwm/MYJo6jI0MXeLZZtZx2Z0sMMcs+xT9DJhW6bSTBfyAR/owRF
LEzA==
X-Gm-Message-State: AOJu0YzN6qHH1dgKBjG2Y592cvKh5e72iv7/7mRArKGZYzbtkC2ftkBC
gA/UQXxT/unRwBmcdwThTQx68zCfxJUY3p+4OKRwUioBHA2sWTG8pw+pVg==
X-Gm-Gg: ASbGncu/LS8Z8J8YCFLXW58LHOnEfuHK0ttKJiNMsNIa3qXbXOnwBcXA5ps0xFOygkT
gwnhsXiu5bKuqh50M5mEFPIN/mCNAE9lg89QwQKyA6NIoUXp7T7BqK+UD2Hze2Rmx21UoJkelXi
bDkHYE4aRSueIhC2tBxzrCwH/+zKT6FwwUKIYCQcaj+uIWnkKal/PvDXZPI9nduGQ7sQhYR6rec
97RH+FweUgZRUNBegJZ/mzuHEs4AGHKT8XOcpeycKjiJZeq9wrFE0MqLt/W/S9E81Z9Xij7vMkA
SsVIHEa+yBK3GW05kcFxIbGN8zwKXLzIdsyRJ2iLwLBZA3ZBt7YK760su4FtVIXKSumD7PxaCVW
dmaPnyFxG6BMIIkU=
X-Google-Smtp-Source: AGHT+IE++pFKB75B/HQNmcTMAqdFDT8voOQIT4uN7Z3qd1qfVRtW3cKAWmLh2lkkrQ3hTRvWVN653A==
X-Received: by 2002:a05:600c:8716:b0:441:b3eb:570a with SMTP id
5b1f17b1804b1-441d44bbf09mr46813485e9.2.1746661497929;
Wed, 07 May 2025 16:44:57 -0700 (PDT)
Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it.
[84.220.189.10]) by smtp.gmail.com with ESMTPSA id
5b1f17b1804b1-442cd3285f9sm16957325e9.8.2025.05.07.16.44.57
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 07 May 2025 16:44:57 -0700 (PDT)
Received: by mariano (Postfix, from userid 1000)
id 1BE90BFCE8; Thu, 8 May 2025 01:44:56 +0200 (CEST)
Date: Thu, 8 May 2025 01:44:56 +0200
From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <aBvweAMgcV4iz0g5@mariano>
Mail-Followup-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>,
softworkz <softworkz-at-hotmail.com@ffmpeg.org>
References: <pull.66.v9.ffstaging.FFmpeg.1746260565.ffmpegagent@gmail.com>
<pull.66.v10.ffstaging.FFmpeg.1746327446.ffmpegagent@gmail.com>
<7e8fddd1b83a4ab9c1330612020f82af9377b6c5.1746327446.git.ffmpegagent@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <7e8fddd1b83a4ab9c1330612020f82af9377b6c5.1746327446.git.ffmpegagent@gmail.com>
User-Agent: Mutt/2.1.4 (2021-12-11)
Subject: Re: [FFmpeg-devel] [PATCH v10 01/15] fftools/textformat: Formatting
and whitespace changes
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: softworkz <softworkz@hotmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/aBvweAMgcV4iz0g5@mariano/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On date Sunday 2025-05-04 02:57:12 +0000, softworkz wrote:
> From: softworkz <softworkz@hotmail.com>
>
> Reviewed-by: Stefano Sabatini <stefasab@gmail.com>
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
> fftools/textformat/avtextformat.c | 92 +++++++++++++++---------------
> fftools/textformat/avtextformat.h | 20 +++----
> fftools/textformat/avtextwriters.h | 11 ++--
> fftools/textformat/tf_compact.c | 91 ++++++++++++++++-------------
> fftools/textformat/tf_default.c | 20 +++----
> fftools/textformat/tf_flat.c | 26 +++++----
> fftools/textformat/tf_ini.c | 36 ++++++------
> fftools/textformat/tf_json.c | 10 ++--
> fftools/textformat/tf_xml.c | 30 +++++-----
> 9 files changed, 177 insertions(+), 159 deletions(-)
>
[...]
> - if (show_data_hash) {
> + if (show_data_hash)
> if ((ret = av_hash_alloc(&tctx->hash, show_data_hash)) < 0) {
> if (ret == AVERROR(EINVAL)) {
> const char *n;
> @@ -211,7 +211,6 @@ int avtext_context_open(AVTextFormatContext **ptctx, const AVTextFormatter *form
> }
> return ret;
> }
> - }
For the record, I'm a bit against these kind of changes since they do
not really add to readability and might led to logical issues in case
an instruction is added to the else block and the parentheses are
discarded - but not so strongly opposed to block the patch though.
[...]
> -void avtext_print_section_header(AVTextFormatContext *tctx,
> - const void *data,
> - int section_id)
> +void avtext_print_section_header(AVTextFormatContext *tctx, const void *data, int section_id)
> {
> tctx->level++;
> av_assert0(tctx->level < SECTION_MAX_NB_LEVELS);
> @@ -272,8 +269,9 @@ void avtext_print_section_header(AVTextFormatContext *tctx,
> void avtext_print_section_footer(AVTextFormatContext *tctx)
> {
> int section_id = tctx->section[tctx->level]->id;
> - int parent_section_id = tctx->level ?
> - tctx->section[tctx->level-1]->id : SECTION_ID_NONE;
> + int parent_section_id = tctx->level
> + ? tctx->section[tctx->level - 1]->id
> + : SECTION_ID_NONE;
nit: I prefer the original form (it now looks less readable).
[...]
> if (section->flags & AV_TEXTFORMAT_SECTION_FLAG_HAS_TYPE) {
> // add /TYPE to prefix
> @@ -185,30 +189,33 @@ static void compact_print_section_header(AVTextFormatContext *wctx, const void *
> char c =
> (*p >= '0' && *p <= '9') ||
> (*p >= 'a' && *p <= 'z') ||
> - (*p >= 'A' && *p <= 'Z') ? av_tolower(*p) : '_';
> + (*p >= 'A' && *p <= 'Z')
> + ? (char)(char)av_tolower(*p)
> + : '_';
Ditto.
[...]
Should be good otherwise.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".