Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

From: Stefano Sabatini <stefasab@gmail.com>
To: "softworkz ." <softworkz@hotmail.com>
Cc: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface
Date: Thu, 8 May 2025 01:30:49 +0200
Message-ID: <aBvtKTXcsnlD688f@mariano> (raw)
In-Reply-To: <DM8P223MB0365C64B0C3BEB1C659F4DFABA8C2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>

On date Saturday 2025-05-03 08:55:42 +0000, softworkz . wrote:
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of softworkz .
> > Sent: Dienstag, 29. April 2025 01:24
> > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface
[...]
> Hello Stefano,
> 
> I have five new commits for this:
> 
> fftools/textformat: Rename variables wctx to tctx
> fftools/textformat: Cleanup unneeded includes
> fftools/textformat: Add validation for TextFormat API
> fftools/textformat: Add validation for AVTextWriter implementations
> fftools/textformat: Add validation for AVTextFormatter implementations
> 
> Yet I don't believe it makes sense to squash them once again back into 
> commits that you have reviewed already, they are much easier to review
> separately.
> 
> So, if you would agree, I'd merge the current patchset first (once 
> Michael confirms the zlib issue being resolved) and send the new commits
> as a new patchset then?

Feel free to merge patches which have been already approved or
approved with minor nits - in fact this will simplify the task of
reviewing. Please give some more time to review the other ones not yet
approved.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".