From: Peter Ross <pross@xvid.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 6/7] avcodec/rv60dec: inter also fails with qp >= 32
Date: Fri, 9 May 2025 19:07:51 +1000
Message-ID: <aB3F5565oyyqm6zR@28828826f30850df2d2bb146bd869914> (raw)
In-Reply-To: <20250508215738.3582069-6-michael@niedermayer.cc>
[-- Attachment #1.1: Type: text/plain, Size: 1110 bytes --]
On Thu, May 08, 2025 at 11:57:37PM +0200, Michael Niedermayer wrote:
> Fixes: out of array read in decode_cu_16x16()
> Fixes: 398049430/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV60_fuzzer-5525836849807360
>
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavcodec/rv60dec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/rv60dec.c b/libavcodec/rv60dec.c
> index 24981015a94..d704ae512c2 100644
> --- a/libavcodec/rv60dec.c
> +++ b/libavcodec/rv60dec.c
> @@ -1791,7 +1791,7 @@ static int decode_cu_r(RV60Context * s, AVFrame * frame, ThreadContext * thread,
> ttype = cu.pu_type == PU_FULL ? TRANSFORM_8X8 : TRANSFORM_4X4;
>
> is_intra = cu.cu_type == CU_INTRA;
> - if (is_intra && qp >= 32)
> + if (qp >= 32)
> return AVERROR_INVALIDDATA;
> cu_pos = ((xpos & 63) >> 3) + ((ypos & 63) >> 3) * 8;
please apply
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-05-09 9:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 21:57 [FFmpeg-devel] [PATCH 1/7] avcodec/mmvideo: fix paltte index Michael Niedermayer
2025-05-08 21:57 ` [FFmpeg-devel] [PATCH 2/7] avcodec/hevc/hevcdec: Check num_entry_point_offsets Michael Niedermayer
2025-05-29 23:48 ` Michael Niedermayer
2025-05-08 21:57 ` [FFmpeg-devel] [PATCH 3/7] avcodec/speexdec: Pass and check remaining packets to decode functions Michael Niedermayer
2025-05-29 23:48 ` Michael Niedermayer
2025-05-08 21:57 ` [FFmpeg-devel] [PATCH 4/7] avformat/iff: Check nb_channels == 0 in MHDR Michael Niedermayer
2025-05-09 9:07 ` Peter Ross
2025-05-09 9:25 ` Michael Niedermayer
2025-05-08 21:57 ` [FFmpeg-devel] [PATCH 5/7] avcodec/aac/aacdec_usac: Limit sfo from noise offset to be above -200 Michael Niedermayer
2025-05-08 21:57 ` [FFmpeg-devel] [PATCH 6/7] avcodec/rv60dec: inter also fails with qp >= 32 Michael Niedermayer
2025-05-09 9:07 ` Peter Ross [this message]
2025-05-09 9:25 ` Michael Niedermayer
2025-05-08 21:57 ` [FFmpeg-devel] [PATCH 7/7] avcodec/hevc/ps: Fix dependant layer id check Michael Niedermayer
2025-05-08 22:10 ` James Almer
2025-05-09 9:26 ` Michael Niedermayer
2025-05-09 9:06 ` [FFmpeg-devel] [PATCH 1/7] avcodec/mmvideo: fix paltte index Peter Ross
2025-05-09 9:26 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aB3F5565oyyqm6zR@28828826f30850df2d2bb146bd869914 \
--to=pross@xvid.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git