From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1437C4C417 for <ffmpegdev@gitmailbox.com>; Thu, 8 May 2025 21:26:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5282268C1C1; Fri, 9 May 2025 00:26:34 +0300 (EEST) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B0791687D20 for <ffmpeg-devel@ffmpeg.org>; Fri, 9 May 2025 00:26:27 +0300 (EEST) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43cfe63c592so14183505e9.2 for <ffmpeg-devel@ffmpeg.org>; Thu, 08 May 2025 14:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746739587; x=1747344387; darn=ffmpeg.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=qQM0Sl3np+dRr2tXzCGuRENHcLmoefzn8YU90BdHh2A=; b=nDEa9zaFClUI3gDlXzEAv0TrqsumOQtCFg3X6ncUVJlyu2CCNk3zTo3Mxi3aIDSUnM 1WpDjT9DaxwZWUlA7a9MsHbmXUVTrCVUoTqk2HaZAjXxatSg94iaumL2yFIZDBj8SMbk rPdKkGLvyhqg0Bc9DoTf3ytUXWMO5QBEW5OBT71uMT5IQA6b5OHZhizAtg7kBxaVd7+V 6wvRCNIvi36qkvS5a9UbnCfJnSBlhnwjeRXykgzghQT+oE1cBaIsGTbOa7k1rotUEeXh 0YyAAVXvvfkkBnYIRY5gcyWm9sJyRe75zKXAtZvGDelrLmB9oE65eZ70anoPHM+ndYWD dnTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746739587; x=1747344387; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qQM0Sl3np+dRr2tXzCGuRENHcLmoefzn8YU90BdHh2A=; b=D+5IM0Ww4yN93uN+Um7Hac8cWNfokr7jZd/GnW2PVxNQEaeBs2MVQUh0cChefYxyEB GuQkTKNHlRaGOfeYy+ZRnszpzdajDVFTAQ0lpA53bEYfXmw8jCCsdyArxI6JJ/Z1nYBj 9RcghMDOeZoSQWdao5PfjTanVUXi6bUzfWAdNwtGBDHn2st97TXANPFUHP5GQjVdS4Lq vTB16ydygxxLjM/EYv6LP3QJMkKcQMouRLZlijsXai7iprJO13Q3D115d3lxV8rKnkt8 0Lsl4T+tsDGUD7wqxasBvPNidP5UUo46ZZVxQhy9LpY34Ma6SAHN2+tbz2KFNMBSrQ9Q S51g== X-Gm-Message-State: AOJu0YxUbin0h8lVt97j6kWxQFc7IBU2rvCL4wj3p6urVv6jlftvULYq zg6H3b8z32woJh2wE4zWBEUBq8r4JBoMNXrd9ePF4UkT1S1dbHOIbCuZXw== X-Gm-Gg: ASbGncuK2fgMWa4fiGBAEfJMeT2kR48dTlx4WHNcxRhRUHhWbVXKAdojc3ozuPj6Df3 z7HaQOE/3THkQ2CZalrqc5nclPg0VTiaFK1uXQz+hlEkY5bQkiPteYeIaAGsSJE9f09no+PADU+ MCFFZUGDoY7V1aMEC0dbF0HTKO29xilBgIGuYU/8VgTphyPMLlNUY5M+KtNugx8atCQ4sggt/kf tLoc01PcNHDW5q7SjJqHhNAXm13hs4yqeYFyncKZdjQN37ce6gtK+a+WwCnluJgGsr1GIsLdVtv icgasJAbP+5ZK5QzUmw74YU2AOVfqcu7EQU90ZxPZzvm8i3fvt0ASOlxhpKKaf27ZqkXwxoFecr SUnRV X-Google-Smtp-Source: AGHT+IEv5YQpBFpPIlQFxbyhC5b55k9RsLgvlyarxycB5LJN3URdTXxGo2z5Tik6RP/MTuoWcd/1/g== X-Received: by 2002:a05:600c:190d:b0:441:b698:3431 with SMTP id 5b1f17b1804b1-442d6dde8e8mr4513835e9.28.1746739586472; Thu, 08 May 2025 14:26:26 -0700 (PDT) Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it. [84.220.189.10]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f58ebd6asm1107328f8f.35.2025.05.08.14.26.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 May 2025 14:26:26 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 1CCD1BFCE8; Thu, 8 May 2025 23:26:20 +0200 (CEST) Date: Thu, 8 May 2025 23:26:20 +0200 From: Stefano Sabatini <stefasab@gmail.com> To: "softworkz ." <softworkz@hotmail.com> Message-ID: <aB0hfKXU062/5fR3@mariano> Mail-Followup-To: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>, FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> References: <DM8P223MB036504CFC0521633C2ADCCE3BABB2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <12650153.O9o76ZdvQC@basile.remlab.net> <DM8P223MB03656267310C697B2094F675BA842@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <aA4J/XYOzKKMouhn@mariano> <DM8P223MB036535B434099A2C30D82559BA862@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <aBAAm5UlUYl72dqB@mariano> <DM8P223MB036544510099A04264475BE1BA812@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <DM8P223MB0365C64B0C3BEB1C659F4DFABA8C2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <aBvtKTXcsnlD688f@mariano> <DM8P223MB0365E5596B36A0BB6DBC844CBA88A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <DM8P223MB0365E5596B36A0BB6DBC844CBA88A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> User-Agent: Mutt/2.1.4 (2021-12-11) Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Cc: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/aB0hfKXU062%2F5fR3@mariano/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> On date Wednesday 2025-05-07 23:42:53 +0000, softworkz . wrote: > > -----Original Message----- > > From: Stefano Sabatini <stefasab@gmail.com> > > Sent: Donnerstag, 8. Mai 2025 01:31 > > To: softworkz . <softworkz@hotmail.com> > > Cc: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface > > > > On date Saturday 2025-05-03 08:55:42 +0000, softworkz . wrote: > > > > -----Original Message----- > > > > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > > softworkz . > > > > Sent: Dienstag, 29. April 2025 01:24 > > > > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > > > > Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface > > [...] > > > Hello Stefano, > > > > > > I have five new commits for this: > > > > > > fftools/textformat: Rename variables wctx to tctx > > > fftools/textformat: Cleanup unneeded includes > > > fftools/textformat: Add validation for TextFormat API > > > fftools/textformat: Add validation for AVTextWriter implementations > > > fftools/textformat: Add validation for AVTextFormatter implementations > > > > > > Yet I don't believe it makes sense to squash them once again back into > > > commits that you have reviewed already, they are much easier to review > > > separately. > > > > > > So, if you would agree, I'd merge the current patchset first (once > > > Michael confirms the zlib issue being resolved) and send the new commits > > > as a new patchset then? > > > > Feel free to merge patches which have been already approved or > > approved with minor nits - in fact this will simplify the task of > > reviewing. Please give some more time to review the other ones not yet > > approved. > > I sent out an e-mail yesterday, asking whether anybody would need more time, > and that I'm planning to apply by the end of the week otherwise. > The set is around for three weeks by now and afaik, at least Andreas > has reviewed the whole set already. > But if anybody needs more time, I'll surely postpone it. So I won't block on this, especially given that I don't have much time to review these days and this is not public API so it can be changed later with no user impact. I expressed some concerns about some design choices (e.g. the struct vs flags) which I'd like to be addressed though to avoid code churns later. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".