From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 11C5A4DC71
for <ffmpegdev@gitmailbox.com>; Wed, 23 Apr 2025 23:07:55 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8BAA968B510;
Thu, 24 Apr 2025 02:07:52 +0300 (EEST)
Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com
[209.85.218.49])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1F8B3687DED
for <ffmpeg-devel@ffmpeg.org>; Thu, 24 Apr 2025 02:07:46 +0300 (EEST)
Received: by mail-ej1-f49.google.com with SMTP id
a640c23a62f3a-acb615228a4so258051166b.0
for <ffmpeg-devel@ffmpeg.org>; Wed, 23 Apr 2025 16:07:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1745449665; x=1746054465; darn=ffmpeg.org;
h=user-agent:in-reply-to:content-disposition:mime-version:references
:mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc
:subject:date:message-id:reply-to;
bh=0/EppCsTsoyIzknylKbOy3DqKKhHcoOlu6Al8dUe9bg=;
b=RV1q/9qvH6mY5QEbLTZpWkBOV/Pt07Pf0FgS/ID+EfX+OmshzZGo4jO0KOFRfew5lc
Rw1FXQipjzHKoRcrdz81SBAtImeXvr0GRKR6KeRur2DAcA4C7ClrkvVzZ934+cWJZOh0
q3YfYIOA/dr3uVNtoQOZ1vA+1y6g88je3GJmQ2gGO5p2qDHrxpmo88pFL5BQo7HxT+v6
RRHSGqdlcIqmwDSH7MOAMnGrB8DuQX4IClPpzV8FTlPbsVmC6PQ7wA1P+sSYe5jVTONA
wlYm8qXh/YOSLzi9AJAVdI62crQCGYw5wRbACI8kNA8qQMU1pSdEXFIdRr6JrZmjJRaW
GUHQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1745449665; x=1746054465;
h=user-agent:in-reply-to:content-disposition:mime-version:references
:mail-followup-to:message-id:subject:cc:to:from:date
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=0/EppCsTsoyIzknylKbOy3DqKKhHcoOlu6Al8dUe9bg=;
b=o/x0MgjBRqkwVKXswk2ZYYrjjhxdqZc1qo/PqrH6XKkYMinze4BZZkRiUEYsur57qC
GCDRZsnklkeQ//P54WorKEyJS3Q8zVj3jpPITudHF/lAaJm+d0kdLu/PVhCOkr3zKE8l
HK/3bP1MURUIcYL3vQlmMPVFwEGZLoOfYC0nVWLkaccHSzWHaa77nkI+APhVoj4GFNK9
l9B2DIGDGIRA6PnOCPcx3xVCa1aZd0QhbP920yvQuwCrcEoSUWLiSpMxnssQyMwM/WZW
N7/2+qq/EvJyRtUj9ryKoV5Gl17P/Qed/zfLRp8xnUBJlVnoaaklpgAZS6YIQjt0ZndD
V4Sg==
X-Gm-Message-State: AOJu0YxXRz44f4+npamPMa9NyErOgmi3vnpteGtwWWqmpEEn3LMy7DCE
96/qU8tjjOiR5eOfi75YPDyGZMIimlVVpOoaJ1o4djv1PwId+bVmwit8wA==
X-Gm-Gg: ASbGncuI8tHvFuesIowjc2wF7kREElHaQjQH9t2ZNCCB7xFePP7iR6WkW8DdZb03rYS
sR6QBxts9RALlE5R/gDnm/1JQxHmY3qlJCUSA4NCq3yg2Touh53hncRbSQPpJma4il/EoRXtAH6
dMWjDdDIgg1n1FeNj9YHD+s3q2U3yKcRSD7PJOtusJNrTdZrbY2VsHvzSRw6oFNH7upNXb/deFT
9z2IN8SPoARh+w2YD36sWM8Fn6o17Z4Q6IbG5dMSQQvRocvs/ye2CEVwD8ZS3tF94N+ur/FGtkT
MGRQIbsp8/cKxrE47bDcUHJzzmUWDj/jMURvAMt9+a0QmGGAGf4Y8GUw5o5d6uDC6/C5eQrLEzx
LRy3w
X-Google-Smtp-Source: AGHT+IFAYzpasK+gzsDtwu9HqFEQMxnSaq25B5CpadedzIS9T880XRMeSN1mQ7eC9gZBOZHvZ/my0w==
X-Received: by 2002:a17:907:2d8d:b0:ac7:3441:79aa with SMTP id
a640c23a62f3a-ace5a2a9b58mr15784166b.13.1745449664974;
Wed, 23 Apr 2025 16:07:44 -0700 (PDT)
Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it.
[84.220.189.10]) by smtp.gmail.com with ESMTPSA id
a640c23a62f3a-ace59c25215sm8752166b.126.2025.04.23.16.07.44
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 23 Apr 2025 16:07:44 -0700 (PDT)
Received: by mariano (Postfix, from userid 1000)
id 3D0C9BFCE8; Thu, 24 Apr 2025 01:07:43 +0200 (CEST)
Date: Thu, 24 Apr 2025 01:07:43 +0200
From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <aAlyvwNl2DUSdj2T@mariano>
Mail-Followup-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>,
softworkz <softworkz-at-hotmail.com@ffmpeg.org>
References: <pull.66.v4.ffstaging.FFmpeg.1745189954.ffmpegagent@gmail.com>
<pull.66.v5.ffstaging.FFmpeg.1745358943.ffmpegagent@gmail.com>
<ecf6f061b21652fbe07110cbc09a5b76082a2f6f.1745358943.git.ffmpegagent@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <ecf6f061b21652fbe07110cbc09a5b76082a2f6f.1745358943.git.ffmpegagent@gmail.com>
User-Agent: Mutt/2.1.4 (2021-12-11)
Subject: Re: [FFmpeg-devel] [PATCH v5 06/14] fftools/textformat:
AVTextWriter change writer_printf signature
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: softworkz <softworkz@hotmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/aAlyvwNl2DUSdj2T@mariano/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On date Tuesday 2025-04-22 21:55:35 +0000, softworkz wrote:
> From: softworkz <softworkz@hotmail.com>
>
> Using va_list provides greater flebility
flebility typo
Also this looks more about factorization than flexibility (for an API
used directly by users the ... format is better).
>
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
> fftools/textformat/avtextwriters.h | 2 +-
> fftools/textformat/tw_avio.c | 7 ++-----
> fftools/textformat/tw_buffer.c | 7 ++-----
> fftools/textformat/tw_stdout.c | 8 ++------
> 4 files changed, 7 insertions(+), 17 deletions(-)
>
> diff --git a/fftools/textformat/avtextwriters.h b/fftools/textformat/avtextwriters.h
> index 34db3f1832..fd6da747eb 100644
> --- a/fftools/textformat/avtextwriters.h
> +++ b/fftools/textformat/avtextwriters.h
> @@ -41,7 +41,7 @@ typedef struct AVTextWriter {
> void (*uninit)(AVTextWriterContext *wctx);
> void (*writer_w8)(AVTextWriterContext *wctx, int b);
> void (*writer_put_str)(AVTextWriterContext *wctx, const char *str);
> - void (*writer_printf)(AVTextWriterContext *wctx, const char *fmt, ...);
> + void (*writer_printf)(AVTextWriterContext *wctx, const char *fmt, va_list vl);
If you change the signature, change also the name (writer_vprintf) of
the callback to make it clear it takes a va_list.
> } AVTextWriter;
>
> typedef struct AVTextWriterContext {
> diff --git a/fftools/textformat/tw_avio.c b/fftools/textformat/tw_avio.c
> index 29889598bb..7d52dc4cf5 100644
> --- a/fftools/textformat/tw_avio.c
> +++ b/fftools/textformat/tw_avio.c
> @@ -57,14 +57,11 @@ static void io_put_str(AVTextWriterContext *wctx, const char *str)
> avio_write(ctx->avio_context, (const unsigned char *)str, (int)strlen(str));
> }
>
> -static void io_printf(AVTextWriterContext *wctx, const char *fmt, ...)
> +static void io_printf(AVTextWriterContext *wctx, const char *fmt, va_list vl)
> {
> IOWriterContext *ctx = wctx->priv;
> - va_list ap;
>
> - va_start(ap, fmt);
> - avio_vprintf(ctx->avio_context, fmt, ap);
> - va_end(ap);
> + avio_vprintf(ctx->avio_context, fmt, vl);
> }
>
>
> diff --git a/fftools/textformat/tw_buffer.c b/fftools/textformat/tw_buffer.c
> index f8b38414a6..f861722247 100644
> --- a/fftools/textformat/tw_buffer.c
> +++ b/fftools/textformat/tw_buffer.c
> @@ -56,14 +56,11 @@ static void buffer_put_str(AVTextWriterContext *wctx, const char *str)
> av_bprintf(ctx->buffer, "%s", str);
> }
>
> -static void buffer_printf(AVTextWriterContext *wctx, const char *fmt, ...)
> +static void buffer_printf(AVTextWriterContext *wctx, const char *fmt, va_list vl)
> {
> BufferWriterContext *ctx = wctx->priv;
>
> - va_list vargs;
> - va_start(vargs, fmt);
> - av_vbprintf(ctx->buffer, fmt, vargs);
> - va_end(vargs);
> + av_vbprintf(ctx->buffer, fmt, vl);
> }
>
>
> diff --git a/fftools/textformat/tw_stdout.c b/fftools/textformat/tw_stdout.c
> index 23de6f671f..dace55f38a 100644
> --- a/fftools/textformat/tw_stdout.c
> +++ b/fftools/textformat/tw_stdout.c
> @@ -53,13 +53,9 @@ static inline void stdout_put_str(AVTextWriterContext *wctx, const char *str)
> printf("%s", str);
> }
>
> -static inline void stdout_printf(AVTextWriterContext *wctx, const char *fmt, ...)
> +static inline void stdout_printf(AVTextWriterContext *wctx, const char *fmt, va_list vl)
> {
> - va_list ap;
> -
> - va_start(ap, fmt);
> - vprintf(fmt, ap);
> - va_end(ap);
> + vprintf(fmt, vl);
> }
>
>
> --
> ffmpeg-codebot
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".