From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 093234D9E9
for <ffmpegdev@gitmailbox.com>; Mon, 21 Apr 2025 17:28:57 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3EFAA687DE7;
Mon, 21 Apr 2025 20:28:52 +0300 (EEST)
Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com
[209.85.218.44])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E3596687D7D
for <ffmpeg-devel@ffmpeg.org>; Mon, 21 Apr 2025 20:28:45 +0300 (EEST)
Received: by mail-ej1-f44.google.com with SMTP id
a640c23a62f3a-aaee2c5ee6eso439051466b.1
for <ffmpeg-devel@ffmpeg.org>; Mon, 21 Apr 2025 10:28:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1745256525; x=1745861325; darn=ffmpeg.org;
h=user-agent:in-reply-to:content-disposition:mime-version:references
:mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc
:subject:date:message-id:reply-to;
bh=46iqrQKyB/wmxXFpHMXtClONGRXYGbx8thxpZXTZbBo=;
b=EGDfWUmjUIurr+7m8Pt8xqbhwzKi8Bv5UgOIF6x2DbnWRv0xRaDWljlYOgMi7jYucJ
nerwjGyIWlGPjhqoSA95xVc3FBen4dsWhCwHyVjfUyO963QPLhw7dz9nvIMP3kTaPwRS
eOW8k6x/GyTVAahHO+ulUvO4VEyQKhXDERo7ZyZCIyeR2eUtdbnAPwmESuyuUzvdDR4F
MFjT/8JHSFwnJ+zTPsSviLgDg0M+DR6gHSiY5QIogh4V78cIOPrROp3LfZq2NaIuoo8Z
r9afBrWe8z/sU5tUA4cdif9OhX8OEz2Ogqr9nWS37gYx5uHd+rBN7gXlvU2xqaKTHkCb
n/Tw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1745256525; x=1745861325;
h=user-agent:in-reply-to:content-disposition:mime-version:references
:mail-followup-to:message-id:subject:cc:to:from:date
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=46iqrQKyB/wmxXFpHMXtClONGRXYGbx8thxpZXTZbBo=;
b=hZG2GKv3VhxkVnQFZz1lKMzIACpXhCGJccsxDbu7wyPlD3xYNIuODayTmRYYYSC8uK
Dt8vR9NQMBu8MmwOyvedma/jq8AFbXM1I7qkg48xsxiBPUEJzhj+h6wmDYvZDZhrbdAd
NxzFWrms9jSemsx/4sBRLO5Cq9JWvuc/PVc7+cr7j20CgtfZT0C4iytkOl81JcZG5nUw
rS5a9RxA4LxJlQ0TvPLL5rsuWAvoo9GL16TjVPyXZ8AtYWk2Ip7JVUGKoWoHeZgf7ce3
t0aCWnirk1f46IrAvyoYmUQ1sapYQQK5viQq2q1iXfM3LQoK/xAEP7I6cT1/Lyxw+zQD
dzew==
X-Gm-Message-State: AOJu0YwbAdV4e55unNMnG4d1ERxgSojkWIpbCz2bs4GgIWz1QdtUPBrb
jsykfj7052vnXOQfRY+vgQ1bqbRXndAChs+qTsWb0JPTZiLmCYc8Jd9DRQ==
X-Gm-Gg: ASbGncs4oRrl+cCHau27me2oYSQyMUfTYIIfS/I6yer3lUyW00bZoPjQJWIOhRZ33Zt
InGhI2T/BkRoMimXh/fjx2ImocJgHNjezJxwcZvJFX9YnXNb0Aj2FsUUN6G3m+CBdoaMUngFzNA
T11gTFJguyEqdRziJvXGHQcSyBP+wHF92hTbCL8n3nKB+QgpfsDBIbnrKt5CyFL/QcbHJiY/Xc3
DjkQ7q0qA6kLX8fwQ6p98N0nB42AlCF3K22jNIuw90AulJ5yedJOuML0SOJGYi+8j9ssBN/fVCA
lUEUa1Aie1xDjdEW4lt29qHR9z2nNEYZUZPkOCull4UuKf5tVRsTqd6pgFzoR1rfiYE9R4oAlaj
5Ph4R
X-Google-Smtp-Source: AGHT+IH+afNcE8U6UDIA6U7IuRj0HSE7mvNbFo8UFTSOko8NyCBbNDheUi0reqY6AtfXMXUW28vepA==
X-Received: by 2002:a17:907:86a3:b0:ac7:efee:d256 with SMTP id
a640c23a62f3a-acb74dd85d9mr995756766b.59.1745256524413;
Mon, 21 Apr 2025 10:28:44 -0700 (PDT)
Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it.
[84.220.189.10]) by smtp.gmail.com with ESMTPSA id
a640c23a62f3a-acb6eefcf97sm531582566b.88.2025.04.21.10.28.43
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 21 Apr 2025 10:28:43 -0700 (PDT)
Received: by mariano (Postfix, from userid 1000)
id 9C4D8BFCE8; Mon, 21 Apr 2025 19:28:42 +0200 (CEST)
Date: Mon, 21 Apr 2025 19:28:42 +0200
From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <aAaASiOjqG9HF+uu@mariano>
Mail-Followup-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>,
softworkz <softworkz-at-hotmail.com@ffmpeg.org>
References: <pull.66.v3.ffstaging.FFmpeg.1744945024.ffmpegagent@gmail.com>
<pull.66.v4.ffstaging.FFmpeg.1745189954.ffmpegagent@gmail.com>
<7024548b9262e2687c796809a41fc5747b11f396.1745189955.git.ffmpegagent@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <7024548b9262e2687c796809a41fc5747b11f396.1745189955.git.ffmpegagent@gmail.com>
User-Agent: Mutt/2.1.4 (2021-12-11)
Subject: Re: [FFmpeg-devel] [PATCH v4 03/11] fftools/textformat: Introduce
common header and deduplicate code
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: softworkz <softworkz@hotmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/aAaASiOjqG9HF+uu@mariano/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On date Sunday 2025-04-20 22:59:06 +0000, softworkz wrote:
> From: softworkz <softworkz@hotmail.com>
>
> Signed-off-by: softworkz <softworkz@hotmail.com>
first part should be good
[...]
> diff --git a/fftools/textformat/tw_avio.c b/fftools/textformat/tw_avio.c
> index d1b494b7b4..48868ebf5d 100644
> --- a/fftools/textformat/tw_avio.c
> +++ b/fftools/textformat/tw_avio.c
> @@ -56,14 +56,11 @@ static void io_put_str(AVTextWriterContext *wctx, const char *str)
> avio_write(ctx->avio_context, (const unsigned char *)str, (int)strlen(str));
> }
>
> -static void io_printf(AVTextWriterContext *wctx, const char *fmt, ...)
> +static void io_printf(AVTextWriterContext *wctx, const char *fmt, va_list vl)
> {
> IOWriterContext *ctx = wctx->priv;
> - va_list ap;
>
> - va_start(ap, fmt);
> - avio_vprintf(ctx->avio_context, fmt, ap);
> - va_end(ap);
> + avio_vprintf(ctx->avio_context, fmt, vl);
> }
>
>
> diff --git a/fftools/textformat/tw_buffer.c b/fftools/textformat/tw_buffer.c
> index f8b38414a6..f861722247 100644
> --- a/fftools/textformat/tw_buffer.c
> +++ b/fftools/textformat/tw_buffer.c
> @@ -56,14 +56,11 @@ static void buffer_put_str(AVTextWriterContext *wctx, const char *str)
> av_bprintf(ctx->buffer, "%s", str);
> }
>
> -static void buffer_printf(AVTextWriterContext *wctx, const char *fmt, ...)
> +static void buffer_printf(AVTextWriterContext *wctx, const char *fmt, va_list vl)
> {
> BufferWriterContext *ctx = wctx->priv;
>
> - va_list vargs;
> - va_start(vargs, fmt);
> - av_vbprintf(ctx->buffer, fmt, vargs);
> - va_end(vargs);
> + av_vbprintf(ctx->buffer, fmt, vl);
> }
>
>
> diff --git a/fftools/textformat/tw_stdout.c b/fftools/textformat/tw_stdout.c
> index 23de6f671f..dace55f38a 100644
> --- a/fftools/textformat/tw_stdout.c
> +++ b/fftools/textformat/tw_stdout.c
> @@ -53,13 +53,9 @@ static inline void stdout_put_str(AVTextWriterContext *wctx, const char *str)
> printf("%s", str);
> }
>
> -static inline void stdout_printf(AVTextWriterContext *wctx, const char *fmt, ...)
> +static inline void stdout_printf(AVTextWriterContext *wctx, const char *fmt, va_list vl)
> {
> - va_list ap;
> -
> - va_start(ap, fmt);
> - vprintf(fmt, ap);
> - va_end(ap);
> + vprintf(fmt, vl);
> }
This looks like a logically different change and I'd rather move to a
dedicated commit.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".