From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 03DF34D9A4
for <ffmpegdev@gitmailbox.com>; Mon, 21 Apr 2025 16:14:25 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0BE1A687BCD;
Mon, 21 Apr 2025 19:14:19 +0300 (EEST)
Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com
[209.85.208.47])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 798E2687AA6
for <ffmpeg-devel@ffmpeg.org>; Mon, 21 Apr 2025 19:14:12 +0300 (EEST)
Received: by mail-ed1-f47.google.com with SMTP id
4fb4d7f45d1cf-5f624291db6so5033860a12.3
for <ffmpeg-devel@ffmpeg.org>; Mon, 21 Apr 2025 09:14:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1745252051; x=1745856851; darn=ffmpeg.org;
h=user-agent:in-reply-to:content-disposition:mime-version:references
:mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc
:subject:date:message-id:reply-to;
bh=zV+gfhCbyR6nHMyWMUdklfyKKK84dHG5T+svYDEhl+s=;
b=XhTxDBcb4mOTI5BWcJyb2GhrW5t0mVFDHQsDAShHhph6va8albR7q9tO3Nd9BHDIlX
g5NLJoaqB42tDWZWvrCBz7olTZf4YwaWpT2p/TtgpPPG/kUylxwfyPAlbtmtmK+oV3cg
tRpF3tk/V0NbRqDb26Amo/cpr7T0WDpqYIZ/3mmGAPKZ1uXLSM+02duxZt3yGVR6KlD3
iovZEo4ILqhTQbG/bDVOXmA1vCYktF8g3UA+NWxZ/pB/T264sfDJZobnaTsmueTKXqgT
yiArhOwJVt+jvYqgXJLlSBO+wWCgljoJ2TINTAjC5FmzXcgqeQ84D1hf12N3UqVpdE/K
txyA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1745252051; x=1745856851;
h=user-agent:in-reply-to:content-disposition:mime-version:references
:mail-followup-to:message-id:subject:cc:to:from:date
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=zV+gfhCbyR6nHMyWMUdklfyKKK84dHG5T+svYDEhl+s=;
b=fMllzKvGKhq/MG55lmnx0bMZc4nucPDFDJ0XbiSCFY8NOfvMlkrZH8fQr14nfp488H
AMGUrJ+6C4131EDrlyk1o+ePJ8+jTj6oFKppPA0I3AU1XF9oShYzm98oTBOaflkWCX+c
8wAd/E+yFSee5NvAcvW1bCrueFpnA+DwU8ivvEaO62ystwH8nRrYUVR/0D7HqyEpFFhR
Dgcw9llxuZG79nokBEcpnSKzWxb2cPZfZOuD9A7TpQGfPnIXllY/jbHCOlzWb+OTi4CS
AvMEAs8+PUHJQu6H8GW5FFNoRouI2stwYPPq0keYveA6BfFQM7lrse16OpXNaJmChTUw
6brg==
X-Gm-Message-State: AOJu0YzmUeuMqGqVY6TRLLACbxj+WBymDy+LCPcafBcgjcYdTjrPpNCN
nZULu5d3SrFwzLW/fsmgTdNTW8JWfcKEhw9vzwKSh2o/CbvPULctFJosow==
X-Gm-Gg: ASbGncvBLk2YhJRIplhyC6pFQACWPhWIgkSMJbTFBs+KxPh0hGo8kHEBUMQDVHVWfmh
nhJ6fvC5A2KCDiKePbC6dAQt6zwz4lNzZoJVHlkX99jPDz5xYQg/OfXawRyaYTGkLPPyf3OafVq
risR0QGfF2W+5EOUX/qMGTAiqqy6tE/w7VBWJR4WvuFFPFhC/PCCxXvIcDvqCr+y+9n6zMjpEzm
CUrwbiq1sbM8dkHly6xAvIBI1g0V6dhDY0XABqlEmsQiFxXc3Aei8xMReuM7RYPQhEB3LOmEB4v
hRczx5OP1tR4S/xRS4sHG5Pjd2f4
X-Google-Smtp-Source: AGHT+IFse37OmXnmjZMEg2FJjGRypiePKGjCdycMmGh+Sj+nVDzmi3FRpDVs2kp35TIUA5Ak46EIKA==
X-Received: by 2002:a05:6402:5249:b0:5e7:c438:83ec with SMTP id
4fb4d7f45d1cf-5f62850bfadmr8956527a12.6.1745252051287;
Mon, 21 Apr 2025 09:14:11 -0700 (PDT)
Received: from mariano ([84.220.189.10]) by smtp.gmail.com with ESMTPSA id
4fb4d7f45d1cf-5f6258342e5sm4688301a12.60.2025.04.21.09.14.10
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 21 Apr 2025 09:14:10 -0700 (PDT)
Received: by mariano (Postfix, from userid 1000)
id 56942BFCE8; Mon, 21 Apr 2025 18:14:07 +0200 (CEST)
Date: Mon, 21 Apr 2025 18:14:07 +0200
From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <aAZuz57GMrjc3T5z@mariano>
Mail-Followup-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>,
softworkz <softworkz-at-hotmail.com@ffmpeg.org>
References: <pull.71.v2.ffstaging.FFmpeg.1745179839217.ffmpegagent@gmail.com>
<pull.71.v3.ffstaging.FFmpeg.1745180141145.ffmpegagent@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <pull.71.v3.ffstaging.FFmpeg.1745180141145.ffmpegagent@gmail.com>
User-Agent: Mutt/2.1.4 (2021-12-11)
Subject: Re: [FFmpeg-devel] [PATCH v3] fftools/ffprobe: Print size of
attachments
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: softworkz <softworkz@hotmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/aAZuz57GMrjc3T5z@mariano/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On date Sunday 2025-04-20 20:15:41 +0000, softworkz wrote:
> From: softworkz <softworkz@hotmail.com>
>
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
> fftools/ffprobe: Print size of attachments
>
>
> Versions
> ========
>
> V2
>
> Fix spurious commit message text as noted by Andreas (thanks!)
>
> V3
>
> Also removed from the cover-letter part
>
> Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-71%2Fsoftworkz%2Fsubmit_attachment_size-v3
> Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-71/softworkz/submit_attachment_size-v3
> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/71
>
> Range-diff vs v2:
>
> 1: dd35a56e25 = 1: b3456eb9f6 fftools/ffprobe: Print size of attachments
>
>
> doc/ffprobe.xsd | 3 +++
> fftools/ffprobe.c | 4 ++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/doc/ffprobe.xsd b/doc/ffprobe.xsd
> index b53b799227..8c2326e499 100644
> --- a/doc/ffprobe.xsd
> +++ b/doc/ffprobe.xsd
> @@ -319,6 +319,9 @@
> <xsd:attribute name="nb_frames" type="xsd:int"/>
> <xsd:attribute name="nb_read_frames" type="xsd:int"/>
> <xsd:attribute name="nb_read_packets" type="xsd:int"/>
> +
> + <!-- attachment attributes -->
> + <xsd:attribute name="attachment_size" type="xsd:int"/>
> </xsd:complexType>
>
> <xsd:complexType name="programType">
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index f5c83925b9..0da44b8c49 100644
> --- a/fftools/ffprobe.c
> +++ b/fftools/ffprobe.c
> @@ -1847,6 +1847,10 @@ static int show_stream(AVTextFormatContext *tfc, AVFormatContext *fmt_ctx, int s
> else
> print_str_opt("height", "N/A");
> break;
> +
> + case AVMEDIA_TYPE_ATTACHMENT:
> + if (par->extradata_size)
> + print_int("attachment_size", par->extradata_size);
Would it make sense to print the extradata_size in each case to make
this more generic?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".