From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id D98E24D9C3
	for <ffmpegdev@gitmailbox.com>; Mon, 21 Apr 2025 17:01:00 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E04B6687DF2;
	Mon, 21 Apr 2025 20:00:56 +0300 (EEST)
Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 97789687D61
 for <ffmpeg-devel@ffmpeg.org>; Mon, 21 Apr 2025 20:00:50 +0300 (EEST)
X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org )
Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80])
 by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 53LH0nd6024635
 for <ffmpeg-devel@ffmpeg.org>; Mon, 21 Apr 2025 19:00:50 +0200
Received: by phare.normalesup.org (Postfix, from userid 1001)
 id DDB522EFE7; Mon, 21 Apr 2025 19:00:49 +0200 (CEST)
Date: Mon, 21 Apr 2025 19:00:49 +0200
From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <aAZ5weDY5OOMD9un@phare.normalesup.org>
References: <20250407181039.353242-1-tfoucu@google.com>
 <CACXFHsSsjasrWuik2K-R1Mf6iP1Xnv1TC6Zcm9MF9MxrmsUKzQ@mail.gmail.com>
 <a8c8199f-7f17-4d48-933a-72d47b32c289@gmail.com>
 <CACXFHsStNyNa-ds6FdG=8C2EcWf_cZ95AWyvS4dHwk=No46fsA@mail.gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <CACXFHsStNyNa-ds6FdG=8C2EcWf_cZ95AWyvS4dHwk=No46fsA@mail.gmail.com>
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3
 (nef.ens.fr [129.199.96.32]); Mon, 21 Apr 2025 19:00:50 +0200 (CEST)
Subject: Re: [FFmpeg-devel] [PATCH 2/2] libavformat/takdec.c: Fix msan error.
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/aAZ5weDY5OOMD9un@phare.normalesup.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Thierry Foucu (HE12025-04-21):
> > >> -            avio_read(pb, md5, 16);
> > >> +            if (avio_read(pb, md5, 16) != 16) {
> > >> +                return AVERROR(EIO);
> > Should be AVERROR_INVALIDDATA imo, since i means the file is just
> > truncated. It wasn't an error in the protocol reading data.
> Regarding the error message, I was trying to be consistent with the other
> avio_read error, like here:
> https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/takdec.c#L99

Both codes are wrong: if avio_read() returns an error, it must be
returned as is, not a new error invented.

And if avio_read() returns less than requested, then I agree with James,
INVALID_DATA is more correct than EIO. In both places.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".