From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] libavformat/takdec.c: Fix msan error.
Date: Mon, 21 Apr 2025 19:00:49 +0200
Message-ID: <aAZ5weDY5OOMD9un@phare.normalesup.org> (raw)
In-Reply-To: <CACXFHsStNyNa-ds6FdG=8C2EcWf_cZ95AWyvS4dHwk=No46fsA@mail.gmail.com>
Thierry Foucu (HE12025-04-21):
> > >> - avio_read(pb, md5, 16);
> > >> + if (avio_read(pb, md5, 16) != 16) {
> > >> + return AVERROR(EIO);
> > Should be AVERROR_INVALIDDATA imo, since i means the file is just
> > truncated. It wasn't an error in the protocol reading data.
> Regarding the error message, I was trying to be consistent with the other
> avio_read error, like here:
> https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/takdec.c#L99
Both codes are wrong: if avio_read() returns an error, it must be
returned as is, not a new error invented.
And if avio_read() returns less than requested, then I agree with James,
INVALID_DATA is more correct than EIO. In both places.
Regards,
--
Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-04-21 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250407181039.353242-1-tfoucu@google.com>
2025-04-17 19:08 ` Thierry Foucu
2025-04-17 20:25 ` James Almer
2025-04-21 16:56 ` Thierry Foucu
2025-04-21 17:00 ` Nicolas George [this message]
2025-04-21 17:40 ` Thierry Foucu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAZ5weDY5OOMD9un@phare.normalesup.org \
--to=george@nsup.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git