From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 9C2D04D9E2
	for <ffmpegdev@gitmailbox.com>; Mon, 21 Apr 2025 17:21:13 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 82525687DF1;
	Mon, 21 Apr 2025 20:21:08 +0300 (EEST)
Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 98621687D65
 for <ffmpeg-devel@ffmpeg.org>; Mon, 21 Apr 2025 20:21:01 +0300 (EEST)
X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org )
Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80])
 by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 53LHL0ms028348
 for <ffmpeg-devel@ffmpeg.org>; Mon, 21 Apr 2025 19:21:01 +0200
Received: by phare.normalesup.org (Postfix, from userid 1001)
 id D3B032EFE7; Mon, 21 Apr 2025 19:21:00 +0200 (CEST)
Date: Mon, 21 Apr 2025 19:21:00 +0200
From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <aAZ-fCizfRETc7vG@phare.normalesup.org>
References: <pull.66.v3.ffstaging.FFmpeg.1744945024.ffmpegagent@gmail.com>
 <pull.66.v4.ffstaging.FFmpeg.1745189954.ffmpegagent@gmail.com>
 <1516e67a5b216022a1ecc2292ee8e2989cfda192.1745189955.git.ffmpegagent@gmail.com>
 <aAZ9hFakRwILdeRP@mariano>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <aAZ9hFakRwILdeRP@mariano>
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3
 (nef.ens.fr [129.199.96.32]); Mon, 21 Apr 2025 19:21:01 +0200 (CEST)
Subject: Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: Quality
 improvements
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/aAZ-fCizfRETc7vG@phare.normalesup.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Stefano Sabatini (HE12025-04-21):
> > +    if (!pwctx || !avio_ctx)
> > +        return AVERROR(EINVAL);
> > +
> maybe warning in this case as well

Checking that an argument that must not be null is not null is the
responsibility of the caller: crashing here is the right thing to do,
same as fprintf(NULL, "fmt").

Therefore, an assertion is the best choice.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".