From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 470AE40EDB
	for <ffmpegdev@gitmailbox.com>; Sun, 20 Apr 2025 15:10:21 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A839F687C63;
	Sun, 20 Apr 2025 18:10:17 +0300 (EEST)
Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8367A687C87
 for <ffmpeg-devel@ffmpeg.org>; Sun, 20 Apr 2025 18:10:10 +0300 (EEST)
X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org )
Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80])
 by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 53KFA9Nh003075
 for <ffmpeg-devel@ffmpeg.org>; Sun, 20 Apr 2025 17:10:10 +0200
Received: by phare.normalesup.org (Postfix, from userid 1001)
 id C31AF2EFE4; Sun, 20 Apr 2025 17:10:09 +0200 (CEST)
Date: Sun, 20 Apr 2025 17:10:09 +0200
From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <aAUOUUcrNX9G5Pr5@phare.normalesup.org>
References: <20250420130841.46245-1-emma@emma.gg>
 <20250420130841.46245-2-emma@emma.gg>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20250420130841.46245-2-emma@emma.gg>
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3
 (nef.ens.fr [129.199.96.32]); Sun, 20 Apr 2025 17:10:10 +0200 (CEST)
Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/dxvenc: migrate DXT1 encoder to
 lavu hashtable and improve Resolume compatibility
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/aAUOUUcrNX9G5Pr5@phare.normalesup.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Emma Worley (HE12025-04-20):
> Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/dxvenc: migrate DXT1 encoder to
>  lavu hashtable and improve Resolume compatibility

Thanks for the patch. Are the two indissociably linked? I have trouble
imagining it.

Unless there is a strong reason making it impossible, it should be two
separate commits:

- one that refactors the code but does not change the output at all,
  FATE tests guaranteeing it;

- one that improve the encoding and changes the output.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".