From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/dxvenc: migrate DXT1 encoder to lavu hashtable and improve Resolume compatibility
Date: Sun, 20 Apr 2025 17:10:09 +0200
Message-ID: <aAUOUUcrNX9G5Pr5@phare.normalesup.org> (raw)
In-Reply-To: <20250420130841.46245-2-emma@emma.gg>
Emma Worley (HE12025-04-20):
> Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/dxvenc: migrate DXT1 encoder to
> lavu hashtable and improve Resolume compatibility
Thanks for the patch. Are the two indissociably linked? I have trouble
imagining it.
Unless there is a strong reason making it impossible, it should be two
separate commits:
- one that refactors the code but does not change the output at all,
FATE tests guaranteeing it;
- one that improve the encoding and changes the output.
Regards,
--
Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-04-20 15:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-20 13:08 [FFmpeg-devel] [PATCH 1/2] lavu/hashtable: create generic robin hood hash table Emma Worley
2025-04-20 13:08 ` [FFmpeg-devel] [PATCH 2/2] lavc/dxvenc: migrate DXT1 encoder to lavu hashtable and improve Resolume compatibility Emma Worley
2025-04-20 15:10 ` Nicolas George [this message]
2025-04-20 15:15 ` James Almer
2025-04-20 15:20 ` [FFmpeg-devel] [PATCH 1/2] lavu/hashtable: create generic robin hood hash table Nicolas George
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAUOUUcrNX9G5Pr5@phare.normalesup.org \
--to=george@nsup.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git