From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id ACB7A4E013
for <ffmpegdev@gitmailbox.com>; Sun, 27 Apr 2025 10:47:47 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 569AF68A48C;
Sun, 27 Apr 2025 13:47:41 +0300 (EEST)
Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com
[209.85.221.50])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8DD50687D72
for <ffmpeg-devel@ffmpeg.org>; Sun, 27 Apr 2025 13:47:34 +0300 (EEST)
Received: by mail-wr1-f50.google.com with SMTP id
ffacd0b85a97d-39c1ef4acf2so2715215f8f.0
for <ffmpeg-devel@ffmpeg.org>; Sun, 27 Apr 2025 03:47:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1745750853; x=1746355653; darn=ffmpeg.org;
h=user-agent:in-reply-to:content-disposition:mime-version:references
:mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc
:subject:date:message-id:reply-to;
bh=HNsRJx7etyHIPrvzGbuUUG77VLySCbxt0WbkufcLfmA=;
b=c7irrcHD8jIODZBJNt7D7ph1WFMnxjwtEYHuxinhTgXC8FXD89KT+uSYgJ01BMC9OI
EjrATEjYqxbxvG+ms3T5BOJfsntj+NVG04Vq6xflk4na9rvBsaA5qT499l766H+Q0PLm
cNej9INRdTKjq4fTGAgAfLgow7OGsnlrJ+CnTgcjjV8eW2nvepPm+UdJP0CQEuukURj5
JuniSz0NyvyTnB66+KXpfuPZ5lErRy5mq0xyKbY5AA88jFeV2N3OAxVn4QBlCVgUgmfk
QTdOCZDBtkvokxe0xbmlEMxWkuTe6+IGUfgqh/7XzCUIUNy1BPk6LLW7Y2sjKHua8Qdg
V+jQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1745750853; x=1746355653;
h=user-agent:in-reply-to:content-disposition:mime-version:references
:mail-followup-to:message-id:subject:cc:to:from:date
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=HNsRJx7etyHIPrvzGbuUUG77VLySCbxt0WbkufcLfmA=;
b=XeiJgNkLPgJ6xOadkwryTzHD/RmF1urVQ51+gwZJZEcCh3AyVbvZKDSTJHZUV7Ovm4
+2sqgQZ7/ql3OYZLgIF5Y1I7zsTTueLAWPsZ2IxqSiPN5y+u9hQW4TMn9aYSGqPnPdgl
bFmQXMObdyW3y5MrLoflgKjLW8chzjKF2gXslNiOkCRCNim3DTnUBgwxQ/DtjT0JblYQ
P5EcZ5wJdkoZS9URKlpM8VY60SRV05tMgx9ltCrPUoreXofs03TRwTQxH9v7yACat748
FIfJiZFsmWR3Z6ydrOhdnEDlA/JcDijCLKMOXnSu+TNMs+QPwQ0rqI/LD6aKwVPhhZVb
j0rg==
X-Gm-Message-State: AOJu0Ywo8j5ANAM0bHbRvhB5DG5q4g+VgcBcB3+TgUyg5gn7Hjqrn+zS
aOsTYWSjN9jSNmLgMHlK2TBfjlP0Psnct+1pE55jwZmsIbLalBODQr3fhA==
X-Gm-Gg: ASbGnct+vNOmFb3Vmh9Fw6tgOKCvzTMH6BKvOWYBxNdaYD8lY0YEhT9oYEZh5ND1Czj
adWsdcmRrKIL5C+/GM2aOasPJduf9Bz3BS5pzcmO02rV59rBv9F06D/Gh5cZU+U0IcAuYirC42e
cTodA0Dkc88dm2YXEO0Jdqubze2r9XFqPKrYmbA293G8ofp2U5IcRBs8bF+VigxUbgzS6WcKgvq
3lqcBUVoCN6968Di/jYlI7weokageVWzR6RsIsA1JODGmFlZI4Q60Z7Hr9TX3mXQIYuCEG3jeNZ
q/LY/xZTvfKsUuEwB796mo5k57c05VpMKqrHmjlpEwB+UakK2FISjEAIDxO/ev2qQGUteGidqs7
gmIv24UPjp6NtGo8=
X-Google-Smtp-Source: AGHT+IGMh+gkSAQboA4tR53K7px9rcfKo0JcbDi1tHSqL88GREOHavyKoRpzefgC8PL0TeZ4kl++NA==
X-Received: by 2002:a5d:64a4:0:b0:39a:ca0b:e7c7 with SMTP id
ffacd0b85a97d-3a074f151d7mr5629611f8f.36.1745750853440;
Sun, 27 Apr 2025 03:47:33 -0700 (PDT)
Received: from mariano (dynamic-adsl-84-220-189-10.clienti.tiscali.it.
[84.220.189.10]) by smtp.gmail.com with ESMTPSA id
5b1f17b1804b1-440a5303c08sm88293625e9.13.2025.04.27.03.47.32
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 27 Apr 2025 03:47:32 -0700 (PDT)
Received: by mariano (Postfix, from userid 1000)
id 8EF68BFCE8; Sun, 27 Apr 2025 12:47:31 +0200 (CEST)
Date: Sun, 27 Apr 2025 12:47:31 +0200
From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <aA4LQ1+OYUsGBHVl@mariano>
Mail-Followup-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>,
softworkz <softworkz-at-hotmail.com@ffmpeg.org>
References: <pull.66.v6.ffstaging.FFmpeg.1745457192.ffmpegagent@gmail.com>
<pull.66.v7.ffstaging.FFmpeg.1745623868.ffmpegagent@gmail.com>
<b4bb8cdcc65f646e6f54269ba38ee7ceeb65aa6c.1745623868.git.ffmpegagent@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <b4bb8cdcc65f646e6f54269ba38ee7ceeb65aa6c.1745623868.git.ffmpegagent@gmail.com>
User-Agent: Mutt/2.1.4 (2021-12-11)
Subject: Re: [FFmpeg-devel] [PATCH v7 01/13] fftools/textformat: Formatting
and whitespace changes
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: softworkz <softworkz@hotmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/aA4LQ1+OYUsGBHVl@mariano/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On date Friday 2025-04-25 23:30:56 +0000, softworkz wrote:
> From: softworkz <softworkz@hotmail.com>
> @@ -484,15 +481,14 @@ void avtext_print_time(AVTextFormatContext *tctx, const char *key,
>
> void avtext_print_ts(AVTextFormatContext *tctx, const char *key, int64_t ts, int is_duration)
> {
> - if ((!is_duration && ts == AV_NOPTS_VALUE) || (is_duration && ts == 0)) {
> + if ((!is_duration && ts == AV_NOPTS_VALUE) || (is_duration && ts == 0))
> avtext_print_string(tctx, key, "N/A", AV_TEXTFORMAT_PRINT_STRING_OPTIONAL);
> - } else {
> + else
> avtext_print_integer(tctx, key, ts);
> - }
> }
>
> void avtext_print_data(AVTextFormatContext *tctx, const char *name,
> - const uint8_t *data, int size)
> + const uint8_t *data, int size)
> {
> AVBPrint bp;
> int offset = 0, l, i;
> @@ -520,12 +516,13 @@ void avtext_print_data(AVTextFormatContext *tctx, const char *name,
> }
>
> void avtext_print_data_hash(AVTextFormatContext *tctx, const char *name,
> - const uint8_t *data, int size)
> + const uint8_t *data, int size)
> {
> char *p, buf[AV_HASH_MAX_SIZE * 2 + 64] = { 0 };
>
> if (!tctx->hash)
> return;
> +
> av_hash_init(tctx->hash);
> av_hash_update(tctx->hash, data, size);
> snprintf(buf, sizeof(buf), "%s:", av_hash_get_name(tctx->hash));
> @@ -551,7 +548,7 @@ void avtext_print_integers(AVTextFormatContext *tctx, const char *name,
> else if (bytes == 2) av_bprintf(&bp, format, AV_RN16(data));
> else if (bytes == 4) av_bprintf(&bp, format, AV_RN32(data));
> data += bytes;
> - size --;
> + size--;
> }
> av_bprintf(&bp, "\n");
> offset += offset_add;
> @@ -641,7 +638,8 @@ fail:
> return ret;
> }
>
> -static const AVTextFormatter *registered_formatters[7+1];
> +static const AVTextFormatter *registered_formatters[10 + 1];
Unrelated change, I'm not against it but should be put in a different
change.
Should be good otherwise.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".