Re: [FFmpeg-devel] [PATCH v7 01/13] fftools/textformat: Formatting and whitespace changes

[Stefano Sabatini <stefasab@gmail.com>]

On date Friday 2025-04-25 23:30:56 +0000, softworkz wrote:
> From: softworkz <softworkz@hotmail.com>
> @@ -484,15 +481,14 @@ void avtext_print_time(AVTextFormatContext *tctx, const char *key,
>  
>  void avtext_print_ts(AVTextFormatContext *tctx, const char *key, int64_t ts, int is_duration)
>  {
> -    if ((!is_duration && ts == AV_NOPTS_VALUE) || (is_duration && ts == 0)) {
> +    if ((!is_duration && ts == AV_NOPTS_VALUE) || (is_duration && ts == 0))
>          avtext_print_string(tctx, key, "N/A", AV_TEXTFORMAT_PRINT_STRING_OPTIONAL);
> -    } else {
> +    else
>          avtext_print_integer(tctx, key, ts);
> -    }
>  }
>  
>  void avtext_print_data(AVTextFormatContext *tctx, const char *name,
> -                              const uint8_t *data, int size)
> +                       const uint8_t *data, int size)
>  {
>      AVBPrint bp;
>      int offset = 0, l, i;
> @@ -520,12 +516,13 @@ void avtext_print_data(AVTextFormatContext *tctx, const char *name,
>  }
>  
>  void avtext_print_data_hash(AVTextFormatContext *tctx, const char *name,
> -                                   const uint8_t *data, int size)
> +                            const uint8_t *data, int size)
>  {
>      char *p, buf[AV_HASH_MAX_SIZE * 2 + 64] = { 0 };
>  
>      if (!tctx->hash)
>          return;
> +
>      av_hash_init(tctx->hash);
>      av_hash_update(tctx->hash, data, size);
>      snprintf(buf, sizeof(buf), "%s:", av_hash_get_name(tctx->hash));
> @@ -551,7 +548,7 @@ void avtext_print_integers(AVTextFormatContext *tctx, const char *name,
>              else if (bytes == 2) av_bprintf(&bp, format, AV_RN16(data));
>              else if (bytes == 4) av_bprintf(&bp, format, AV_RN32(data));
>              data += bytes;
> -            size --;
> +            size--;
>          }
>          av_bprintf(&bp, "\n");
>          offset += offset_add;
> @@ -641,7 +638,8 @@ fail:
>      return ret;
>  }
>  

> -static const AVTextFormatter *registered_formatters[7+1];
> +static const AVTextFormatter *registered_formatters[10 + 1];

Unrelated change, I'm not against it but should be put in a different
change.

Should be good otherwise.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".