From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3BC4942909 for ; Sat, 7 May 2022 05:24:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9DD9768B31C; Sat, 7 May 2022 08:24:47 +0300 (EEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3296B68B2B6 for ; Sat, 7 May 2022 08:24:41 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651901086; x=1683437086; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=MVxCrMfWFVazJ5vRhxmiV9JTuuuB7KmBTFbnOmlvU6A=; b=Ihx2QY3ZQOfTX+xRtKdp4GiM8zK1TecX8yrC8KgNcUqeRNEGw1CCvSgw d1UQYAdgf6y41ee8vVRgnVIEWx0zawDJxfKpX9SBAyWBzEBjkCtz/iZUE tpqt9dHEK79Sm+0UwM+Gx9KEWrjgvNEMvYBaFc8G9IS6Xv2iSKgUNLY5+ 6jDCDAVM3vCoUF7GqS/Ykn863LP9u8REE+Ya/rBWgjFzQkpoWP+kdav7p YmNAJ3zlBbmhru3L3//EGZOGacdPvIDTPs7ajhQMt7X5F0ZkEy6j73SF3 dNhnIAiv+1W5XoRnWqkgruLxYWtKVMEce/DYPkPcc8b8GCs3XchFls/DL Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10339"; a="267494397" X-IronPort-AV: E=Sophos;i="5.91,206,1647327600"; d="scan'208";a="267494397" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2022 22:24:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,206,1647327600"; d="scan'208";a="622137582" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga008.fm.intel.com with ESMTP; 06 May 2022 22:24:39 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 6 May 2022 22:24:38 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 6 May 2022 22:24:38 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 6 May 2022 22:24:38 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 6 May 2022 22:24:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NXo0cgsLz27WMRkCeD578uY6mqO1G122GviRkUfJ3pqqX7f0uNS1zrrMEjprT3JQGKxM21L4zaGiH/OQ1C1HqtKL1VPBmHgqcNsyE/Z1IZwA71cj/agwyhvoQrYfmjsVG57faxPY1u8OX1aBJQSZylhH3gLSruJULotxqrqttWmShTUAnFvZKmLsqjooVqP6P6psMdhUHWJWNmg4J1L96tbDXKKfPWlrOX+OikM3t0DW9cv1Rxr8fdqIQnQ5T/jVqxNcHc88vlTjp/rWHOwCKebKVhIpzsXU/+CfBuB58z5OGd8TVWOvolTAPXzxJbC42j/KaNelgoZBnbann4Zayw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MVxCrMfWFVazJ5vRhxmiV9JTuuuB7KmBTFbnOmlvU6A=; b=Z2xT6lTxxi3ouanmQGJtlldtQ1HRSPuTvjyg34H8XM4CXKh/wUgnMIP3XOJb6/Q0uFVDXf97tgaqm0qIW61ZjTBVuaZMdi4Kymhdo6yhgJXhY48LcuJNFWYOz9xlHjH0Dgk2IH3SAow/SUpuVp6YF2x1vsfXSKnOKzRTffIInpQo7/KwRxeM8pmwUPEmi4I9ReBNtrjiw9EycU9N6/Sh1hB3NtTszg+j0+2SQomsN9ozIZ9cmly+lE0k4pHj3xTKcEjqMkXXnh1UHnvAdkLMV8W0EEz5KwBb7FwAy1Rx5knmm2vEDTgMjKakUfEosCmmI5eI1zlNTawTeO8PEyaPvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by SN6PR11MB2960.namprd11.prod.outlook.com (2603:10b6:805:d4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Sat, 7 May 2022 05:24:31 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::2d06:ec38:937a:da73]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::2d06:ec38:937a:da73%6]) with mapi id 15.20.5206.027; Sat, 7 May 2022 05:24:31 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v4 1/3] avutil/hwcontext_qsv: derive QSV frames to D3D11VA frames Thread-Index: AQHYYQ6tQdmwbdePaUS7X1+mtxtn5q0StF6AgAABmoCAAC1dgA== Date: Sat, 7 May 2022 05:24:31 +0000 Message-ID: References: <20220506055711.1671-1-tong1.wu@intel.com> <50b7bc55e01eff10e06a9b5d18a5e96227b2c579.camel@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: baf2c3c8-0963-48ed-47a8-08da2fe9dd6b x-ms-traffictypediagnostic: SN6PR11MB2960:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BOkbTT3/Ey4M5ZN1UJz8D7pTYUxgsEiFewOIemEPPOF2XCa/ZfRNiPuGYm/xGgm3ZvZCAgi6Q+LSy9tyoRUbOsjmzxlgQ0lr4LAsiUBMr5uolEfkkpFWIq56dEAb3sah45IZKTEXfaknxpEId/2QvTEQQe3n7q/wmW0Udu397q6UpEkg1LhDU1RS6B2rnfzVrCwsVwDly4ggmct1mV90xwlTaCi/QwHbO6jOHV24bV4s24FoxaCYtg52okX4/x2mCMLQntRrEjPIF4pLh/UVA4jSx0JWF3zzlJGADGsxQ8GG1/kvPjRdOYWwlg/PryEV8Ris/dDz/z1VmNJCIh4xg8bteOsaZEjz8oluR1lj+ctdFus4yFQ218DmDZJrNtUzqJNxq5XKkmWGeuF5XS9oRjRxW2Ad1N+JIhFR8uR1F18WjCQC+EAfahy5SeGszRR2p3UttGAeapE+o5jDpvoXjbK7SGEklKfxKI9xietaie0qmqtrAaZ/GoOos6d07kkg1IJ9NwXh5lFDuR7r2gssEFSRBqYvCa2l0Hu7WJgjIlHK2Amo9xwYdxAOR9VV+GTsb45/hJQdSxLckEObl1pTTuUIqwppYMRlfW6svT7dQqGPGIealO+U4jWnVAv6Kr64rOCyWoG5NukjQmbzvVxUduuVDKiwWiyRymoIsjR5usxFJDLlizvzzYlOL5QYvQWDolT4dNyIq8jxENb+8MvKaNtJzx0Es2UiRdNfcMOX464ZL1GUs2zWY0M92tJdYsXmniZXcP+vFG9RwB8E1RzXHA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(76116006)(6512007)(91956017)(38100700002)(36756003)(66946007)(86362001)(66556008)(53546011)(8676002)(64756008)(4326008)(66446008)(66476007)(186003)(71200400001)(6506007)(26005)(2906002)(82960400001)(6486002)(122000001)(508600001)(5660300002)(83380400001)(316002)(8936002)(38070700005)(6916009)(2616005)(107886003)(99106002)(460985005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L2RIbzdJeUFQNlJTYUp5N2xhemhibWNudlZMRHBQUThaZkU1UXZDSjRQU1Vw?= =?utf-8?B?aVZ3WjNzQWNIQ29FK1VJLzJ5elZrUXFNc0l4TEkyYk9ta09xUGVWSStyWjlz?= =?utf-8?B?WjZQYjhtbmVoR0ZaUEdXYUdvcWhUMzdnUE0vaUloYmFwR3VoWDVlWnRIWmpl?= =?utf-8?B?NTE0RVVveDFNRnFEOS9FaTc2dFVnQ0c1b0ZERjBud1ZTWTMrcElFVVN0Njh0?= =?utf-8?B?ZW9kNlBYblI0KzV1YTFOQTVjcDZQVUZDNlhnODZjeUhuTElSYzVHc1FyTUxT?= =?utf-8?B?RFFleGw1Rk83N2wzZ1BhQ2k1QjIxYnhBR3RsUHY1S2VFeHJIV3hsdklGYTFR?= =?utf-8?B?dDhKQU5PU1d5U1BkNU4xdVZ0K01JaEs1L3Q4c25idUZ2VVpjeWpRZmtGbHVC?= =?utf-8?B?ZzZiblhVN1B6cG1HTGU2VTJ2RTZaUUhQd0hkNERaVFlnMVJqL3cxUDcyL0Rn?= =?utf-8?B?VFB2KzNWL1BOb1pBUkh0WUlTVkpHa3dhNW84K1d2My8zTmdiSUxVWmhGSnNO?= =?utf-8?B?VERRYVRYTjUzZEVlQmtmWmkwMllibzV1M2VoeFlDL0lKMUo5NXA2Wi9mcWdh?= =?utf-8?B?aVBhME9EcHBJOS9qa3ZoeVo0SGpPNW1HcXJDZTBINnVLMThtRkNHK25MaXRy?= =?utf-8?B?UkxHZGNvRlBxaFVoQ3BaNUUxR2p2MlNPUmhhVUdYODVRUEFrMEtIeHVhN2wz?= =?utf-8?B?TjZ1NWlydjB0MVBrRWlrUVlUQkxyQ1l3VEUzZ3F2OUNQTHdTTlN2RjV3MVdD?= =?utf-8?B?RU1ONjh3Zk1YNHFtOUphemxiSHdHNU9VUTc0S1VFdVJ3eWpFcUM2Y0ZmQUxa?= =?utf-8?B?R3ZjTmttbytId2tsKzlMa3p3cUY1dVdKVmpvdmZ2enJyclRCU0FFUEYyZWtq?= =?utf-8?B?c21NWnVqNUFDYWhiL29RYjI4Y3pTUVp0cXZIQjFkN1Rpa0RkU2QrTyszUi8x?= =?utf-8?B?MTN2Y05SMGxRWGlQRmlXUVY3TCs2TGVhQ3l0emtIMVJSdWhOajM2Vnk0K3A1?= =?utf-8?B?MjZRWEdCeDZVcW9pQjlyRmpBYUZsTGFuWkVGUjJyN0JZZXhvS2hkM0xhQ0Jj?= =?utf-8?B?Y2pHZjJzYlVKMGFGVllOTFAzQTJhZ3RmUU5jTndzZXF6RktEZWFzV2lSb0RL?= =?utf-8?B?OFgwMElyNWZmUFdLNDkvWDQycFpyTDE2T3pNUWN6WjJ2MVYrMWNyRHFlSEsy?= =?utf-8?B?eHplUmJMQXZWSG9UNXcxbWpGUnA3ZXFKNjJBWmpveHFSK2Jra2pGWXNrMWVW?= =?utf-8?B?WnlybERlaElWNDNXTjllR2ZFZzNna29VTGQ2Snl3ZEFkeE8zZHcxZHVzS3Bx?= =?utf-8?B?bGY0VFEvdVRzeWoxSGdmajJKc3BOb1ZhMkRPNDVqNFYzTllLM0UrTlBLZUpo?= =?utf-8?B?SkFJRWRIT2RPUWloODd6WlJUbUF0dStMVytpNmlicHQwSTRvVm9RanM3cTl3?= =?utf-8?B?bDJLc3FTUlVtUUd3ZHp6T1dIS0lrVndHOG5hK2VUOElSY3ZkVWZPNlNPNTE3?= =?utf-8?B?UlpaVnpwaGpUTEIxd0tXSUMxSCtUc2V2ajdBcGdlTm9NVzlJL2lReXNvVW1H?= =?utf-8?B?U2QwdnRmTG8vZ1JEL1d4MTlORGwxNWRxaWFYZVVENjBjNnhxN2t4cUZnaXcy?= =?utf-8?B?UlNZbjdsdENDOHQ5UEdnRGJ3aU9Ra3hYaG1GSEl6a2ttZStkcUFaOENzelVw?= =?utf-8?B?OXdGT3dtYXNNbE9uMHY5cXRJcWxiWFIzZUVtbEVWaHVxZk1xK3puT0FQWHFi?= =?utf-8?B?bExmb3JpUmNrMkphODAxUWFCVjF4T2Rua3VZWkQ3UWlmeHhWdVdSTUh6Rno1?= =?utf-8?B?VWV5VFNXMlM5VmZKbXg4TndkSDVUZ09UZW9NclFVcWlkdTFFR0RNbWFhNlJq?= =?utf-8?B?bFFRTnlzdGM1Z2JqbFZ3QWFobm9VRjM0cEhlNVVrajBNTHpqYXNpZmZXd2FR?= =?utf-8?B?bWtKQy9lQzE5bGxTWnRmTFVaMktyS3hZQTA5YktOYlloTjd0R056QWtUb1Va?= =?utf-8?B?WVpuVDRzblg5YjNoaU1keUUrY3FHelNWWGI4RFA0Ync1WmU1MU4rUkRiVDU1?= =?utf-8?B?ZTV2M2dYN3JoYWErdm0yNkpqZWF4RGg2YXFPekxYcVVNUzk1OTR5bWt2TXRq?= =?utf-8?B?eEg2UDJNWnBhcFdYcUpYU1Fsc21SYzlkcUg5cUUxeEgzNE4vOWkzYlFTVWFj?= =?utf-8?B?OHFBUXFWV3FDaDdYbzVvbG9LR1pNd1VaMWlRR3BHK05QM2hnejIrZWgxZXJy?= =?utf-8?B?V0FIRlArQy9xREoyamdMVUNsQW4xK3U4anNLVGJkVk8xT3VEKzFYYnBBTmxs?= =?utf-8?B?TzJxdXpqVXNyRHBSSE15SEtaR3VrRnRVZ2NaRTlBd3BUY21hVFpxSlVZdVVE?= =?utf-8?Q?LdYaEfuuoIWb0fjA=3D?= Content-ID: <6AEE48B6CEC1B54EBE38BFE298CDB4A2@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: baf2c3c8-0963-48ed-47a8-08da2fe9dd6b X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2022 05:24:31.4871 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VPV+QGuw35T+ko0E28kvJ7rc8SvFROrTI81kHd1KuP/tB44iJU6euLwZSLArAF9z3DMkRvMhIq1G6s/W3y8QwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2960 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v4 1/3] avutil/hwcontext_qsv: derive QSV frames to D3D11VA frames X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Wu, Tong1" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 2022-05-07 at 02:42 +0000, Soft Works wrote: > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > > Xiang, Haihao > > Sent: Saturday, May 7, 2022 4:36 AM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Wu, Tong1 > > Subject: Re: [FFmpeg-devel] [PATCH v4 1/3] avutil/hwcontext_qsv: > > derive QSV frames to D3D11VA frames > > > > On Fri, 2022-05-06 at 05:57 +0000, Tong Wu wrote: > > > Fixes: > > > $ ffmpeg.exe -y -hwaccel qsv -init_hw_device d3d11va=d3d11 \ > > > -init_hw_device qsv=qsv@d3d11 -c:v h264_qsv -i input.h264 \ > > > -vf "hwmap=derive_device=d3d11va,format=d3d11" -f null - > > > > > > Signed-off-by: Tong Wu > > > --- > > > libavutil/hwcontext_qsv.c | 16 +++++++++++++--- > > > 1 file changed, 13 insertions(+), 3 deletions(-) > > > > > > diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c > > > index b28dcffe2a..bf150c8553 100644 > > > --- a/libavutil/hwcontext_qsv.c > > > +++ b/libavutil/hwcontext_qsv.c > > > @@ -1281,12 +1281,22 @@ static int > > > > qsv_frames_derive_from(AVHWFramesContext > > > *dst_ctx, > > > #if CONFIG_D3D11VA > > > case AV_HWDEVICE_TYPE_D3D11VA: > > > { > > > + D3D11_TEXTURE2D_DESC texDesc; > > > + dst_ctx->initial_pool_size = src_ctx- > > > initial_pool_size; > > > AVD3D11VAFramesContext *dst_hwctx = dst_ctx->hwctx; > > > - mfxHDLPair *pair = (mfxHDLPair*)src_hwctx- > > > > surfaces[i].Data.MemId; > > > > > > - dst_hwctx->texture = (ID3D11Texture2D*)pair->first; > > > + dst_hwctx->texture_infos = av_calloc(src_hwctx- > > > nb_surfaces, > > > + sizeof(*dst_hwctx- > > > > texture_infos)); > > > > Please check whether the pointer is NULL > > > > > if (src_hwctx->frame_type & > > > > MFX_MEMTYPE_SHARED_RESOURCE) > > > dst_hwctx->MiscFlags = D3D11_RESOURCE_MISC_SHARED; > > > - dst_hwctx->BindFlags = > > > > qsv_get_d3d11va_bind_flags(src_hwctx- > > > > frame_type); > > > > > > + for (i = 0; i < src_hwctx->nb_surfaces; i++) { > > > + mfxHDLPair *pair = (mfxHDLPair*)src_hwctx- > > > > surfaces[i].Data.MemId; > > > > > > + dst_hwctx->texture_infos[i].texture = > > > > (ID3D11Texture2D*)pair- > > > > first; > > > > > > + dst_hwctx->texture_infos[i].index = pair->second == > > > (mfxMemId)MFX_INFINITE ? (intptr_t)0 : (intptr_t)pair->second; > > > + if (i == 0) { > > > + ID3D11Texture2D_GetDesc(dst_hwctx- > > > > texture_infos[i].texture, &texDesc); > > > > > > + } > > > > Move this out of the for-loop ? You may call ID3D11Texture2D_GetDesc() > > below: > > > > ID3D11Texture2D_GetDesc(dst_hwctx->texture_infos[0].texture, > > &texDesc); > > This could crash when src_hwctx->nb_surfaces is 0 src_hwctx->nb_surface should be greater than 0, see qsv_init_pool() and qsv_frames_derive_to(). On the other hand, dst_hwctx->texture_infos is NULL if src_hwctx->nb_surfaces is 0. I commented that we should check whether the pointer is NULL. In addition, texDesc.BindFlags would be uninitialized if src_hwctx->nb_surfaces is 0, so we couldn't use it in the following assignment. dst_hwctx->BindFlags = texDesc.BindFlags; Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".