From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 74CA8402A4 for ; Fri, 21 Jan 2022 01:08:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B62E868B1ED; Fri, 21 Jan 2022 03:08:27 +0200 (EET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5556368B199 for ; Fri, 21 Jan 2022 03:08:21 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642727306; x=1674263306; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=QI3unXCkX+/U6WxEpGeEtt7WZWshtz87i24z1wh7XYM=; b=WlOr3MgbfVqQ0GcBvtiXr4V5/n85IsMAzBkARmSs9IuEpwG8uMtySr2J 0beoqNbDKJ4wLRqn3V/fN2O3ZqZaDVLQ+thRskAuzcqEf/M3KOG+bDDWT FDzQh57G/oKsZailFEVY9O+r4iYVcfbkA+O/t+qiJJiiBWwZaht0ssILE 7if/yVPnaafst5J2QjB80skV4CFEniZwWbppFokXYj6iHoR7Zm2ndzrzF 7aKTUdJ3hbuWGkjJ3jbNSUbItKSXrJiBwB2YP5TvuljihyCcNXmR9d7VS Rgg088p8skoQ2pgbOtgjl+D4AJTddyHSzvai5PqreyJ4XKt+CGEotcSfz w==; X-IronPort-AV: E=McAfee;i="6200,9189,10233"; a="225511153" X-IronPort-AV: E=Sophos;i="5.88,303,1635231600"; d="scan'208";a="225511153" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2022 17:08:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,303,1635231600"; d="scan'208";a="672770762" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 20 Jan 2022 17:08:17 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 20 Jan 2022 17:08:17 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 20 Jan 2022 17:08:17 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 20 Jan 2022 17:08:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KxcsLlyrs72nC9MSPvdQyLi5nOH7k/N3P503WqlX68seBFYFaXDTgoLa6H0Mv/6BQJl5LsRW2udgQzDOUwe6fXi1SE0fS7L4uwXVRYupicyWDE72xrPAnrHnHweCzKg3rdNvErg8qOCNi4jn3btzfoP0aba6c0Pf5UwO2hITARZioPgcD8+kZVvImj41jLwtyfcJEqVQBeyVvkwDg8fThnX1andL3C6tSAZFrZvJWFzgrJDeXHNza9DKYEjr6hYTxm7M8FjCdwnKOflX5tsFbepZc1rXh1aR/aSwH1iXhLs2BfIj2WpzVBV53Cj86gY9dxi1aUgBmNe0snqEw45EaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QI3unXCkX+/U6WxEpGeEtt7WZWshtz87i24z1wh7XYM=; b=RyrM53Felk4LiBNE2VWEXgtrv83z/19pnQ9bFizyRxQBYpGnzxJEjOZnuWgw9cyz6nLYHv4OZt5BoBLccirzeJkMIxoZkZ/fbxvAQI/l34EAxKsXBi2owScVNbJn7WUB4HOClD+lNYfXB2wqNCjfyIWuCDxEbkuFixOjiW9oXPD132tiY+AYgfMsJrEWj9IJ0YmOYFiyCZ8NXWStW4+vfWhgpMB6CGmuINxPiYtnBoreHBBDUGghtCwDaXsOp11EMlWhmKc9DIC1PlpNJEJqNIdFX2zuZFkLR6VbvvM7qrhZBEMMaeNExyMFSl9klZgqDmfoTyTlIfHPjzra54DsGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by SN6PR11MB3024.namprd11.prod.outlook.com (2603:10b6:805:d9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.12; Fri, 21 Jan 2022 01:08:15 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843%5]) with mapi id 15.20.4888.014; Fri, 21 Jan 2022 01:08:15 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix a memory leak problem Thread-Index: AQHYDc2M+2yqBXWGNk+BKxDGQYLZmqxsqx8A Date: Fri, 21 Jan 2022 01:08:15 +0000 Message-ID: References: <20220120071343.187817-1-wenbin.chen@intel.com> In-Reply-To: <20220120071343.187817-1-wenbin.chen@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c5887251-3c53-4003-5ad7-08d9dc7a80c7 x-ms-traffictypediagnostic: SN6PR11MB3024:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GdgI3/3WSZCLi3iamw0WLFk8MKqRKhB88QJ04OHA7xZ6bhpBbKQowbO3S/g8myw5h4Y6SUYyzvMyUsd8yzima/uusIvc79eP8fIXPNhr+maCGQFaeO/Cl8EWUCVX+IjnqeliLHFNHK/9b93PDaMUvXf0YxgVScpLF1HC3FiAYnU5LGG9c9J3F4VhiI606z2nRdFcXrw4V0WHEc64MzTjv54DCTSYuVfMfypw8TnYSe65IACzc2yHOBqQs8Qyrv0MC6KzFgQ5PUy2EPsYu43X1Y/L38GquRgPwA2EvLboYXIXbhkD5Z8owrgJ/PMLjjea9YV0LjS3amqJedcJMjlQInYHBAG2gpZzj9jB7HyF0FxUzedVj/f94EjI2eVv88WEG0WrkmABDzrOzyVtYPPPG6WkR7TW/NTg+yR9rkJch8xmFuDByPQifxXi3I/dDRuzM2FAkIvhajy5SOs7enj5pbczLCT6r1jmouRuoIAi/Y3D/Lzb7eOouoK+pB+2acZjTb+rOXq7/Fa91Q09T6ELmXuoS/Ke3y50XsbnA4cuZLlSC6OKxtC8u0OUidPOhaez2+He/j74caqs/qIx1sPVBhv9DEV6nduYxxTwqfKvxTRMNPBUgtJjzCdWXbmRPQIUPcqPPmsWgif8lMXj83pBkzhdC3GwXEX/uNi4SiaXptpAhcWG40Dr80hB5DsKasK9WDM+ZrFHFS1fYd8lQzMuetQU7NIaGBYE9LA3D7UXwso= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(26005)(8936002)(91956017)(2906002)(8676002)(66446008)(6512007)(76116006)(36756003)(82960400001)(6506007)(122000001)(66476007)(86362001)(64756008)(66946007)(71200400001)(316002)(66556008)(5660300002)(38070700005)(2616005)(4744005)(6486002)(6916009)(38100700002)(508600001)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Y05SdHJSNStyRGg1RGNrc3RmbEFvemRFait6MWJLa0lFVzlJcHFRQ21aQ3FK?= =?utf-8?B?ZGtpUzdVZ2lrN21uclFrZ1VoUEQ0MVZwNVZTNnV2NXp4Y2psVk9POEwvNC9s?= =?utf-8?B?eFJLNkM4dnZldHZBMnNDM0Vrckk2NXBkZmZsYnZiMHQ4dmdockJyNFh3MXZo?= =?utf-8?B?aW9CY2U4VUVNcm9mZ1E2S05Yc2cwV2UwMUF3MGNDdVR3NXpYMlptVEJUa2VE?= =?utf-8?B?YnRLQTJaZHI3L1Byb3ZPRHBaUmxxVnZQT21aNk93bW8xZTlqem1xZmVtU0ti?= =?utf-8?B?TEFzNHA4RGNhWHZpWjJEdFhJTWN5LzgrdEVtQnhTd1FXVVlBVDlraFNINmJx?= =?utf-8?B?TVZKVE5xOGw1ZHMramdpZ2V5L0pOUy9WZ1pJSXNUMUVYUEpTVGFVMTE4dDdw?= =?utf-8?B?N2liUGZrMHJjUXVKQ1FlTkVEdUFnaGJoWVVrZlY4MzR1SHdJdWFGeisyL0NL?= =?utf-8?B?Z1JSQXlNbmhhSTJFQ2I0Uy9tSXhPUXFOb0FMa1V4ckxySHEveXNMbDNYSVVF?= =?utf-8?B?QndHTEt4aS9sdkcwMEdhVnRMRjY0VUcrQWJGUmJtYlQ5enNnc0lOMWJxMlhX?= =?utf-8?B?QXMvS2h3WFZPRlZYSVlrZ0MwajhDUllVVVkvQ0pCdFluR0U4dUZqSTlBYXZC?= =?utf-8?B?NzVTakZRbHBueGljamhzVDhYQ1JLSVlKakhRbXo4MVdZcGErZFBZTlU1VHpK?= =?utf-8?B?Y3pPbzVBUlY3MkdpcWJaK2Noa3A5TkxqMUJFY05ZaUZGckpPandFbWdrUlRs?= =?utf-8?B?MlhoRUYzbFd2SUxsR2E0dXlibzl2NFFhRm5FM3dFSmgyZlFhWE04bk9xd2gy?= =?utf-8?B?b3liTU1mR0IvbFNDSmtQLzAvN3A2Q1MydzdmbGozbUc3QlArMGJpanVGdzcy?= =?utf-8?B?aFg3T3ZCbU5ESTVrVGNOMDBNcnE5WlRaSmIxL25tdmhJSVFXcFpZQjNSNDRp?= =?utf-8?B?Qlp6K3RMTWVKNkE1Y3Q0NEFvVDJRL3c5aDBibUsxaHk2VFVycFpmeTBRRUJv?= =?utf-8?B?OXVKSlVBM29MLzZuMTZVZkY5bmREUG4wUWk0RjY0SC9MWjFkRm9wVHpkK0JF?= =?utf-8?B?c3l0TWltRjFjakRPTEZ0eUZuVWM1NkxURGM3T2M2MnNLTy82dmdjVzVOYkZ0?= =?utf-8?B?RmVGSzV0UHlEV1ZIYUV1WS9RZS83V3Y2WHJuMGZZWVlQS3FIam85ekFSOUtM?= =?utf-8?B?ekdGSVFEVUxZaVVWcXV2aXF4eWJERjdaMC84Vy9ZNlVpSGpiWGVQeis1YmdC?= =?utf-8?B?ek1aeWJGV3lpQUZtMlVSTlZZdUNxSU83a2FGdHdMYTJsU3J6RGpZaEpWVW5K?= =?utf-8?B?MURQQTBFWFFyWkxoVTFLS3J5RW1aQitGTmtJRVN6RXUzNzl4MkhoS3kyMWZ2?= =?utf-8?B?K0hKTnY0MUFybDRtOXR1Uk1OeTR4TGJkRDdTMGY5c0lsWXFITmJ1Q3NKMCti?= =?utf-8?B?WVpzTFEzUW9LNUk1MU9LRUcwOUh1SnpGM1JqOVNoZVhOQkF0OEZDL2xLeUM3?= =?utf-8?B?SmFkYXk0VmpFTkx4dWEzRWNVMS9ibjdOaWU5Y2tSeG9ObTZ3SWVQNjAvWTho?= =?utf-8?B?SEk5YUt3TkNiWWJEWG5aM1FnQzZYRVo4WFgvNDZkelBacTVLd2VKc1kzZ0Ro?= =?utf-8?B?WHY5S1JJNFova3hCWkZxNHVub21OaENCQSs0N241TGJwbEVjcktyM2JINTk0?= =?utf-8?B?bWJ6ZUV2MjJVMk9SRHdFWGFLd1NhZndXdFdObTYrdEFLSWNHdEhIQ2R5UWw4?= =?utf-8?B?djVlRHNkYWFyQXlvdnJVSmladTJGZW1obVFNWU1nZFZuMGNBMHpySWFiaFBL?= =?utf-8?B?YktLdVNqUVZJcWZlQndsUEhFNk01RjVxanV1ZGtlZy9FZWhlVExaTmNCb2tq?= =?utf-8?B?N0xEbGJOVk8yNTgwREV0Y2lodUNqajN2SlBnVjNINldOM3I3RlI5Sitma0R5?= =?utf-8?B?eHlORVgyLzI1VEVpajZtYUNqbVp1d04vcnM4UzVzb0VydzFDaGl0VnM5dS9h?= =?utf-8?B?NEVDM1RGeEdkR1NvTThvQWdxUWxYSmdvOXRaME9GcXBYdzF3emtET1pFem1m?= =?utf-8?B?c0htUFA3N0xDVFBVR0VoTDRPZ1hTdUdtQmlObHpGMzZKY05sQTUydlJPQmdJ?= =?utf-8?B?NTVVQ0JDMnpUNEo4MnV1bmdwQ2xHdnhESGpmdHE2UHIxei9vQ0JFVnM2U1Yv?= =?utf-8?Q?ML2zuUShc/V+AER4DOQE1k8=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5887251-3c53-4003-5ad7-08d9dc7a80c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2022 01:08:15.3211 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: glozeauBnEhyMqDHkZYuCJT5Zwn0ukYuylKgAnxMte5z9MShpjaq1zrEbSWh/faWVcyG2WDcvaRB+p5yUzfLGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3024 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix a memory leak problem X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 2022-01-20 at 15:13 +0800, Wenbin Chen wrote: > "qf->frame" ref to input frame but it isn't released. av_frame_unref() > is added before refering qf->frame to new frame to make sure the previous > reference is released. > > Signed-off-by: Wenbin Chen > --- > libavcodec/qsvenc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index 269386624d..fd5c460d68 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -1521,6 +1521,7 @@ static int submit_frame(QSVEncContext *q, const AVFrame > *frame, > return ret; > } > } else { > + av_frame_unref(qf->frame); > ret = av_frame_ref(qf->frame, frame); > if (ret < 0) > return ret; LGTM, will apply -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".