From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7F2F141126 for ; Fri, 15 Apr 2022 19:38:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 884DF68B4EA; Fri, 15 Apr 2022 22:38:39 +0300 (EEST) Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BFD9668B417 for ; Fri, 15 Apr 2022 22:38:32 +0300 (EEST) Received: by mail-qv1-f47.google.com with SMTP id b17so7027698qvf.12 for ; Fri, 15 Apr 2022 12:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=5H3t9VHRJjZXbyjv9WfhLUwapvIhXj0LGYhqsZUJIjI=; b=C1tBGGjruq8W2GtD+GxDhwYrDV0xmRiYaPE/t+UmYngu6cw87udTLBamXTrvLC4HH1 b8ITcco49JuZ3nE/BSQP0MRXvFF8sIxQItUEzg2g4w7edmVlPf1iLrHkXZ7RSY+6CjH5 +r/DginwUkgmQSk4wnjE5KmaDLLBD1WAGIzemLh8G5/tujcjLTiqXNS1sm66NVFuoBlG jLUy3Xbgnky073Ir1A/1ccwugexaIR7rpDgeQHuTvitQjMupy1UogXznxXwxakQNA2Y/ SFh80MN4kwAUANqJgw9ugeguLxDKLyn04uFcPdh7JkzFPCy3CZbLbGe1qd+VjIcaMZuJ qPHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=5H3t9VHRJjZXbyjv9WfhLUwapvIhXj0LGYhqsZUJIjI=; b=CQItrSv+BgvycN0uaqKTMTCqQtFiq483DGLOCMSom7N43JXA9DacjyeiPRlXsBEDz/ yQvoiaZ6SRagFVAakQ0qTHuEDtOgj5Wb2A+bqPXbfpdHaqQkMxgEn9/4JrtHe0UQ/SFx jQMMw1ww3uUtiVHz6GxWKF3BjOIYB6pfYda57t4T5FZ0fVNVOCO5kmpLXsRMzKtEytGf UJwXq2HjliUU5XA6M/yfgSWoROeiJRGnuhmMFbCAgeFxJKoaIhDAST/aCFjWATBxEWwe 9YC+ZS5rK2yqrbAlCgDfXLiG4nT48BTZtojhfw9YH8ucbRdMUbIlEJHgh2jP86lKBh/O zfQg== X-Gm-Message-State: AOAM530LB/QyQrucrBzpw3Wv6lISPUK+QaD34lvbScFMbWZSozaF055a eSymMIZ2qJUUkjpZziVTM7WK/99HW6U= X-Google-Smtp-Source: ABdhPJx0KD0wGICnXEHutG9vNa3RzQq4VnyWdTThsR4grp8mED7YojGYUfFZx0yoC/sfiplmaubXww== X-Received: by 2002:ad4:5b8f:0:b0:441:248c:2ae0 with SMTP id 15-20020ad45b8f000000b00441248c2ae0mr373161qvp.39.1650051511229; Fri, 15 Apr 2022 12:38:31 -0700 (PDT) Received: from [192.168.1.35] (c-68-41-54-207.hsd1.mi.comcast.net. [68.41.54.207]) by smtp.gmail.com with ESMTPSA id o9-20020ac87c49000000b002f13658d1b3sm3314292qtv.19.2022.04.15.12.38.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Apr 2022 12:38:31 -0700 (PDT) Message-ID: Date: Fri, 15 Apr 2022 15:38:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US-large To: ffmpeg-devel@ffmpeg.org References: <20220412055333.62424-1-leo.izen@gmail.com> <20220412055333.62424-5-leo.izen@gmail.com> From: Leo Izen In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v14 4/4] avformat/image2: add Jpeg XL as image2 format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/15/22 07:34, Andreas Rheinhardt wrote: > Leo Izen: >> +static int jpegxl_probe(const AVProbeData *p) >> +{ >> + const uint8_t *b = p->buf; >> + >> + /* ISOBMFF-based container */ >> + /* 0x4a584c20 == "JXL " */ >> + if (AV_RL64(b) == FF_JPEGXL_CONTAINER_SIGNATURE_LE) >> + return AVPROBE_SCORE_EXTENSION + 1; >> + /* Raw codestreams all start with 0xff0a */ >> + if (AV_RL16(b) != FF_JPEGXL_CODESTREAM_SIGNATURE_LE) >> + return 0; >> + if (ff_jpegxl_verify_codestream_header(p->buf, p->buf_size) >= 0) > This will give a linking failure if the image_jpegxl_pipe_demuxer is > disabled. > I thought of that, and I tested it, and it doesn't. It produces a compiler warning that the static function jpegxl_probe is never called, which means the linker probably throws away the function entirely, thus eliminating a linking error. Though I admit that's a guess. > For the record: I'm not really ok with duplicating this code in lavf and > lavc. > This code was removed from avcodec when I moved it over to avformat, for now, in order to avoid an avpriv in avcodec's ABI. Essentially we have to decide to either duplicate code in the future, or move it to avcodec and add an avpriv to the ABI, but that is a decision that can be made down the road when Lynne finishes her proper parser. I believe this is a better solution now than the other way around since we can later change our minds once there will actually be duplicated code, but an avpriv cannot be removed once added without waiting the necessary ABI change period. - Leo Izen (thebombzen) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".