From: Leo Izen <leo.izen@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/pngdec: avoid erroring with sBIT on indexed-color images
Date: Thu, 18 Jul 2024 08:59:41 -0400
Message-ID: <a94da314-f3b4-4691-b1b5-7e8edf94f0fe@gmail.com> (raw)
In-Reply-To: <499505a9-84f0-ce11-bd65-568b5cd9f654@passwd.hu>
On 7/18/24 4:47 AM, Marton Balint wrote:
>
>
> On Fri, 12 Jul 2024, Leo Izen wrote:
>
>> Indexed color images use three colors for sBIT, but the function
>> ff_png_get_nb_channels returns 1 in this case. We should avoid erroring
>> out on valid files in this scenario.
>
> Please mention that this is a regression since
> 84b454935fae2633a8a5dd075e22393f3e8f932f.
>
>
> LGTM, also please backport this to the affected branches!
>
> Thanks,
> Marton
>
>
Sure, I'll put it in the commit message when I commit it, and I'll
backport it to the branches that also contain that commit.
- Leo Izen (Traneptora)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-07-18 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 19:03 Leo Izen
2024-07-12 19:03 ` [FFmpeg-devel] [PATCH 2/2] avcodec/png: more informative error message for invalid sBIT size Leo Izen
2024-07-12 19:37 ` Paul B Mahol
2024-07-16 2:24 ` Leo Izen
2024-07-18 8:47 ` [FFmpeg-devel] [PATCH 1/2] avcodec/pngdec: avoid erroring with sBIT on indexed-color images Marton Balint
2024-07-18 12:59 ` Leo Izen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a94da314-f3b4-4691-b1b5-7e8edf94f0fe@gmail.com \
--to=leo.izen@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git