* [FFmpeg-devel] [PATCH] libavcodec/qsvenc: Add dynamic setting support of low_delay_brc to av1_qsv
@ 2023-03-02 2:33 wenbin.chen-at-intel.com
2023-03-16 3:57 ` Xiang, Haihao
0 siblings, 1 reply; 2+ messages in thread
From: wenbin.chen-at-intel.com @ 2023-03-02 2:33 UTC (permalink / raw)
To: ffmpeg-devel
From: Wenbin Chen <wenbin.chen@intel.com>
Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
---
doc/encoders.texi | 2 +-
libavcodec/qsvenc.c | 5 ++++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/doc/encoders.texi b/doc/encoders.texi
index b02737b9df..e9b34010ed 100644
--- a/doc/encoders.texi
+++ b/doc/encoders.texi
@@ -3344,7 +3344,7 @@ Supported in h264_qsv.
Change these value to reset qsv codec's max/min qp configuration.
@item @var{low_delay_brc}
-Supported in h264_qsv and hevc_qsv.
+Supported in h264_qsv, hevc_qsv and av1_qsv.
Change this value to reset qsv codec's low_delay_brc configuration.
@item @var{framerate}
diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
index 3607859cb8..c975302b4f 100644
--- a/libavcodec/qsvenc.c
+++ b/libavcodec/qsvenc.c
@@ -1127,6 +1127,7 @@ static int init_video_param(AVCodecContext *avctx, QSVEncContext *q)
} else if (avctx->codec_id == AV_CODEC_ID_AV1) {
if (q->low_delay_brc >= 0)
q->extco3.LowDelayBRC = q->low_delay_brc ? MFX_CODINGOPTION_ON : MFX_CODINGOPTION_OFF;
+ q->old_low_delay_brc = q->low_delay_brc;
}
if (avctx->codec_id == AV_CODEC_ID_HEVC) {
@@ -2213,7 +2214,9 @@ static int update_low_delay_brc(AVCodecContext *avctx, QSVEncContext *q)
{
int updated = 0;
- if (avctx->codec_id != AV_CODEC_ID_H264 && avctx->codec_id != AV_CODEC_ID_HEVC)
+ if (avctx->codec_id != AV_CODEC_ID_H264 &&
+ avctx->codec_id != AV_CODEC_ID_HEVC &&
+ avctx->codec_id != AV_CODEC_ID_AV1)
return 0;
UPDATE_PARAM(q->old_low_delay_brc, q->low_delay_brc);
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: Add dynamic setting support of low_delay_brc to av1_qsv
2023-03-02 2:33 [FFmpeg-devel] [PATCH] libavcodec/qsvenc: Add dynamic setting support of low_delay_brc to av1_qsv wenbin.chen-at-intel.com
@ 2023-03-16 3:57 ` Xiang, Haihao
0 siblings, 0 replies; 2+ messages in thread
From: Xiang, Haihao @ 2023-03-16 3:57 UTC (permalink / raw)
To: ffmpeg-devel
On Do, 2023-03-02 at 10:33 +0800, wenbin.chen-at-intel.com@ffmpeg.org wrote:
> From: Wenbin Chen <wenbin.chen@intel.com>
>
> Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
> ---
> doc/encoders.texi | 2 +-
> libavcodec/qsvenc.c | 5 ++++-
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/doc/encoders.texi b/doc/encoders.texi
> index b02737b9df..e9b34010ed 100644
> --- a/doc/encoders.texi
> +++ b/doc/encoders.texi
> @@ -3344,7 +3344,7 @@ Supported in h264_qsv.
> Change these value to reset qsv codec's max/min qp configuration.
>
> @item @var{low_delay_brc}
> -Supported in h264_qsv and hevc_qsv.
> +Supported in h264_qsv, hevc_qsv and av1_qsv.
> Change this value to reset qsv codec's low_delay_brc configuration.
>
> @item @var{framerate}
> diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
> index 3607859cb8..c975302b4f 100644
> --- a/libavcodec/qsvenc.c
> +++ b/libavcodec/qsvenc.c
> @@ -1127,6 +1127,7 @@ static int init_video_param(AVCodecContext *avctx,
> QSVEncContext *q)
> } else if (avctx->codec_id == AV_CODEC_ID_AV1) {
> if (q->low_delay_brc >= 0)
> q->extco3.LowDelayBRC = q->low_delay_brc ?
> MFX_CODINGOPTION_ON : MFX_CODINGOPTION_OFF;
> + q->old_low_delay_brc = q->low_delay_brc;
> }
>
> if (avctx->codec_id == AV_CODEC_ID_HEVC) {
> @@ -2213,7 +2214,9 @@ static int update_low_delay_brc(AVCodecContext *avctx,
> QSVEncContext *q)
> {
> int updated = 0;
>
> - if (avctx->codec_id != AV_CODEC_ID_H264 && avctx->codec_id !=
> AV_CODEC_ID_HEVC)
> + if (avctx->codec_id != AV_CODEC_ID_H264 &&
> + avctx->codec_id != AV_CODEC_ID_HEVC &&
> + avctx->codec_id != AV_CODEC_ID_AV1)
> return 0;
>
> UPDATE_PARAM(q->old_low_delay_brc, q->low_delay_brc);
LGTM, will apply
Thanks
Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-16 3:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-02 2:33 [FFmpeg-devel] [PATCH] libavcodec/qsvenc: Add dynamic setting support of low_delay_brc to av1_qsv wenbin.chen-at-intel.com
2023-03-16 3:57 ` Xiang, Haihao
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git