From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 9733144D07
	for <ffmpegdev@gitmailbox.com>; Wed, 18 Jan 2023 13:40:51 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1033468B274;
	Wed, 18 Jan 2023 15:40:49 +0200 (EET)
Received: from mail.frobbit.se (mail.frobbit.se [85.30.129.176])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 202E168A2DE
 for <ffmpeg-devel@ffmpeg.org>; Wed, 18 Jan 2023 15:40:41 +0200 (EET)
Received: from [10.10.150.44] (1346516434.ip.84grams.net [134.65.164.34])
 by mail.frobbit.se (Postfix) with ESMTPSA id E82EB200F5
 for <ffmpeg-devel@ffmpeg.org>; Wed, 18 Jan 2023 14:40:40 +0100 (CET)
Message-ID: <a8992de53a0b8d6144a443b26242f760ff4e4526.camel@haerdin.se>
From: Tomas =?ISO-8859-1?Q?H=E4rdin?= <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Date: Wed, 18 Jan 2023 14:40:39 +0100
In-Reply-To: <b7f281fb-2cd9-a85c-1868-0c824b150634@mediaarea.net>
References: <b7f281fb-2cd9-a85c-1868-0c824b150634@mediaarea.net>
User-Agent: Evolution 3.38.3-1+deb11u1 
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] avformat/mxfenc: SMPTE RDD 48:2018 Amd 1:2022
 (FFV1 in MXF) support
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/a8992de53a0b8d6144a443b26242f760ff4e4526.camel@haerdin.se/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>


Creating a new subthread because I just noticed something

> +    //Stored height
>      mxf_write_local_tag(s, 4, 0x3202);
>      avio_wb32(pb, stored_height>>sc->interlaced);
> 

Won't this be incorrect for files whose dimensions are multiples of 16
but not multiples of 32? Isn't each field stored separately with
dimensions a multiple of 16? So while for 1080p we'll have

  StoredHeight = 1088
  SampledHeight = 1080

and 1080i:

  StoredHeight = 544
  SampledHeight = 540

Where 544 is a multiple of 16, for say 720p we have

  StoredHeight = 720
  SampledHeight = 720

but for a hypothetical 720i we'd get

  StoredHeight = 360
  SampledHeight = 360

whereas the correct values should be

  StoredHeight = 368
  SampledHeight = 360

?

/Tomas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".