Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] avformat/mxfenc: SMPTE RDD 48:2018 Amd 1:2022 (FFV1 in MXF) support
Date: Wed, 18 Jan 2023 14:40:39 +0100
Message-ID: <a8992de53a0b8d6144a443b26242f760ff4e4526.camel@haerdin.se> (raw)
In-Reply-To: <b7f281fb-2cd9-a85c-1868-0c824b150634@mediaarea.net>


Creating a new subthread because I just noticed something

> +    //Stored height
>      mxf_write_local_tag(s, 4, 0x3202);
>      avio_wb32(pb, stored_height>>sc->interlaced);
> 

Won't this be incorrect for files whose dimensions are multiples of 16
but not multiples of 32? Isn't each field stored separately with
dimensions a multiple of 16? So while for 1080p we'll have

  StoredHeight = 1088
  SampledHeight = 1080

and 1080i:

  StoredHeight = 544
  SampledHeight = 540

Where 544 is a multiple of 16, for say 720p we have

  StoredHeight = 720
  SampledHeight = 720

but for a hypothetical 720i we'd get

  StoredHeight = 360
  SampledHeight = 360

whereas the correct values should be

  StoredHeight = 368
  SampledHeight = 360

?

/Tomas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2023-01-18 13:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-14 15:45 Jerome Martinez
2023-01-16 14:00 ` Tomas Härdin
2023-01-16 14:17   ` Jerome Martinez
2023-01-18 10:12     ` Tomas Härdin
2023-01-18 14:25       ` Jerome Martinez
2023-01-18 13:40 ` Tomas Härdin [this message]
2023-01-18 14:15   ` Jerome Martinez
2023-01-20 15:17     ` Tomas Härdin
2023-01-29 16:36       ` Dave Rice
2023-01-31 14:53         ` Tomas Härdin
2023-03-14  9:52           ` Jerome Martinez
2023-03-15 14:00             ` Tomas Härdin
2023-03-24 13:59               ` Dave Rice
2023-03-25 18:29                 ` Tomas Härdin
2023-04-01 14:37             ` Michael Niedermayer
2023-04-01 15:20               ` Jerome Martinez
2023-04-01 15:43                 ` Michael Niedermayer
2023-04-01 17:11                   ` Jerome Martinez
2023-04-02 20:07                     ` Michael Niedermayer
2023-04-02 22:07                       ` Jerome Martinez
2023-04-04 14:43                         ` Michael Niedermayer
2023-04-04 14:57                           ` Jerome Martinez
2023-04-04 17:32                             ` Michael Niedermayer
2023-04-04 21:37                               ` Jerome Martinez
2023-04-05 12:31                                 ` Michael Niedermayer
2023-04-05 12:42                                   ` Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8992de53a0b8d6144a443b26242f760ff4e4526.camel@haerdin.se \
    --to=git@haerdin.se \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git