From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AA56142AEC for ; Wed, 13 Apr 2022 08:15:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 70F7F68B371; Wed, 13 Apr 2022 11:15:28 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 722B868B281 for ; Wed, 13 Apr 2022 11:15:22 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 23D8FLcF017899-23D8FLcG017899; Wed, 13 Apr 2022 11:15:21 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 5AA12A1428; Wed, 13 Apr 2022 11:15:21 +0300 (EEST) Date: Wed, 13 Apr 2022 11:15:19 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: References: MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 1/4] tests/Makefile: Add auxiliary functions for transcode and stream_remux X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 12 Apr 2022, Andreas Rheinhardt wrote: > Tests using the transcode and stream_remux functions have some common > requirements (namely the file and pipe protocols as well as the framecrc > muxer) and also other commonalities: The create a file and read it > immediately afterwards, so that they typically rely on a corresponding > muxer+demuxer pair which typically shares the same name; for transcode > (if it does not use stream copy) the same is true for encoders and > decoders. This means that using special Makefile-functions instead > of the general ALLYES is worthwhile. This commit adds such functions. > > These functions allow to add arbitrary CONFIG-checks on top of the > aforementioned ones in order to satisfy special needs (for e.g. parsers, > filters) that several intended users have. > > Signed-off-by: Andreas Rheinhardt > --- > tests/Makefile | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/tests/Makefile b/tests/Makefile > index e3b41a4f7b..5e4da2c42f 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -74,6 +74,16 @@ ENCDEC2 = $(call ALLYES, $(firstword $(1))_ENCODER $(lastword $(1))_DECODER \ > $(firstword $(2))_ENCODER $(lastword $(2))_DECODER \ > $(firstword $(3))_MUXER $(lastword $(3))_DEMUXER) > > +# RAWVIDEO_ENCODER and PCM_S16LE_ENCODER corresponds to the default codecs > +# for framecrc. These requirements are not always necessary. > +TRANSCODE = $(call ALLYES, $(firstword $(1))_ENCODER $(lastword $(1))_DECODER \ > + $(firstword $(2))_MUXER $(lastword $(2))_DEMUXER \ > + $(3) FILE_PROTOCOL PIPE_PROTOCOL RAWVIDEO_ENCODER \ > + PCM_S16LE_ENCODER FRAMECRC_MUXER) > + > +REMUX = $(call ALLYES, $(firstword $(1))_MUXER $(lastword $(1))_DEMUXER \ > + $(2) FILE_PROTOCOL PIPE_PROTOCOL FRAMECRC_MUXER) > + > DEMDEC = $(call ALLYES, $(1)_DEMUXER $(2:%=%_DECODER)) > ENCMUX = $(call ALLYES, $(1:%=%_ENCODER) $(2)_MUXER) This looks good to me (provided that the rest of the patches using it end up sensible). // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".