From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 473A64AB03 for ; Mon, 17 Jun 2024 11:22:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B981768D72A; Mon, 17 Jun 2024 14:22:45 +0300 (EEST) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 260B668D72A for ; Mon, 17 Jun 2024 14:22:39 +0300 (EEST) Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52c89d6b4adso3916258e87.3 for ; Mon, 17 Jun 2024 04:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1718623358; x=1719228158; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=w39EzIog6ZtWRc1b6WY4zIiXCSboNvZ/EORFIup3IV8=; b=urQJ6vSiG5Wawxu9Bpq79I/BvOGzwAuuPu9uC4dZxibYgZWyl/OaZd4tfJpoqkl95L CbRrX0NgJpth2iYpToBzWVseBapkMcN2uPGlhLEuK2G0Mgi7KRc/BStYK6h2d5Sg6niN Ivm8oN21q9WX9ZJUZb73lgF/qMoXiXAWxz+Xb/7/IoyTA01rhkVACcf9wkciLGhJG07h 4VONWuAuui9EcmgKps+RACgx6hV9sya4er197QKFYEHF6rlma04bJ3ODK3o0hng+8Hhk zsR6kYGzkDep59CTP6cZIr5EY6a9/AR4WThqRwrHuwh1O7zVTI360GfV6XPLgUtCc85G h+Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718623358; x=1719228158; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w39EzIog6ZtWRc1b6WY4zIiXCSboNvZ/EORFIup3IV8=; b=vC3PQdtSsxSI1/4v4i8csJKU1oMfoXjnk9JG9NPj5++H3d1u/7C6KK7Au/+4m3qqGp HJcVerZvd/t2qgwXIPB7wthvv4bM5Rb70amX9GruAgky8CqGdRbi3T7P+BeJfdAWdt91 C0XKNjVkUA6jDlUYJxIyM+2ZdJXKPUF+lm6/lYz0nYeV3G9JMalwZSvWb04XJI2vhXds VoXr43quqnXhOeatpAaarBgeAhR7/2Gbb8U242pcpY0mid5Hpjq4HEYq+j/jixBIWz9o 2f08mSWvyIRRQwkVJ3xhW/ujnoT37g99UqFEYba5jN4tU5BCS7sNxg9roAMkAexEgH71 /I9Q== X-Gm-Message-State: AOJu0YxOCiQyufXa7leRTjLAh+3qMHkWx9OhgqSZGxSb90E2Rn3e7wQC MBY9GaIoQUM7xBasjfg4YJ0ha1fzvr1+D5uxmqExGa6GLav8uwH/kdosDa2zxUi5gkaGL2/Ofu+ pNg== X-Google-Smtp-Source: AGHT+IGwB1H6qhFACZ3q8tOv3thUjLtZGLKmwvo/gPhfCv1IwymCgmjDI2k61+hpk98scb+qDTh8gA== X-Received: by 2002:a19:ca49:0:b0:52c:85a8:669 with SMTP id 2adb3069b0e04-52ca6e6599emr5074427e87.20.1718623358144; Mon, 17 Jun 2024 04:22:38 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52ca282ed7dsm1228529e87.92.2024.06.17.04.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 04:22:34 -0700 (PDT) Date: Mon, 17 Jun 2024 14:22:33 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <934fa88-8b2f-98f9-2f6d-47d16587f93c@martin.st> Message-ID: References: <934fa88-8b2f-98f9-2f6d-47d16587f93c@martin.st> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avutil/timer: define macos kperf as AV_READ_TIME X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-15"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 17 Jun 2024, Martin Storsj=F6 wrote: > On Wed, 12 Jun 2024, Zhao Zhili wrote: > >> From: Zhao Zhili >> = >> Firstly, make ff_kperf_cycles as an implementation of AV_READ_TIME >> avoids code duplication. >> = >> Secondly, fix compilation error since 6a18c0bc87e when macos-kperf >> is enabled. mach_time.h is included only when CONFIG_MACOS_KPERF >> is 0. The error happened due to define mach_absolute_time as >> AV_READ_TIME but missing include mach_time.h. Define macos kperf >> as AV_READ_TIME fixed the issue. > > Can you elaborate on what your actual goal is here? We have relatively li= ttle = > use of AV_READ_TIME (mostly START/STOP_TIMER), while most benchmarking th= ese = > days is done via checkasm. Do you have a real case where you want to do = > benchmarking with this api, outside of checkasm? > > Or do you just want to fix the compilation error? In that case I guess it= 's = > possible to fix differently by adding the missing includes. Btw, in this case, the compilation error also went away when I pushed the = patch that made it use inline assembly with cntvct_el0 on macOS too. But as long as we do have the common AV_READ_TIME fallback to = mach_absolute_time, we definitely should include the right header for that = case anyway. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".