From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] improve VAAPI error handling
Date: Mon, 19 Sep 2022 04:08:31 +0000
Message-ID: <a84ffb7e6fb475e30e0f295d42df9e4a83ebe7b4.camel@intel.com> (raw)
In-Reply-To: <91efc26f-85a3-ceaa-c5ad-a2e23659c60f@web.de>
> In case something is wrong in vaapi_device_create() you usually just get
> EINVAL, but not the real cause.
> This patch allows to return the cause as set in errno.
> EINVAL is used for kernel driver name mismatch.
> ENODEV in case vaGetDisplayDRM() fails.
> Also changed:
> Try X11 interface in case vaGetDisplayDRM() fails.
> Try to open any of the possible 8 devices.
Could you update your commit message ? There is a warning in patchwork check
(See
https://patchwork.ffmpeg.org/project/ffmpeg/patch/91efc26f-85a3-ceaa-c5ad-a2e23659c60f@web.de/
)
BTW you may add the above message in the commit message too.
BRs
Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-09-19 4:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-10 17:12 Andreas Kies
2022-09-19 4:08 ` Xiang, Haihao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a84ffb7e6fb475e30e0f295d42df9e4a83ebe7b4.camel@intel.com \
--to=haihao.xiang-at-intel.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git