From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 09A2F436AC for ; Thu, 21 Jul 2022 21:05:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4094D68B697; Fri, 22 Jul 2022 00:05:40 +0300 (EEST) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A54DB680446 for ; Fri, 22 Jul 2022 00:05:33 +0300 (EEST) Received: by mail-wr1-f52.google.com with SMTP id z13so3948310wro.13 for ; Thu, 21 Jul 2022 14:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=/5J+jq6JW5CKrfgRcCOL0I4Lm8BPRPcvRBbZDO/O5fI=; b=ywd4XIZUaLvdGw5Km3qdzsRV1hJd4iZll1pV0PiMvIDynBO9oLHnujbfxb1/WbkWzK vhOck0P+iboqDxF+WR/Xe3Mw5211crph2+l6YL27IuPoKBQFbd2UNZ7G8h8TDdZsxjmB F6dr09gLtybI95lz++m1DJ2aMPN6X1qPnqSQkU2JRKYZzzZ7Yl5mhUZdnKWuP83/558d kDgnjorFfrFCTMO23LTCcNV0kPGtRKkzOJ5DhJqShtKsULz/14TUwLKRSnD4pWX4ffpb PLxDfIXLBkTD4DXHz7HQ5/sEj/4pN+xfUtLeZjl1szlR3EEdYgIQBokJp2VHvhVIdONA W3sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=/5J+jq6JW5CKrfgRcCOL0I4Lm8BPRPcvRBbZDO/O5fI=; b=gzdawIGkoqQ3LG2YHqiUEPtJucvUrjr24C1oNvgrqH+pRdfIbdOrsOeHuSyB2kXsf7 E/PYYG91zT/z8IiUGSZDAeDwTot3loGrIdAwYYaiJVfaeN3eKPSfpjIuU9eSRPJ/P6aw QUY8tolcSnko7pD0j1HiD1QgpUCQchFHfTRy4s3l/UeL54kONt7ce6qCcVZ03eDCDJIJ pHXA3R179iaA7TYETmtyRU+vK+DA2OOdXOBBoMbusC4SKHx1sfbwH8ebIgtrU/5rF1au l1tcxFlu4tw1dbTeWU7slKgnUMeuwOiCbmzNBKRY4zy1kJWoIle1wGn3cQe2mfdag5QP glPw== X-Gm-Message-State: AJIora/UteQNBy/oPdMBKwm7FNbP9pYNuezsO452appTZtaSkxazdxcR oqxIU5QGhlGe9vgjtH/0CWtp3/mehUDduA== X-Google-Smtp-Source: AGRyM1vkGkLm/RmwIGmGSn28PKziSlQmSE3cgDuE/iN/HcwIeTD+dcgT6wcDg28ANo1aQMbNJDH65w== X-Received: by 2002:a05:6000:114f:b0:21d:6e51:6e55 with SMTP id d15-20020a056000114f00b0021d6e516e55mr222700wrx.132.1658437533214; Thu, 21 Jul 2022 14:05:33 -0700 (PDT) Received: from [192.168.0.14] (cpc91224-cmbg18-2-0-cust209.5-4.cable.virginm.net. [81.106.228.210]) by smtp.gmail.com with ESMTPSA id az28-20020a05600c601c00b003a325bd8517sm3746845wmb.5.2022.07.21.14.05.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jul 2022 14:05:32 -0700 (PDT) Message-ID: Date: Thu, 21 Jul 2022 22:05:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220720105646.716398-1-emil.l.velikov@gmail.com> <20220720105646.716398-4-emil.l.velikov@gmail.com> From: Mark Thompson In-Reply-To: <20220720105646.716398-4-emil.l.velikov@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v2 3/3] hwcontext_vaapi: #if guard VAAPI_DRM specifics X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 20/07/2022 11:56, Emil Velikov wrote: > From: Emil Velikov > > Similar to the VAAPI_X11 bits, guard all the VAAPI_DRM parts behind a > compiler guard. > > Signed-off-by: Emil Velikov > --- > libavutil/hwcontext_vaapi.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c > index 7734a50fc0..7aea3e7b96 100644 > --- a/libavutil/hwcontext_vaapi.c > +++ b/libavutil/hwcontext_vaapi.c > @@ -18,6 +18,10 @@ > > #include "config.h" > > +#if !HAVE_VAAPI_X11 && !HAVE_VAAPI_DRM > +#error "At least one VAAPI winsys is required X11 or DRM" No it isn't. Originally there wasn't a possibility to link with any winsys here - libavcodec users had to get the device themselves and pass it in. The winsys link was added to the ffmpeg utility initially for command-line use and then moved to libavutil when it was clear that it would be useful to other library users; there isn't any requirement to use it, though. (E.g. disable it and note that programs handling the winsys themselves like mpv and vlc still work perfectly well.) - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".