From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EC44848850 for ; Mon, 18 Dec 2023 18:10:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 24D0768D0E9; Mon, 18 Dec 2023 20:10:03 +0200 (EET) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 77B6468D0E4 for ; Mon, 18 Dec 2023 20:09:56 +0200 (EET) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6d411636a95so1356439b3a.0 for ; Mon, 18 Dec 2023 10:09:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702922994; x=1703527794; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ACHzJ4eB2MJRAOUeKoA8muLZyFpu63iLyzQkuyhIako=; b=hiLpFyPQyKrxhfipVT4GAQK5aTUPdKW7EeFIUVJl1ITo7TJsZ+UW8Dqa19a7rRh+l6 PrOFWg6R3fi955TMv9QTxpDzFaBC9dSQyUuYkcmb6OPDVz/D1FmxSc6es0u6CM8e/fn3 BlJ2YVniUJkbL2i5xt9Fuov52BKTpi6Qp/JsWuoFIRoCOw+ieyn0O9RsMTjOJQn2lPdv T52JdXb/OPXaG3qcIlaqYVtwkXJl/WfK4pU/thrvjx7x5OmnmzJtDZTb2xzKJj824VEM 8P1vJJYHo+6KvYq6PsxCABgyGkd122FHC0yd7TPscaJv1sWuhbYoGKv8hooXUh95tvK5 58Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702922994; x=1703527794; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ACHzJ4eB2MJRAOUeKoA8muLZyFpu63iLyzQkuyhIako=; b=XuX+VV2+E/mo0/T/NU+NG9xHY5I7KKn0Dy7ay8NeZ5gSlt9HWHLWZmRhIgkuX6D0XE tdu0GB1K/NO5D92lQ0ILSbCw/PVMl5Mtl7DmuC7QjxWE+zLljvQP7ByWWIGqGTLFDNCM 1faCJ7Sn/+y5Db7I93kwVXRnft0vkdXSj4/s3owIIQJoVhWU6bsK3ioC6snakoxSNUw8 v/cZSr7h0kOLgU9TAKAd+kReVqt7jqJv3qBIZVwT5FqR5Y9fV8yGRJW6PmtZA8sFT2kI 21aGYwvItS1uds8DvjTOQa83JfaWSUCrlmcFzoxYOChOANLrMmATSpU4gaaKmwhqGxnx DqcA== X-Gm-Message-State: AOJu0YxConh2ycHXSV+/WV0IPXdoK9xPSh3mg0OJLCOCLfMDiI8OxljT imWGsCwmRuklgMaTbGpc4oUrVGbA6UE= X-Google-Smtp-Source: AGHT+IFusaMdwceBv8KDXQ4YdF1UMm9Il556ZQBgwtIxxuN1lF5bllCXCAYfIuz+ikBKX4Z5YX5uIg== X-Received: by 2002:a05:6a21:998a:b0:190:cab:b3d4 with SMTP id ve10-20020a056a21998a00b001900cabb3d4mr19668277pzb.30.1702922993970; Mon, 18 Dec 2023 10:09:53 -0800 (PST) Received: from [192.168.0.13] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id p20-20020a63fe14000000b005c67721e6c0sm17915497pgh.53.2023.12.18.10.09.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Dec 2023 10:09:53 -0800 (PST) Message-ID: Date: Mon, 18 Dec 2023 15:10:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231214201433.4608-1-jamrial@gmail.com> <20231214201433.4608-2-jamrial@gmail.com> <170289749260.8914.14905207691567469566@lain.khirnov.net> Content-Language: en-US From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <170289749260.8914.14905207691567469566@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 1/8] avutil: introduce an Immersive Audio Model and Formats API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/18/2023 8:04 AM, Anton Khirnov wrote: > Quoting James Almer (2023-12-14 21:14:26) >> +/** >> + * Mix Gain Parameter Data as defined in section 3.8.1 of IAMF. >> + */ >> +typedef struct AVIAMFMixGain { >> + const AVClass *av_class; >> + >> + /** >> + * Duration for the given subblock. It must not be 0. > > In what units? Same for all durations in this patch. parameter_rate. Amended. > >> +typedef struct AVIAMFParamDefinition { >> + const AVClass *av_class; >> + >> + /** >> + * Offset in bytes from the start of this struct, at which the subblocks >> + * array is located. >> + */ >> + size_t subblocks_offset; >> + /** >> + * Size in bytes of each element in the subblocks array. >> + */ >> + size_t subblock_size; >> + /** >> + * Number of subblocks in the array. >> + * >> + * Must be 0 if @ref constant_subblock_duration is not 0. Removed this line as it's bogus. >> + */ >> + unsigned int nb_subblocks; >> + >> + /** >> + * Parameters type. Determines the type of the subblock elements. >> + */ >> + enum AVIAMFParamDefinitionType type; >> + >> + /** >> + * Identifier for the paremeter substream. >> + */ >> + unsigned int parameter_id; >> + /** >> + * Sample rate for the paremeter substream. It must not be 0. >> + */ >> + unsigned int parameter_rate; >> + >> + /** >> + * The duration of the all subblocks in this parameter definition. >> + * >> + * May be 0, in which case all duration values should be specified in >> + * another parameter definition referencing the same parameter_id. >> + */ >> + unsigned int duration; >> + /** >> + * The duration of every subblock in the case where all subblocks, with >> + * the optional exception of the last subblock, have equal durations. >> + * >> + * Must be 0 if subblocks have different durations. >> + */ >> + unsigned int constant_subblock_duration; > > This also seems like should be a flags field. No, duration and subblock duration are not the same thing. The former is the accumulated duration of all subblocks in a given parameter definition. subblock durations can be smaller, and only if they are constant will constant_subblock_duration be set to a value other than 0. > > Otherwise looks good. > Pushed. Thanks a lot for looking at it. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".