From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id A656848479
	for <ffmpegdev@gitmailbox.com>; Thu,  4 Jan 2024 12:48:26 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7FAD468CDD9;
	Thu,  4 Jan 2024 14:48:24 +0200 (EET)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5833568CA9D
 for <ffmpeg-devel@ffmpeg.org>; Thu,  4 Jan 2024 14:48:18 +0200 (EET)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 404CmHKx004605-404CmHL0004605
 for <ffmpeg-devel@ffmpeg.org>; Thu, 4 Jan 2024 14:48:17 +0200
Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144])
 by mail9.parnet.fi (Postfix) with ESMTPS id B7D0DA1482
 for <ffmpeg-devel@ffmpeg.org>; Thu,  4 Jan 2024 14:48:17 +0200 (EET)
Date: Thu, 4 Jan 2024 14:48:17 +0200 (EET)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: ffmpeg-devel@ffmpeg.org
In-Reply-To: <20231221221022.280234-1-martin@martin.st>
Message-ID: <a7ee6e48-4873-4f9-d1a-3af3917a5529@martin.st>
References: <20231221221022.280234-1-martin@martin.st>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [FFmpeg-devel] [PATCH] configure: Don't pass -mfp16-format to
 MSVC on ARM
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-15"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/a7ee6e48-4873-4f9-d1a-3af3917a5529@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Fri, 22 Dec 2023, Martin Storsj=F6 wrote:

> The check for this option does succeed - MSVC accepts the option,
> but prints a warning about it being unknown and ignored, for
> each compiled object file:
>
>    cl : Command line warning D9002 : ignoring unknown option '-mfp16-form=
at=3Dieee'
>
> The configure script only attempts to add this option on ARM,
> therefore this warning isn't seen by the majority of people
> building with MSVC.
>
> Making this option into a no-op probably isn't entirely right,
> but on the other hand, we don't want to litter the code that
> checks for support for the option with compiler specific
> conditions either.
> ---
> configure | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configure b/configure
> index 18fe8eaa5c..31d0039fed 100755
> --- a/configure
> +++ b/configure
> @@ -4702,6 +4702,7 @@ msvc_common_flags(){
>             -fPIC)                ;;
>             -mthumb)              ;;
>             -march=3D*)             ;;
> +            -mfp16-format=3D*)      ;;
>             -lz)                  echo zlib.lib ;;
>             -lx264)               echo libx264.lib ;;
>             -lstdc++)             ;;
> -- =

> 2.34.1

Will push soon

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".