From: Thilo Borgmann <thilo.borgmann@mail.de>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v4 3/7] avcodec/webp_parser: parse each frame into one packet
Date: Tue, 25 Jul 2023 16:18:02 +0200
Message-ID: <a7cb06b8-fbdd-7dc3-0013-e681609d103a@mail.de> (raw)
In-Reply-To: <f5c16b9d6069e6918a3e880c82e9ac91c65afdb6.camel@haerdin.se>
Am 25.07.23 um 14:24 schrieb Tomas Härdin:
>> + // Extremely simplified key frame detection:
>> + // - the first frame (containing headers) is marked as a key
>> frame
>> + // - other frames are marked as non-key frames
>
> Is there a more proper way of doing this?
All frames (except the ANMF chunks) are INTRA, and all of them have a WEBP tag.
Whereas all ANMF chunks are in the same WEBP chunk as their reference frame.
So it should really be as simple as it is to mark all WEBP frames as key frames as the code does.
What more dedicated do you have in mind?
The logic as-is works with all samples I have, animated and not.
Seems to also align well with their example file layouts.
You have a more weird one?
> Looking briefly at the spec
> one wonders why they didn't just use regular VP* inter frames..
I assume the whole canvas idea could be more beneficial than vp8 inter - but otoh I don't know about vp8 compositing capabilities, if any..
-Thilo
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-25 14:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 8:58 [FFmpeg-devel] [PATCH v4 0/7] webp: add support for animated WebP decoding Thilo Borgmann
2023-07-25 8:58 ` [FFmpeg-devel] [PATCH v4 1/7] avcodec/webp: move definitions into header Thilo Borgmann
2023-07-25 8:58 ` [FFmpeg-devel] [PATCH v4 2/7] avcodec/webp: remove unused definitions Thilo Borgmann
2023-07-25 8:58 ` [FFmpeg-devel] [PATCH v4 3/7] avcodec/webp_parser: parse each frame into one packet Thilo Borgmann
2023-07-25 12:24 ` Tomas Härdin
2023-07-25 14:18 ` Thilo Borgmann [this message]
2023-07-25 19:46 ` James Zern
2023-07-26 21:35 ` Tomas Härdin
2023-07-27 17:21 ` James Zern
2023-07-25 8:58 ` [FFmpeg-devel] [PATCH v4 4/7] libavcodec/webp: add support for animated WebP decoding Thilo Borgmann
2023-07-25 8:58 ` [FFmpeg-devel] [PATCH v4 5/7] avcodec/webp: make init_canvas_frame static Thilo Borgmann
2023-07-25 8:58 ` [FFmpeg-devel] [PATCH v4 6/7] libavformat/webp: add WebP demuxer Thilo Borgmann
2023-07-25 8:58 ` [FFmpeg-devel] [PATCH v4 7/7] fate: add test for animated WebP Thilo Borgmann
2023-07-25 20:14 ` [FFmpeg-devel] [PATCH v4 0/7] webp: add support for animated WebP decoding James Zern
2023-07-27 11:29 ` Thilo Borgmann
2023-07-27 17:42 ` James Zern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7cb06b8-fbdd-7dc3-0013-e681609d103a@mail.de \
--to=thilo.borgmann@mail.de \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git