Re: [FFmpeg-devel] [PATCH] avcodec/mjpegbdec: return the amount of bytes consumed when discarding frames

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mjpegbdec: return the amount of bytes consumed when discarding frames
Date: Tue, 27 Dec 2022 10:43:21 -0300
Message-ID: <a79c6244-2275-1ea4-58d1-65ee0cd21ce8@gmail.com> (raw)
In-Reply-To: <20221226113352.180-1-jamrial@gmail.com>

On 12/26/2022 8:33 AM, James Almer wrote:
> EAGAIN is not correct in this scenario. FFCodec.cb.decode() callback decoders
> always return the amount of bytes consumed from the input packet (if any), and
> report if a frame was generated by setting got_frame.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>   libavcodec/mjpegbdec.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/mjpegbdec.c b/libavcodec/mjpegbdec.c
> index a82a95d70a..6d422e7a29 100644
> --- a/libavcodec/mjpegbdec.c
> +++ b/libavcodec/mjpegbdec.c
> @@ -144,7 +144,7 @@ read_header:
>       av_frame_move_ref(rframe, s->picture_ptr);
>       s->got_picture = 0;
>       if (avctx->skip_frame == AVDISCARD_ALL)
> -        return AVERROR(EAGAIN);
> +        return buf_size;
>       *got_frame = 1;
>   
>       if (!s->lossless && avctx->debug & FF_DEBUG_QP) {

Applied.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".