From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Zhao Zhili <zhilizhao@tencent.com>
Subject: Re: [FFmpeg-devel] [PATCH v2 2/4] avutil/timer: Add clock_gettime as a fallback of AV_READ_TIME
Date: Fri, 7 Jun 2024 12:11:50 +0300 (EEST)
Message-ID: <a7445a49-512a-c7b0-af41-e3a88a194856@martin.st> (raw)
In-Reply-To: <tencent_50EF736715C7A91ECEA9C54853030852B305@qq.com>
On Fri, 7 Jun 2024, Zhao Zhili wrote:
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> ---
> libavutil/timer.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/libavutil/timer.h b/libavutil/timer.h
> index 2cd299eca3..74c4d84e69 100644
> --- a/libavutil/timer.h
> +++ b/libavutil/timer.h
> @@ -46,6 +46,8 @@
> #include "macos_kperf.h"
> #elif HAVE_MACH_ABSOLUTE_TIME
> #include <mach/mach_time.h>
> +#elif HAVE_CLOCK_GETTIME
> +#include <time.h>
> #endif
>
> #include "common.h"
> @@ -70,6 +72,9 @@
> # define AV_READ_TIME gethrtime
> # elif HAVE_MACH_ABSOLUTE_TIME
> # define AV_READ_TIME mach_absolute_time
> +# elif HAVE_CLOCK_GETTIME && defined(CLOCK_MONOTONIC)
> +# include "libavutil/time.h"
> +# define AV_READ_TIME av_gettime_relative
> # endif
> #endif
>
> --
> 2.34.1
This looks reasonable to me.
Although, the raw clock_gettime function, which gives nanosecond values
(although maybe not actual nanosecond precision) probably could have more
precision than av_gettime_relative which scales the values down to
microseconds.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-07 9:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240606172018.1514-1-quinkblack@foxmail.com>
2024-06-06 17:20 ` Zhao Zhili
2024-06-07 9:11 ` Martin Storsjö [this message]
2024-06-06 17:20 ` [FFmpeg-devel] [PATCH v2 3/4] tests/checkasm: Fix build error when enable linux perf on Android Zhao Zhili
2024-06-07 8:21 ` Martin Storsjö
2024-06-07 8:36 ` Zhao Zhili
2024-06-07 8:50 ` Martin Storsjö
2024-06-07 8:38 ` Martin Storsjö
2024-06-07 9:08 ` Zhao Zhili
2024-06-06 17:20 ` [FFmpeg-devel] [PATCH v2 4/4] swscale/aarch64: Add rgb24 to yuv implementation Zhao Zhili
2024-06-07 9:09 ` Martin Storsjö
2024-06-07 11:29 ` Zhao Zhili
2024-06-07 11:41 ` Martin Storsjö
2024-06-07 11:29 ` Zhao Zhili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7445a49-512a-c7b0-af41-e3a88a194856@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=zhilizhao@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git