From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id ACACD40231 for ; Fri, 18 Feb 2022 13:07:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7B9C868B1EA; Fri, 18 Feb 2022 15:07:28 +0200 (EET) Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4AF8868AAA0 for ; Fri, 18 Feb 2022 15:07:22 +0200 (EET) Received: by mail-oi1-f174.google.com with SMTP id j24so810710oii.11 for ; Fri, 18 Feb 2022 05:07:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=GJbidC1J+eQOYYF3f/kmd+p2xnRkZFc5DY/uVM+2w4w=; b=Kmqg85/UPbNQAebE2Js1+r739M7XSZ+a8SLjuSLyyquR749gDIFlSBtC1bkYNoPB7S 5F8OovEiUqktaDL7HcxzwGjU3R3sYANQOdT5k3wcEgXBsAzfI7Z4BkdMQQn6FscKglFs lYsPr/fMDcugLs6l8nUkBW/QU2FPJWsVLKwh+LkkT/HyfVs2YXS+tXdJiZBASFAClPyQ q7Qm2E9xD4WpGIB9F44qUJwc0gPC0mBIFStxM6w8cnycYDwhLme+v6bwYEQa8/xvaKCc 5546TRnv574dQWJ52Xddvw4upkHI24zqxNAgwevNtgZLDnc1cygpDP+M6GFAcZ2c1Yp8 NnCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=GJbidC1J+eQOYYF3f/kmd+p2xnRkZFc5DY/uVM+2w4w=; b=rjMo/ESMGGxcnBlomPsnvuk+2gsIRpO56y7nyj4NJ8syw6JhNi/aZ8uB47Vh0l4NPf qsmurfGlNe8kaKJc0mVtbTgYO+moIiTBpqSPPpdRHMb6YftzgWBXVwKRR84LeFbYqoPw 7gbeO/qZlD/gxytGVOaEB7wlJTSI3YTeyheRT6LO0aA4pLru8pwQRFPFyKzZP53vsl9c KyC7ziq7RMeHX9YT80pM8dfyBvrdAjsKnDegV7t63s7n3pTp/3zfINVRbCLDIM75LCe6 /IbHLfhHnWsxZPApJaInUL7tJTfQYzbEwG+Hj4hEamxFmM5I7FkAZXM4piISqAhTuCFf NM2A== X-Gm-Message-State: AOAM532jenL6dut94xKhl9TxMgwNAN8o0gUBUJJO6qvciar2UnWYSWJV EP22tzFf4ed9pw1sp0hVEyQAj43Ec7j+oA== X-Google-Smtp-Source: ABdhPJyDw7e28mBw5vcvdd54GvMiwmxR5lgL03ebJt60dJVrH3Q2Umq5Ie9nuhRlRjQLk2T4fdGiDw== X-Received: by 2002:aca:6256:0:b0:2cf:2247:4219 with SMTP id w83-20020aca6256000000b002cf22474219mr5388484oib.176.1645189640263; Fri, 18 Feb 2022 05:07:20 -0800 (PST) Received: from [192.168.0.10] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id e6sm3343294oao.28.2022.02.18.05.07.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Feb 2022 05:07:19 -0800 (PST) Message-ID: Date: Fri, 18 Feb 2022 10:07:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220113015101.4-1-jamrial@gmail.com> <20220113020913.870-6-jamrial@gmail.com> <164503533751.19727.8561650103287228754@lain.red.khirnov.net> From: James Almer In-Reply-To: <164503533751.19727.8561650103287228754@lain.red.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 275/281] avfilter: convert to new channel layout API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/16/2022 3:15 PM, Anton Khirnov wrote: >> diff --git a/libavfilter/src_movie.c b/libavfilter/src_movie.c >> index b89a680883..3ebd279df7 100644 >> --- a/libavfilter/src_movie.c >> +++ b/libavfilter/src_movie.c >> @@ -189,23 +189,24 @@ static int guess_channel_layout(MovieStream *st, int st_index, void *log_ctx) >> { >> AVCodecParameters *dec_par = st->st->codecpar; >> char buf[256]; >> - int64_t chl = av_get_default_channel_layout(dec_par->channels); >> + AVChannelLayout chl = { 0 }; >> >> - if (!chl) { >> + av_channel_layout_default(&chl, dec_par->ch_layout.nb_channels); >> + >> + if (!KNOWN(&chl)) { >> av_log(log_ctx, AV_LOG_ERROR, >> "Channel layout is not set in stream %d, and could not " >> "be guessed from the number of channels (%d)\n", >> - st_index, dec_par->channels); >> + st_index, dec_par->ch_layout.nb_channels); >> return AVERROR(EINVAL); > Should this still be an error? Unspec layouts should now be properly > supported by (almost?) everything. Probably, but making it no longer abort if a native channel layout can't be guessed is a behavior change that I'd rather leave for a different patch, if you don't mind. > > -- Anton Khirnov _______________________________________________ > ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit > link above, or email ffmpeg-devel-request@ffmpeg.org with subject > "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".