From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: add AV1 encoding support
Date: Wed, 2 Nov 2022 11:12:57 +0100
Message-ID: <a6ca3e51-eeed-c9b9-c6d5-1b86d14e3de6@rothenpieler.org> (raw)
In-Reply-To: <GV1P250MB07378294143B02A551C7DA318F399@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
On 02/11/2022 02:14, Andreas Rheinhardt wrote:
> Timo Rothenpieler:
>> ---
>>
>> diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c
>> index 3c6fce391d..9a1a1fcc37 100644
>> --- a/libavcodec/nvenc.c
>> +++ b/libavcodec/nvenc.c
>> @@ -1,5 +1,5 @@
>> /*
>> - * H.264/HEVC hardware encoding using nvidia nvenc
>> + * H.264/HEVC/AV1 hardware encoding using nvidia nvenc
>> * Copyright (c) 2016 Timo Rothenpieler <timo@rothenpieler.org>
>> *
>> * This file is part of FFmpeg.
>> @@ -222,8 +222,14 @@ static void nvenc_map_preset(NvencContext *ctx)
>>
>> static void nvenc_print_driver_requirement(AVCodecContext *avctx, int level)
>> {
>> -#if NVENCAPI_CHECK_VERSION(11, 2)
>> +#if NVENCAPI_CHECK_VERSION(12, 1)
>> const char *minver = "(unknown)";
>> +#elif NVENCAPI_CHECK_VERSION(12, 0)
>> +# if defined(_WIN32) || defined(__CYGWIN__)
>> + const char *minver = "???.??";
>> +# else
>> + const char *minver = "???.??";
>> +# endif
>
> Either one of the above is wrong or the above #if is superfluous (or I
> am blind).
Video SDK 12 is not released yet, so there is no documentation on the
driver versions.
Whenever it gets release, which was scheduled to happen in October
already, those need filled in.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-11-02 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 23:59 Timo Rothenpieler
2022-11-02 1:14 ` Andreas Rheinhardt
2022-11-02 10:12 ` Timo Rothenpieler [this message]
2022-11-02 20:51 ` [FFmpeg-devel] [PATCH v2] " Timo Rothenpieler
2022-11-04 11:40 ` [FFmpeg-devel] [PATCH v3] " Timo Rothenpieler
2022-11-05 17:08 ` Philip Langdale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6ca3e51-eeed-c9b9-c6d5-1b86d14e3de6@rothenpieler.org \
--to=timo@rothenpieler.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git