From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 957D740F93 for ; Mon, 14 Mar 2022 12:17:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1308B68B19F; Mon, 14 Mar 2022 14:17:02 +0200 (EET) Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1378968A717 for ; Mon, 14 Mar 2022 14:16:56 +0200 (EET) Received: by mail-oo1-f41.google.com with SMTP id g5-20020a4ae885000000b003240bc9b2afso7352747ooe.10 for ; Mon, 14 Mar 2022 05:16:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=1/80xuXLSI3DX442NqNpT7mK2yLr/9OXZrPkwHn7y8A=; b=B6XAlct6JxnOHIUQGF6mqhdloj6NvYAM+zENU5+ML0zp+/qZIwebJYak1ZEkFrPiHZ hZWsYE1jUoG2yMZMdfQwU9poCXobQ20pYyCnq4N5qk5G5c8oWC3+LGl1ON/1HyTrxOhG dIdH9R+qF7AvwUFMSWnByaKcpj/qxQESQrd0yqUkYCroAey0IvcFGZV8UB5xww9vXWWP ScCUoZ9QjDCvfIsmt9k9OAYy8uXjgbubdXlNTfk/DF8qPMnNhYyK/LBpK5PrcTKtsVDN SzqGJI6hdaC4W2e71ZXE3rI8LRU7nhNgfccs2NL1Me2wMObv4ZiOgd/3m4HmEQjMkKgt /jHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=1/80xuXLSI3DX442NqNpT7mK2yLr/9OXZrPkwHn7y8A=; b=huMMTCc9EmtoqI/ysjg9/VHNscuf8/r8iHtnE0R+jOPhynGumaPo1yDn29e/3BcyWZ GUl07qj8JKzXD7AAhKSm7WMBEK8/OdKqtZge7+wGwwP80C+XOTJ8bl0QemYf4TG7ezxm F9FgQG4SIimHSgE629XAIW1m/sTm36nEHpJtVaczGuZrHsXEe8CpoA88cv+Lby4IWYKk s4yIa0Pq3j8d6YTOk1ihckCtPtv4uPykM+fdr8lxDqPmzgMqKhwX08I1tfN5RcrWs/Cl eDHK/N+F3H61/ruP9ctWyK2SCdC+YQCGtg9r2PEeVgR3CXxqmjinT5olWzG25sE0ajfQ ESjg== X-Gm-Message-State: AOAM5336l6iiudCI3zhLlYckGquAApW5dafpfYIVuVw2M/LlI9dOCBVl pJMhsIN1uBxkjlQ4vMOGzSQo59qkDJGYxg== X-Google-Smtp-Source: ABdhPJz6VCHGZ4hqS4PwSSrYuSrsQrL9ytIrkBaJ0gNrqgddQQOduh9l/TLKoIp96ymc/7Ji8Jph2g== X-Received: by 2002:a05:6870:600a:b0:d7:4895:75be with SMTP id t10-20020a056870600a00b000d7489575bemr11219428oaa.35.1647260214170; Mon, 14 Mar 2022 05:16:54 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id i126-20020acab884000000b002d9f958bceesm7803895oif.41.2022.03.14.05.16.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Mar 2022 05:16:53 -0700 (PDT) Message-ID: Date: Mon, 14 Mar 2022 09:17:03 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220314115602.263642-1-onemda@gmail.com> <4932f52a-3df7-525f-22cc-a5ccfa34f6e4@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add null encoders X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/14/2022 9:17 AM, Paul B Mahol wrote: > On Mon, Mar 14, 2022 at 1:12 PM James Almer wrote: > >> >> >> On 3/14/2022 8:56 AM, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> libavcodec/Makefile | 2 ++ >>> libavcodec/allcodecs.c | 2 ++ >>> libavcodec/codec_desc.c | 14 ++++++++++ >>> libavcodec/codec_id.h | 2 ++ >>> libavcodec/nullenc.c | 61 +++++++++++++++++++++++++++++++++++++++++ >>> 5 files changed, 81 insertions(+) >>> create mode 100644 libavcodec/nullenc.c >>> >>> diff --git a/libavcodec/Makefile b/libavcodec/Makefile >>> index cd929da8e6..8554b5ee7d 100644 >>> --- a/libavcodec/Makefile >>> +++ b/libavcodec/Makefile >>> @@ -542,6 +542,8 @@ OBJS-$(CONFIG_MXPEG_DECODER) += mxpegdec.o >>> OBJS-$(CONFIG_NELLYMOSER_DECODER) += nellymoserdec.o nellymoser.o >>> OBJS-$(CONFIG_NELLYMOSER_ENCODER) += nellymoserenc.o nellymoser.o >>> OBJS-$(CONFIG_NOTCHLC_DECODER) += notchlc.o >>> +OBJS-$(CONFIG_NULL_AUDIO_ENCODER) += nullenc.o >>> +OBJS-$(CONFIG_NULL_VIDEO_ENCODER) += nullenc.o >>> OBJS-$(CONFIG_NUV_DECODER) += nuv.o rtjpeg.o >>> OBJS-$(CONFIG_ON2AVC_DECODER) += on2avc.o on2avcdata.o >>> OBJS-$(CONFIG_OPUS_DECODER) += opusdec.o opus.o opus_celt.o >> opus_rc.o \ >>> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c >>> index 628d27fd75..a30920bfe2 100644 >>> --- a/libavcodec/allcodecs.c >>> +++ b/libavcodec/allcodecs.c >>> @@ -487,6 +487,8 @@ extern const AVCodec ff_mpc8_decoder; >>> extern const AVCodec ff_msnsiren_decoder; >>> extern const AVCodec ff_nellymoser_encoder; >>> extern const AVCodec ff_nellymoser_decoder; >>> +extern const AVCodec ff_null_audio_encoder; >>> +extern const AVCodec ff_null_video_encoder; >>> extern const AVCodec ff_on2avc_decoder; >>> extern const AVCodec ff_opus_encoder; >>> extern const AVCodec ff_opus_decoder; >>> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c >>> index 81f3b3c640..7d6bfd352c 100644 >>> --- a/libavcodec/codec_desc.c >>> +++ b/libavcodec/codec_desc.c >>> @@ -3516,6 +3516,20 @@ static const AVCodecDescriptor >> codec_descriptors[] = { >>> .long_name = NULL_IF_CONFIG_SMALL("AVFrame to AVPacket >> passthrough"), >>> .props = AV_CODEC_PROP_LOSSLESS, >>> }, >>> + { >>> + .id = AV_CODEC_ID_AUDIO_NULL, >>> + .type = AVMEDIA_TYPE_AUDIO, >>> + .name = "null_audio", >>> + .long_name = NULL_IF_CONFIG_SMALL("Audio NULL"), >>> + .props = AV_CODEC_PROP_LOSSY, >>> + }, >>> + { >>> + .id = AV_CODEC_ID_VIDEO_NULL, >>> + .type = AVMEDIA_TYPE_VIDEO, >>> + .name = "null_video", >>> + .long_name = NULL_IF_CONFIG_SMALL("Video NULL"), >>> + .props = AV_CODEC_PROP_LOSSY, >> >> Also AV_CODEC_PROP_INTRA_ONLY on both. >> >>> + }, >>> }; >>> >>> static int descriptor_compare(const void *key, const void *member) >>> diff --git a/libavcodec/codec_id.h b/libavcodec/codec_id.h >>> index 3ffb9bd22e..4822dc7685 100644 >>> --- a/libavcodec/codec_id.h >>> +++ b/libavcodec/codec_id.h >>> @@ -571,6 +571,8 @@ enum AVCodecID { >>> * stream (only used by libavformat) */ >>> AV_CODEC_ID_FFMETADATA = 0x21000, ///< Dummy codec for streams >> containing only metadata information. >>> AV_CODEC_ID_WRAPPED_AVFRAME = 0x21001, ///< Passthrough codec, >> AVFrames wrapped in AVPacket >>> + AV_CODEC_ID_AUDIO_NULL = 0x21002, ///< Null audio codec >>> + AV_CODEC_ID_VIDEO_NULL = 0x21003, ///< Null video codec >>> }; >>> >>> /** >>> diff --git a/libavcodec/nullenc.c b/libavcodec/nullenc.c >>> new file mode 100644 >>> index 0000000000..8d3553ed33 >>> --- /dev/null >>> +++ b/libavcodec/nullenc.c >>> @@ -0,0 +1,61 @@ >>> +/* >>> + * Copyright (c) 2022 The FFmpeg Project >>> + * >>> + * This file is part of FFmpeg. >>> + * >>> + * FFmpeg is free software; you can redistribute it and/or >>> + * modify it under the terms of the GNU Lesser General Public >>> + * License as published by the Free Software Foundation; either >>> + * version 2.1 of the License, or (at your option) any later version. >>> + * >>> + * FFmpeg is distributed in the hope that it will be useful, >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >>> + * Lesser General Public License for more details. >>> + * >>> + * You should have received a copy of the GNU Lesser General Public >>> + * License along with FFmpeg; if not, write to the Free Software >>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA >> 02110-1301 USA >>> + */ >>> + >>> +#include "libavutil/internal.h" >>> +#include "libavutil/frame.h" >>> +#include "libavutil/buffer.h" >>> + >>> +#include "avcodec.h" >>> +#include "internal.h" >>> +#include "encode.h" >>> + >>> +static int null_encoder(AVCodecContext *avctx, AVPacket *pkt, >>> + const AVFrame *frame, int *got_packet) >>> +{ >>> + int ret; >>> + >>> + pkt->pts = frame->pts; >>> + if (avctx->codec_type == AVMEDIA_TYPE_AUDIO) >>> + pkt->duration = ff_samples_to_time_base(avctx, >> frame->nb_samples); >>> + pkt->flags |= AV_PKT_FLAG_KEY; >>> + if ((ret = ff_alloc_packet(avctx, pkt, 1)) < 0) >> >> To avoid bogus statistics, could you instead allocate a blank packet of >> size av_samples_get_buffer_size()? >> Also, use ff_get_encode_buffer() and set the DR1 codec cap. >> >>> + return ret; >>> + *got_packet = 1; >>> + return 0; >>> +} >>> + >>> +const AVCodec ff_null_video_encoder = { >>> + .name = "null_video", >>> + .long_name = NULL_IF_CONFIG_SMALL("Video NULL encoder"), >>> + .type = AVMEDIA_TYPE_VIDEO, >>> + .id = AV_CODEC_ID_VIDEO_NULL, >>> + .encode2 = null_encoder, >>> + .caps_internal = FF_CODEC_CAP_INIT_THREADSAFE, >>> +}; >>> + >>> +const AVCodec ff_null_audio_encoder = { >>> + .name = "null_audio", >>> + .long_name = NULL_IF_CONFIG_SMALL("Audio NULL encoder"), >>> + .type = AVMEDIA_TYPE_AUDIO, >>> + .id = AV_CODEC_ID_AUDIO_NULL, >>> + .encode2 = null_encoder, >>> + .caps_internal = FF_CODEC_CAP_INIT_THREADSAFE, >>> + .capabilities = AV_CODEC_CAP_VARIABLE_FRAME_SIZE, >> >> What's the benefit from this? If the idea is to get rid of >> wrappedavframe, then you also need to fix vapoursync, decklink, kmsgrab, >> opengl, xv, and yuv4mpeg. >> >> I'd rather not add more fake codec ids for this purpose unless it's a >> thorough solution. >> > > See null muxer patch. null muxer does not need pcm codecs or wrapped video > codec. I saw it, hence my comment above. wrappedavframe is still used by several components, so this is adding two new pseudo codec ids but not resolving the problem wrappedavframes represents. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".