From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 06F4B48F66 for ; Mon, 1 Apr 2024 06:12:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2656768CDA6; Mon, 1 Apr 2024 09:12:09 +0300 (EEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8DC2168C4F1 for ; Mon, 1 Apr 2024 09:12:02 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711951927; x=1743487927; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=0wsY2cDy/i+mq6i32ofyWzKtq8kfA4IFAk6CZ7bxLD0=; b=bADCOrFtCK6EWhIo0htztimhHJ9oPuEy2n2+U7/Klh9y4O0Kr+6Dxqt7 ZQgBJnQYAla4Z0MDiRTFZOUNkn4PGjDlqKiL+fY5r/wQ286/4EYUuVjcw pr9upZ1E/BfYFYiiI46Cgb3RI/BMofF/yj8yKLhbVNNIOJHp4nTEphEW6 mYSEIhwj0cltPOjhWIUj/p5+0J9atqPrQJ96pCo44X+/FlTdovcrbU202 5c59bBB+zRUuoKTsQZA4fBQo1lOGvqDMFq+vWAhfxGfSDnMLa+OrOk1JJ cAr/3k5rD0g35Kd3JiUues1mHIMOMg8du4RpQyNRZpsyQT85sbhOLQF8R A==; X-CSE-ConnectionGUID: TSViYAbARo+Z5frtxUWhnw== X-CSE-MsgGUID: PRDnCJd0Th2DMtdIYBaVFA== X-IronPort-AV: E=McAfee;i="6600,9927,11030"; a="6902761" X-IronPort-AV: E=Sophos;i="6.07,171,1708416000"; d="scan'208";a="6902761" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2024 23:12:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,171,1708416000"; d="scan'208";a="22062340" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 31 Mar 2024 23:12:01 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 31 Mar 2024 23:12:00 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 31 Mar 2024 23:11:59 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 31 Mar 2024 23:11:59 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 31 Mar 2024 23:11:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=movB0t3V9DRPzVJH4b4g4MxnT2w1k6JKzBFRAqqqFC/p7Gq/zKY+Uzdb5i7mfxm+R+OzlAxRuNrsGkj5k+ay8YslcDwTYmezb0g4qA3aQSkDWrPA+AHWu9AAFBSYKJcXd83A13g3h7z5haSxNBY6gWu0VUQ3mgXejGEa4w9T6mZ1rHGq+m4gmI0ALu7xx3ZAp5dB44akdlyyqH6DgGGYcFHgrFohcJVZ3zLPymYrC9AkFEGzUtzy7Emq6KcFF2tJBqdfT2j9Bo7m/B4kMwNjlIaBm/pdib5DGzRPzgpwsD4Cowy+1awadwI/oKX5aStEQOqEbouRRpJyZaSQKqiu6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0wsY2cDy/i+mq6i32ofyWzKtq8kfA4IFAk6CZ7bxLD0=; b=Ae4hKWlL/7d66ZiiL1OyH0qLAxBk5b9gVEg1Rz0KtHGDYDyE8Md13Uo3dGHHJsmbiYWu8ee5nDg8x9f4ugZ8W7FVFEul2OOxfCNUl8rkE3RS7aiEZWcCUwolJrwmrPa+lMmrCWP4gDkPjBvLb8Fl0L2axkVH6N7zmTIJoAE0SSbG/rKpf7BNekgKOyl/7B4oMXdi1H6KOTSUEEIivEwVFWKJTFBc7dm0OAFpW0Y17GGpFedu7dC3TwQyz4udv5iSAoKTc0Kz+3RtHitJRPT5W3Bcspys/5HTHMWWmsTNekW8pztMnmYWyS4iilZnE9r6bgwFDx8t4NljSW29fRo17w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by SA3PR11MB7654.namprd11.prod.outlook.com (2603:10b6:806:305::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.24; Mon, 1 Apr 2024 06:11:48 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::566d:2e2d:1fa3:d511]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::566d:2e2d:1fa3:d511%6]) with mapi id 15.20.7409.031; Mon, 1 Apr 2024 06:11:48 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v3 2/2] lavc/vaapi_encode_h265: Set general_*_constriaint flags with profile Thread-Index: AQHaeXp5igVfhXyhtUm2DpOVNcx3wrFAUtOAgBKxRwA= Date: Mon, 1 Apr 2024 06:11:48 +0000 Message-ID: References: <20240318042111.21983-1-fei.w.wang@intel.com> <20240318042111.21983-2-fei.w.wang@intel.com> <4cdd5a84-8547-48ea-b0e5-62ca20da39a3@jkqxz.net> <2632f0803eef7becfaff4458547f967a4578a997.camel@intel.com> In-Reply-To: <2632f0803eef7becfaff4458547f967a4578a997.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5030:EE_|SA3PR11MB7654:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: J2axeDpqVg0fyFQhl2XwG3ZJKKSBcVCrQpQjwtAE4/pKOnKQIy7MjV40sHXm8adkWfRGBEmxdrR99UV8Fee/UCpEphr1hOlsP5iaZ0d6RXiUvTZZoJwfphVUU5bdw1NpOUFP9uHQemNaRn9f2K/ghPbWLR8arEmeY5VdQ9ElNyDn0itSQd03taXnhRZ2Ff64R4uBmREbjPn+rAqlneaksZ166K8Y3PqHBHApSqxnsCQXGeCikaJPm+g4IotrOTITww5sjIuA+4SnM0J+AJfm2l4cShrygUVdGdaZOegV8jqM8CFix3Ip4f9t5vkD4wHvNeBn/j7NheSrHSlasr2gGW9rVfqzeoLCHPdBuq0SggHHu+YnYIoI6aMsA5dKw+o/woaH0M6fRxDA4a2bZZZunhW1L5RM2by9gFrE6DIUq3GAjTmYEs1ljo8GPZVAGz+SE8GpspDApUNMPvZAmhbxlrGrB3lxdtYJWDm/McET9mDAW1ohzerAqi72/s6ABvLk7RRhfmP+DTBkJvGjn5kp21aXwansWKc/SncZUe/mYssI6T4kcdZdJON7B5DoKZThKBc5+UqeWPvitU7IXaevZpbyUIB1JjJbYPFNtpu/xpw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q2QwSEkybzJNaXk3ZVVNQUczNHNVZXFRT25VTGd1VDlYT1ppcTJ6c1RwalR3?= =?utf-8?B?K3NYeDRqR2s2OWU3MXlRclZkV3czK2xrNmZ0WERSblpIZjFsK1VnSGZmMFVi?= =?utf-8?B?Q1Y1ZjdHaC95ZnZTdVRrZ2wxUExwOGdFV1R1RmxtRFBlSEdna0hab04raGNi?= =?utf-8?B?RFJUdzJRWWFvVC9EQ1hzNUkrZkVObTA1aGc3OGc0cTUyYWtRditRTjY1QjNE?= =?utf-8?B?Ly83VUpZYWJUSzQwS3luUWFZUFZYMzc3VlJGZkZ1aDBIeGM2MXJhNDhmbVJ0?= =?utf-8?B?MEdwWUZRM0toWkhGVHMzTWRtdjk0VEZGUS9obDJMWTFYQVdzdDhGdmNPL1gw?= =?utf-8?B?K3hpUDgyaDFzMDNmdzJLdEJRSVpWSkpuUWVTYUIyRVVoTUxnOWJoY3c0TFBT?= =?utf-8?B?UzRQVUw2ekk5WGJEL0JicHdpdmJsdjF5bXFhczhiNnNzdHlzazRkOFlObUZW?= =?utf-8?B?TEhrNlBpb2V5eGJRbURFeWRUNko4a3NnOU5iWDdrZG5nbHpxVEVGelB1NjU1?= =?utf-8?B?cHhyWUZIbHR3dUdDMkNCZElITytaaEdVV1E2Sng5U0hhd0ljdDM4UlpBcjhs?= =?utf-8?B?V3BQckttK1IwMk5LV25CT2V4dUpRTm84Qk5aVTB6Y2d2OVlOVm9mQXN3Sm9L?= =?utf-8?B?amx0M0NraDNuaDhBSWhnTEFmOXREeUtoK2dxcEYyaGw1SDFPczd1bUtZZ1E5?= =?utf-8?B?TG5CRHFWNmVKc1pXLzVCaEtnREppemR6WlZuSWkrb0hmNmd1MFloWkpQckQ2?= =?utf-8?B?c1lZVVM5bHAwT0F2WDY5bUswZ09MdVhSZXdtTWlUU3g3ZWoycHVFeWlUL3Zr?= =?utf-8?B?TWM5cE94YmJtMno2UTJabElxVDJYQ01tMUxaOGhxVEhnWENwVWpkbWJTVlNE?= =?utf-8?B?UG5maGl6b3czRmRWM1NvdG9WZ25DeEFKQkVJamFyWk5sY1dsRmFjbElVVVBh?= =?utf-8?B?ckhMeit4bDhrSWdtdEIrS3ZCRTV1NXl6cGFFR2krenVwb1N3ejUrUWc5dy9v?= =?utf-8?B?R2ExdmhMN0RTTWJLdVlvNXhsQkU2U3Zla2Z0WEx0dnFuU0VSK3NpdjhsUGNl?= =?utf-8?B?NGgrdVhGQy91U2ZoT3dvZUQyY2V3bWZySzlwaDlyaStERTcyRzMyQ3kxbkRW?= =?utf-8?B?a3V1eGtOSGNjam8ydUVmMEVMaktwZ0xsR3dSVVpXRm4xWkprdUxFdnA2Vng3?= =?utf-8?B?bXVKeUhoUkxLVmx2czVOQmxaMSs5dWlKbUlLcVd2WDUxbEx6cmo0TXhveDV6?= =?utf-8?B?VndxdnNTYzNBM2NQUXJiU0JpRDE5MVQzWUtwZFVWZVVNTE9WN1dXMGVlemw1?= =?utf-8?B?TklmRWpndjFLdjdKZk84TEgxS1RKOHVzbTl0NzZrdHZyeGtMMTRYb24rVm9o?= =?utf-8?B?UE1YK1FJN3pTZTh4anNac1NteTVFenRwK2VhYWVlYThQN0lIeFJRL1RBTUlm?= =?utf-8?B?U1JSaWs4VGtMK0EzSjcwZ3BOS2lGYWxscVZ6T3NUUzZDaUtEb3VyVFhRWEdZ?= =?utf-8?B?MTBnZFB6QWJYcUpTeUpUYjZVN3Z1ZlNjYUdnN3pMN2xZVGxkYmlpaFB2KzFO?= =?utf-8?B?c01zU1NyM0liSnlwKzlsYytBUFZGN1JiNE9tMGhmVXdQTHl1SXpCNjNxdWNR?= =?utf-8?B?KzVQR3g2ZUhrYTFtaFpyUjZKY1d1bXNyLy91TmU3Yk15Qmx3dDA3QmFoVGdY?= =?utf-8?B?aFp3QkJwb3BqMlVBdWo1MGxsVDJSaGtVMWhvYmc4Nmp1K3hOcm1UcVFWVno3?= =?utf-8?B?L09OVXhtQWtzc2VIWkx0dFp2VW1hMUtvVkZYMnZpSzgrRFF4LzQ0TzZzRFpt?= =?utf-8?B?TU5tNm5IMFJ0UDJVaTJGQ0dMNXVlVkdPSldML1REcjR0RE9GWjUySzQ3ZG9l?= =?utf-8?B?T015VHdrcXBFbFl6U1NpYi9iUmxISndJaVI1Wi9VN09KamVjVFRDaGdINWxu?= =?utf-8?B?QWk3SUVUM05yQUREVys0MHVBdHhLaFdUaERzU3BLQUpCU3IyakQ4WHNOM0tF?= =?utf-8?B?RW5VOGY1eW1zazNnTWlJdGM3bWlaTWMvL05xK2xzdVpGUmgwMjdaR2NoYndR?= =?utf-8?B?cFFsd3g0WTlWVEFrRGJBWkU0SXNVUTdzR1dZckZMaElURlpaNjJocWxpV0ZZ?= =?utf-8?B?S1YrK1hGN2VuQlo3RFpzRG40eXE2TTl2TkJlbGh4TzJRNzVUREpnNDI2OWox?= =?utf-8?B?bHc9PQ==?= Content-ID: <1C291530F34CBB43982717EA278E8B3E@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: db2fc1ce-41ea-4022-02e7-08dc52129d5b X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2024 06:11:48.2270 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I+8qYco/J3P6o9CVjwRecys6uk2PLc6Jjs8m/StUq2gN3dMIxKPbPelcLdWFj6qRHJLV9EQkoPbLEPCYMsarlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7654 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/vaapi_encode_h265: Set general_*_constriaint flags with profile X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 2024-03-20 at 16:44 +0800, Fei Wang wrote: > On Mon, 2024-03-18 at 21:22 +0000, Mark Thompson wrote: > > On 18/03/2024 04:21, fei.w.wang-at-intel.com@ffmpeg.org wrote: > > > From: Fei Wang > > > > > > According to Table A.2 in spec. > > > > > > Signed-off-by: Fei Wang > > > --- > > > libavcodec/vaapi_encode_h265.c | 176 +++++++++++++++++++++++--- > > > -- > > > ----- > > > 1 file changed, 123 insertions(+), 53 deletions(-) > > > > > > diff --git a/libavcodec/vaapi_encode_h265.c > > > b/libavcodec/vaapi_encode_h265.c > > > index 43755e2188..5ed317ce11 100644 > > > --- a/libavcodec/vaapi_encode_h265.c > > > +++ b/libavcodec/vaapi_encode_h265.c > > > @@ -258,6 +258,124 @@ fail: > > > return err; > > > } > > > > > > +static int vaapi_encode_h265_init_ptl(AVCodecContext *avctx) > > > +{ > > > + VAAPIEncodeContext *ctx = avctx->priv_data; > > > + VAAPIEncodeH265Context *priv = avctx->priv_data; > > > + H265RawVPS *vps = &priv->raw_vps; > > > + H265RawProfileTierLevel *ptl = &vps->profile_tier_level; > > > + > > > + ptl->general_profile_space = 0; > > > + ptl->general_profile_idc = avctx->profile; > > > + ptl->general_tier_flag = priv->tier; > > > + > > > + ptl->general_profile_compatibility_flag[ptl- > > > > general_profile_idc] = 1; > > > + > > > + if (ptl->general_profile_compatibility_flag[1]) > > > + ptl->general_profile_compatibility_flag[2] = 1; > > > + if (ptl->general_profile_compatibility_flag[3]) { > > > + ptl->general_profile_compatibility_flag[1] = 1; > > > + ptl->general_profile_compatibility_flag[2] = 1; > > > + } > > > + > > > + ptl->general_progressive_source_flag = 1; > > > + ptl->general_interlaced_source_flag = 0; > > > + ptl->general_non_packed_constraint_flag = 1; > > > + ptl->general_frame_only_constraint_flag = 1; > > > + > > > + if (avctx->profile >= 4) { > > > + ptl->general_intra_constraint_flag = ctx- > > > > gop_size == 1; > > > + ptl->general_one_picture_only_constraint_flag = 0; > > > + ptl->general_lower_bit_rate_constraint_flag = 1; > > > + ptl->general_max_14bit_constraint_flag = 0; > > > + > > > + switch (ctx->va_profile) { > > > +#if VA_CHECK_VERSION(1, 2, 0) > > > + case VAProfileHEVCMain12: > > > + // Main 12 > > > + ptl->general_max_12bit_constraint_flag = 1; > > > + ptl->general_max_10bit_constraint_flag = 0; > > > + ptl->general_max_8bit_constraint_flag = 0; > > > + ptl->general_max_422chroma_constraint_flag = 1; > > > + ptl->general_max_420chroma_constraint_flag = 1; > > > + ptl->general_max_monochrome_constraint_flag = 0; > > > + break; > > > + case VAProfileHEVCMain422_10: > > > + // Main 4:2:2 10 > > > + ptl->general_max_12bit_constraint_flag = 1; > > > + ptl->general_max_10bit_constraint_flag = 1; > > > + ptl->general_max_8bit_constraint_flag = 0; > > > + ptl->general_max_422chroma_constraint_flag = 1; > > > + ptl->general_max_420chroma_constraint_flag = 0; > > > + ptl->general_max_monochrome_constraint_flag = 0; > > > + break; > > > + case VAProfileHEVCMain422_12: > > > + // Main 4:2:2 12 > > > + ptl->general_max_12bit_constraint_flag = 1; > > > + ptl->general_max_10bit_constraint_flag = 0; > > > + ptl->general_max_8bit_constraint_flag = 0; > > > + ptl->general_max_422chroma_constraint_flag = 1; > > > + ptl->general_max_420chroma_constraint_flag = 0; > > > + ptl->general_max_monochrome_constraint_flag = 0; > > > + break; > > > + case VAProfileHEVCMain444: > > > + // Main 4:4:4 > > > + ptl->general_max_12bit_constraint_flag = 1; > > > + ptl->general_max_10bit_constraint_flag = 1; > > > + ptl->general_max_8bit_constraint_flag = 1; > > > + ptl->general_max_422chroma_constraint_flag = 0; > > > + ptl->general_max_420chroma_constraint_flag = 0; > > > + ptl->general_max_monochrome_constraint_flag = 0; > > > + break; > > > + case VAProfileHEVCMain444_10: > > > + // Main 4:4:4 10 > > > + ptl->general_max_12bit_constraint_flag = 1; > > > + ptl->general_max_10bit_constraint_flag = 1; > > > + ptl->general_max_8bit_constraint_flag = 0; > > > + ptl->general_max_422chroma_constraint_flag = 0; > > > + ptl->general_max_420chroma_constraint_flag = 0; > > > + ptl->general_max_monochrome_constraint_flag = 0; > > > + break; > > > + case VAProfileHEVCMain444_12: > > > + // Main 4:4:4 12 > > > + ptl->general_max_12bit_constraint_flag = 1; > > > + ptl->general_max_10bit_constraint_flag = 0; > > > + ptl->general_max_8bit_constraint_flag = 0; > > > + ptl->general_max_422chroma_constraint_flag = 0; > > > + ptl->general_max_420chroma_constraint_flag = 0; > > > + ptl->general_max_monochrome_constraint_flag = 0; > > > + break; > > > +#endif > > > + default: > > > + av_log(avctx, AV_LOG_ERROR, "Unknown profile to init > > > PTL.\n"); > > > + return AVERROR(EINVAL); > > > + } > > > + } > > > > Why is this an improvement over the current code which sets the > > constraint flags based on the actual content of the stream? > > > > Note the requirement in A.3.5 for decoder support: > > > > general_profile_idc is equal to 4 or > > general_profile_compatibility_flag[ 4 ] is equal to 1 for the > > bitstream, and > > the value of each constraint flag listed in Table A.2 is greater > > than > > or equal to the value(s) specified in the row > > of Table A.2 for the format range extensions profile for which the > > decoder conformance is evaluated. > > > > which says that decoders must be able to support streams which set > > additional constraint flags beyond those which are specified for a > > particular profile (in particular, an 8-bit 4:2:2 stream must be > > decodable by any decoder supporting either "Main 4:2:2 10" or "Main > > 4:4:4", so ideally it shouldn't be marked to require one of those > > in > > particular). > > That's a capability request for decoder. For encoder side, I'd prefer > to use the most typical values. The constraint flags in Table A.2/3/5 > are strictly checked to get rext profile in ff_h265_get_profile(), > and > seems the constraint flags is the only way to distinguish profiles in > rext(all the rext profiles shares same general_profile_idc or > general_profile_compatibility_flag[ 4 ]). Hi Mark, Any other comments on this patchset? Thanks Fei > > Thanks > Fei > > > Thanks, > > > > - Mark > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".