From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EFB194A19B for ; Sat, 22 Jun 2024 06:27:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 23D8368D926; Sat, 22 Jun 2024 09:27:11 +0300 (EEST) Received: from mail-ua1-f45.google.com (mail-ua1-f45.google.com [209.85.222.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4664868D8E0 for ; Sat, 22 Jun 2024 09:27:05 +0300 (EEST) Received: by mail-ua1-f45.google.com with SMTP id a1e0cc1a2514c-80f59d820adso659084241.0 for ; Fri, 21 Jun 2024 23:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719037623; x=1719642423; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=lwcz+G8XubTXctIAyaWzwXLBtUNRNAY2Ak2IIVLnwFE=; b=WWBVqfYST4JUrK1sdbYSc/dy68d9dhwSALGqnPkwvBAh+XuE7vtxx5YaYx31x8Dr6L GjQARLMvljrGIUC5nB9qw/fYjlZcK8uaKGUI9SwY7XWbIkywE+VjDNlw77FOM+JJE+ea OF4QvLNaHaxT2mjiETX9gSqX9JZfaDSrHnpnG8TGMZJQlqK+7v9BpUg3WYF76/ISraN2 /ffdLGs0fLHfgBmxeLXaU6CG+yDtcldmq/onx69F1An8KJOqlo7akiZOki4SPngfBECT WUi10WQWROik5BLjhDlka2RxyIhccvgPvztbCSM9wPwUQuNU3J9Ga1kZtCL94hDSEKnr xPLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719037623; x=1719642423; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lwcz+G8XubTXctIAyaWzwXLBtUNRNAY2Ak2IIVLnwFE=; b=btiqzlR1c8nwgGKhrXUAl9tNsCtFew/vD9a3QkFyrVzts/N6HdXfp2WF22GfG7T1rQ QfMfuODxBaaARmhtk7f6Hqif8Pva0sIeqv761OYXhYiAMcRVn1SMU9plmLGWUrgaI/u7 ljt7tIcNLBmsfAGBQBP8K6PEZ8uCpeqokkyybj0Gsf6FGMRJ6zvW3XNsLd4+n+9IttPy iezZKaGhG5rGatJwWDatNRgIkBOV0Q+Zw5X2sxQ730CvlP0NyHcPVJcStbIVVly/lL1d LihECj+tNrJZyLKR56d4LeyQ+922WjYt4+swzu8j1lm0Sklk4+kZyNXBWhPYEK60h9sl 0d6w== X-Gm-Message-State: AOJu0YzugPhEo/HYX7v9jafewb2vHi8q68nxhK0gmIcRbQx7MwbxPzWA +xw4uPODUQzWwJGRjIzxnxm/ePkYehkPJ+B3zS5eYyyE/zJKi2ednrO87w== X-Google-Smtp-Source: AGHT+IHzSEa7yLHO9VSF1gCJp46R1RPCXaVvmOQ5/XVqEtAgR6KGZwPKRzLwiS8IhGXoj5A/wycQiw== X-Received: by 2002:a05:6102:2a46:b0:48f:3adb:dc1b with SMTP id ada2fe7eead31-48f3adbde23mr3264788137.25.1719037623105; Fri, 21 Jun 2024 23:27:03 -0700 (PDT) Received: from [192.168.1.20] (syn-173-170-140-230.res.spectrum.com. [173.170.140.230]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-80f729bf648sm499890241.37.2024.06.21.23.27.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jun 2024 23:27:02 -0700 (PDT) Message-ID: Date: Sat, 22 Jun 2024 02:27:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Stephen Hutchinson In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] libavformat/vapoursynth: Update to API version 4, load library at runtime X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/21/24 9:37 PM, Stefan Oltmanns via ffmpeg-devel wrote: > The current VapourSynth implementation is rarely used, as it links the > VapourSynth library at build time, making the resulting build unable to > run when VapourSynth is not installed. Therefore barely anyone compiles > with VapourSynth activated. > How many distros package VapourSynth yet don't enable it in FFmpeg vs. both not packaging it and not enabling it? VapourSynth not being available as a package in the distro's repository is a far more likely reason than linking is. Switching to dynamic loading would absolutely make the experience on or building for Windows smoother, and would remove the need to rebuild FFmpeg when VapourSynth updates, outside of future API changes the demuxer would need to actively account for. > I changed it, so that it loads the library at runtime when a VapourSynth > script should be opened, just like AviSynth does. > On Windows the DLL from VapourSynth is not installed in the system > directory, but the location is stored in the Registry. Therefore I added > some code to read that information from the registry. > That function is in the wrong place. > I copied the two needed header files directly in a vapoursynth.h, > removing the need to install VapourSynth on the build machine > (VapourSynth is also LGPL 2.1 or later, so no license issue). I updated > the configure so that it checks for the ability to load libraries at > runtime for VapourSynth, just like AviSynth and activate it if not > disabled. > Including local copies of the headers in compat/ wasn't acceptable for AviSynth (and were removed as soon as it was no longer necessary for there to be an OS distinction between what headers were being used), it's not going to be acceptable for this either. And setting it up as autodetect seems like overreach. I don't know if there's any actual written rule about which libraries to autodetect and which ones require explicit enabling, but most of the autodetected ones thus far appear to be OS-level or otherwise foundational libraries, not libraries for a singular media format. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".