From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id C88904EF92 for ; Thu, 15 May 2025 13:11:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 9045168BDE5; Thu, 15 May 2025 16:11:21 +0300 (EEST) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 04AE168BDE5 for ; Thu, 15 May 2025 16:11:14 +0300 (EEST) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-ad243b49ef1so178824866b.0 for ; Thu, 15 May 2025 06:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resolume-com.20230601.gappssmtp.com; s=20230601; t=1747314674; x=1747919474; darn=ffmpeg.org; h=mime-version:user-agent:references:in-reply-to:date:to:from:subject :message-id:from:to:cc:subject:date:message-id:reply-to; bh=s2/3ZxLbr9VlxwVOjPB0Fnfqd+pO2vlr+cbnSq4sSnQ=; b=W2PmgmVLlL6XSlT+Cn2HS+7rt+T/fgs9md7gZ/lIrqc9ueLlL/sSkTBINLy7lf0hCK 3Rc/ETrXDobGlxug5T+2y3R3okcXl1/+tIjJXfCp04i7xv0QfSVFyp/47XGRg3xMnfMk wJba3KH+QbSYmaM/y3XzeGZacXdk1yp/UmKP2yzocSfWVvxDqjxadLimt79EN7D7yq2D fQ7K4R3rtRnp4S/Yzp1bY3crzbmzcubuVQFL6XSBpOPthB7+dTfDXVVWNp4e6rvVJXiL xu6yS0E43LjAEHXnqOBMpjiYgyqkGYPHakRLIY+xTQW3WMmmLTl9nsK+PaHob/isg3SK W8iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747314674; x=1747919474; h=mime-version:user-agent:references:in-reply-to:date:to:from:subject :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s2/3ZxLbr9VlxwVOjPB0Fnfqd+pO2vlr+cbnSq4sSnQ=; b=mDpoQmSRgJeuZ7Dljhko0cVG33PwzHYBUaj6X8yri051AK+Ucm+vPL+6lkHMIhoOuN xnLX3aiLFYAaX/LZERwa3N3fvGDu3YZwVc895nEIC5r0pxgUbrg1vBMo19Mpa7jzXPIc Wk73wMrUhQ2saEMWaUDu3tkRnssCkZVcrPz1tMWTXZcyYV37yBIFvrNwfzAjGn3FeVjK 8HZAotGsbn2GnJ8pFqLY1InF0KZwI67KoYK7T/QJN4BbffZCB33RW7DY0n/aPer4V8Ui /E1GvYf/cwDoTq+VtxXTyfeA8QNolveR/TjBiIkp4rmu2NOAN0pWUWVDYYjai0KmuER0 FnnA== X-Gm-Message-State: AOJu0YwhL0sQBGBXqJu+vaNHsFt88eY9pMUxxx01xG3v53848//HP6k+ tm3fuzSpM5Z65Dm+J8v3BKHgxGOB9tJvjodCd0U8LhwMK5yKYVVXtwRRjt+wDGkoYf7kS7/MiqH n X-Gm-Gg: ASbGncsBy8Wn3v31j91qxKwi9fcNPtEs+oGrpTra5fkQR6uhUEpLBcJTMTyNyj4npHi O0ORcGad0089PbkElwcYH26XwkI5A+CeGrGZlDk9grA6EWLWvfa1iFt5m4/BzDaTZVkeNmcNJg+ fQgCQwqcJpJKZOD2yJQAAGGWKKCq7hbj1pJNjANcj3F1/EMVb/RRgN2eEkPnk6hU8BtJkN9UCwa pxqbgo5TBNZiD/DdbI7P0eOWcyDPiq9QK6FLbByeZJ5l4YI8fWDOLClPrXD79uSmvdq4ABH2fLO V9uuYSf/xnOfE5K69M3UBQpVJUCGjkfa6NrkLNKpQR91qeRiLg2SnjeAOHn7hqYS0acVoOo3WiM y3OnjwfsY X-Google-Smtp-Source: AGHT+IFxp1qLwbP512oN37zSJqbuYNt/rYR1DGxj4vWHbVu5xOxqTbgckqE2561TYODQNR+6cQgikw== X-Received: by 2002:a17:906:99cf:b0:ad2:4cac:46f0 with SMTP id a640c23a62f3a-ad515e6b07bmr196694366b.32.1747314673832; Thu, 15 May 2025 06:11:13 -0700 (PDT) Received: from resolume-desktop.fritz.box ([2a10:3781:2681:1:7b9a:fa9d:a633:71a0]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad21f2145d6sm1071789966b.95.2025.05.15.06.11.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 May 2025 06:11:13 -0700 (PDT) Message-ID: From: Martijn Otto To: FFmpeg development discussions and patches Date: Thu, 15 May 2025 15:11:12 +0200 In-Reply-To: References: Content-Type: multipart/mixed; boundary="=-0bZP2M2jmXAnvHaNn12/" User-Agent: Evolution 3.56.1-1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] Patch: avformat_index_get_entry and avformat_index_get_entry_from_timestamp const correctness X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --=-0bZP2M2jmXAnvHaNn12/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2025-05-15 at 14:44 +0200, Andreas Rheinhardt wrote: > Martijn Otto: > > =C2=A0static av_always_inline const FFStream *cffstream(const AVStream > > *st) > > =C2=A0{ > > -=C2=A0=C2=A0=C2=A0 return (FFStream*)st; > > +=C2=A0=C2=A0=C2=A0 return (const FFStream*)st; > > =C2=A0} >=20 > Your patch should be applied on top of git master, not some old > version. > The above change is identical to > 185d0acdc7a67b7d3d78d4c917334c4c3bf9accd. >=20 > Anyway, I remember that someone (IIRC Anton Khirnov) objected to the > const when this was introduced. >=20 > - Andreas >=20 > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >=20 > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org=C2=A0with subject "unsubscribe". I've updated the patch to apply to latest master, I've made it quite some time in the past, and something went wrong with my submission then. I'm curious to hear what the arguments against these functions taking a const-qualified stream are, given that we return a const-value and don't modify it at all. --=-0bZP2M2jmXAnvHaNn12/ Content-Disposition: attachment; filename*0=0001-avformat_index_get_entry-and-_from_timestamp-const-c.pat; filename*1=ch Content-Type: text/x-patch; name="0001-avformat_index_get_entry-and-_from_timestamp-const-c.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAwYzhmNTg3MzM2NmU3NzIxMjkyMDA3YmNhNjQ0ZmY1Y2MzMTJkZjJiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aWpuIE90dG8gPG1hcnRpam5AcmVzb2x1bWUuY29tPgpE YXRlOiBUaHUsIDE1IE1heSAyMDI1IDE1OjA2OjUyICswMjAwClN1YmplY3Q6IFtQQVRDSF0gVGhl c2UgZnVuY3Rpb25zIGRvbid0IG5lZWQgYSBtdXRhYmxlIHBvaW50ZXIgdG8gdGhlIHN0cmVhbSwK IGFzIHRoZXkgZG9uJ3QgbW9kaWZ5IGFueXRoaW5nLCBhbmQgb25seSByZXR1cm4gY29uc3QtcXVh bGlmaWVkIHBvaW50ZXJzCiB0aGVtc2VsdmVzLgoKLS0tCiBsaWJhdmZvcm1hdC9hdmZvcm1hdC5o IHwgNCArKy0tCiBsaWJhdmZvcm1hdC9zZWVrLmMgICAgIHwgOCArKysrLS0tLQogMiBmaWxlcyBj aGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGli YXZmb3JtYXQvYXZmb3JtYXQuaCBiL2xpYmF2Zm9ybWF0L2F2Zm9ybWF0LmgKaW5kZXggNDk4YzMw MjBhNS4uNWEwYWEzZjg3ZCAxMDA2NDQKLS0tIGEvbGliYXZmb3JtYXQvYXZmb3JtYXQuaAorKysg Yi9saWJhdmZvcm1hdC9hdmZvcm1hdC5oCkBAIC0yNzUxLDcgKzI3NTEsNyBAQCBpbnQgYXZmb3Jt YXRfaW5kZXhfZ2V0X2VudHJpZXNfY291bnQoY29uc3QgQVZTdHJlYW0gKnN0KTsKICAqICAgICAg IHVudGlsIGFueSBmdW5jdGlvbiB0aGF0IHRha2VzIHRoZSBzdHJlYW0gb3IgdGhlIHBhcmVudCBB VkZvcm1hdENvbnRleHQKICAqICAgICAgIGFzIGlucHV0IGFyZ3VtZW50IGlzIGNhbGxlZC4KICAq LwotY29uc3QgQVZJbmRleEVudHJ5ICphdmZvcm1hdF9pbmRleF9nZXRfZW50cnkoQVZTdHJlYW0g KnN0LCBpbnQgaWR4KTsKK2NvbnN0IEFWSW5kZXhFbnRyeSAqYXZmb3JtYXRfaW5kZXhfZ2V0X2Vu dHJ5KGNvbnN0IEFWU3RyZWFtICpzdCwgaW50IGlkeCk7CiAKIC8qKgogICogR2V0IHRoZSBBVklu ZGV4RW50cnkgY29ycmVzcG9uZGluZyB0byB0aGUgZ2l2ZW4gdGltZXN0YW1wLgpAQCAtMjc2OCw3 ICsyNzY4LDcgQEAgY29uc3QgQVZJbmRleEVudHJ5ICphdmZvcm1hdF9pbmRleF9nZXRfZW50cnko QVZTdHJlYW0gKnN0LCBpbnQgaWR4KTsKICAqICAgICAgIHVudGlsIGFueSBmdW5jdGlvbiB0aGF0 IHRha2VzIHRoZSBzdHJlYW0gb3IgdGhlIHBhcmVudCBBVkZvcm1hdENvbnRleHQKICAqICAgICAg IGFzIGlucHV0IGFyZ3VtZW50IGlzIGNhbGxlZC4KICAqLwotY29uc3QgQVZJbmRleEVudHJ5ICph dmZvcm1hdF9pbmRleF9nZXRfZW50cnlfZnJvbV90aW1lc3RhbXAoQVZTdHJlYW0gKnN0LAorY29u c3QgQVZJbmRleEVudHJ5ICphdmZvcm1hdF9pbmRleF9nZXRfZW50cnlfZnJvbV90aW1lc3RhbXAo Y29uc3QgQVZTdHJlYW0gKnN0LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaW50NjRfdCB3YW50ZWRfdGltZXN0YW1wLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50 IGZsYWdzKTsKIC8qKgpkaWZmIC0tZ2l0IGEvbGliYXZmb3JtYXQvc2Vlay5jIGIvbGliYXZmb3Jt YXQvc2Vlay5jCmluZGV4IGMwZDk0MzcxZTYuLjIzMDg2NjA2MzggMTAwNjQ0Ci0tLSBhL2xpYmF2 Zm9ybWF0L3NlZWsuYworKysgYi9saWJhdmZvcm1hdC9zZWVrLmMKQEAgLTI1NCwyMCArMjU0LDIw IEBAIGludCBhdmZvcm1hdF9pbmRleF9nZXRfZW50cmllc19jb3VudChjb25zdCBBVlN0cmVhbSAq c3QpCiAgICAgcmV0dXJuIGNmZnN0cmVhbShzdCktPm5iX2luZGV4X2VudHJpZXM7CiB9CiAKLWNv bnN0IEFWSW5kZXhFbnRyeSAqYXZmb3JtYXRfaW5kZXhfZ2V0X2VudHJ5KEFWU3RyZWFtICpzdCwg aW50IGlkeCkKK2NvbnN0IEFWSW5kZXhFbnRyeSAqYXZmb3JtYXRfaW5kZXhfZ2V0X2VudHJ5KGNv bnN0IEFWU3RyZWFtICpzdCwgaW50IGlkeCkKIHsKLSAgICBjb25zdCBGRlN0cmVhbSAqY29uc3Qg c3RpID0gZmZzdHJlYW0oc3QpOworICAgIGNvbnN0IEZGU3RyZWFtICpjb25zdCBzdGkgPSBjZmZz dHJlYW0oc3QpOwogICAgIGlmIChpZHggPCAwIHx8IGlkeCA+PSBzdGktPm5iX2luZGV4X2VudHJp ZXMpCiAgICAgICAgIHJldHVybiBOVUxMOwogCiAgICAgcmV0dXJuICZzdGktPmluZGV4X2VudHJp ZXNbaWR4XTsKIH0KIAotY29uc3QgQVZJbmRleEVudHJ5ICphdmZvcm1hdF9pbmRleF9nZXRfZW50 cnlfZnJvbV90aW1lc3RhbXAoQVZTdHJlYW0gKnN0LAorY29uc3QgQVZJbmRleEVudHJ5ICphdmZv cm1hdF9pbmRleF9nZXRfZW50cnlfZnJvbV90aW1lc3RhbXAoY29uc3QgQVZTdHJlYW0gKnN0LAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgaW50NjRfdCB3YW50ZWRfdGltZXN0YW1wLAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50IGZsYWdzKQogewotICAgIGNvbnN0 IEZGU3RyZWFtICpjb25zdCBzdGkgPSBmZnN0cmVhbShzdCk7CisgICAgY29uc3QgRkZTdHJlYW0g KmNvbnN0IHN0aSA9IGNmZnN0cmVhbShzdCk7CiAgICAgaW50IGlkeCA9IGZmX2luZGV4X3NlYXJj aF90aW1lc3RhbXAoc3RpLT5pbmRleF9lbnRyaWVzLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHN0aS0+bmJfaW5kZXhfZW50cmllcywKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB3YW50ZWRfdGltZXN0YW1wLCBmbGFncyk7Ci0tIAoyLjQ3 LjIKCg== --=-0bZP2M2jmXAnvHaNn12/ Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --=-0bZP2M2jmXAnvHaNn12/--