From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5F6694397A for ; Thu, 4 Aug 2022 07:46:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1D38B68B898; Thu, 4 Aug 2022 10:46:24 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 15BF868B830 for ; Thu, 4 Aug 2022 10:46:16 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 2747k6mo017689-2747k6mp017689; Thu, 4 Aug 2022 10:46:06 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 5E5FAA146B; Thu, 4 Aug 2022 10:46:06 +0300 (EEST) Date: Thu, 4 Aug 2022 10:46:05 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Hubert Mazur In-Reply-To: <20220725111208.43542-1-hum@semihalf.com> Message-ID: References: <20220715080228.686736-2-hum@semihalf.com> <20220725111208.43542-1-hum@semihalf.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH] lavc/aarch64: Add neon implementation for sse16 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: gjb@semihalf.com, upstream@semihalf.com, jswinney@amazon.com, ffmpeg-devel@ffmpeg.org, mw@semihalf.com, spop@amazon.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 25 Jul 2022, Hubert Mazur wrote: > Provide neon implementation for sse16 function. > > Performance comparison tests are shown below. > - sse_0_c: 273.0 > - sse_0_neon: 48.2 > > Benchmarks and tests run with checkasm tool on AWS Graviton 3. > > Signed-off-by: Hubert Mazur > --- > libavcodec/aarch64/me_cmp_init_aarch64.c | 4 ++ > libavcodec/aarch64/me_cmp_neon.S | 82 ++++++++++++++++++++++++ > 2 files changed, 86 insertions(+) > +// iterate by one > +2: > + > + ld1 {v0.16b}, [x1], x3 // Load pix1 > + ld1 {v1.16b}, [x2], x3 // Load pix2 > + > + uabd v30.16b, v0.16b, v1.16b > + umull v29.8h, v0.8b, v1.8b > + umull2 v28.8h, v0.16b, v1.16b This should probably be using v30 instead of v0/v1 in the umull here. The whole codepath for non-modulo-4 heights is untested in practice. You can apply the patches from https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=7028 to make checkasm test it, so please make sure that the uncommon codepaths in the patches do work too. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".