From: Leo Izen <leo.izen@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v1 1/2] lavc/vp9: set yuvj pixel format for full range decode
Date: Sun, 18 Jun 2023 17:21:38 -0400
Message-ID: <a5a29982-c12e-1611-7f36-6ffc2ac1772e@gmail.com> (raw)
In-Reply-To: <aa71eb47-6c18-b531-a463-93120501823d@mail.de>
On 6/17/23 10:26, Thilo Borgmann wrote:
> Am 17.06.23 um 16:02 schrieb Leo Izen:
>> On 6/17/23 04:11, Thilo Borgmann wrote:
>>> While the yuvj pixel formats are deprecated lots of code still relies
>>> on them to be set. Without setting a yuvj420p pixel format VP9
>>> decoding ends up incorrectly due to auto conversion.
>>>
>>
>> I oppose this on principle. If there's code that relies on YUVJ being
>> set, then *that code* needs to be changed so it respects the
>> AVFrame->color_range field. Which code is working improperly with this?
>
> I don't like adding YUVJ stuff either. If I do
>
> ./ffmpeg -i full-range-in.mp4 -c:v libvpx-vp9 -lossless 1
> lossless-out.mp4
>
> and then comparing the frames, they are not equal. E.g. by
>
> ./ffmpeg -i full-range-in.mp4 -i lossless-out.mp4 -filter_complex ssim
> -f crc -
>
> they are not 1.0 in ssim terms.
>
Are you sure? I just tested a sample and found that I got exactly 1.0 in
ssim terms. Do you have a link to a sample for which this fails?
- Leo Izen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-18 21:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-17 8:11 Thilo Borgmann
2023-06-17 8:11 ` [FFmpeg-devel] [PATCH v1 2/2] lavc/libvpxenc: support creating full range output Thilo Borgmann
2023-06-18 0:03 ` James Zern
2023-06-18 7:31 ` Thilo Borgmann
2023-06-17 11:40 ` [FFmpeg-devel] [PATCH v1 1/2] lavc/vp9: set yuvj pixel format for full range decode Paul B Mahol
2023-06-17 11:46 ` Thilo Borgmann
2023-06-17 11:53 ` Paul B Mahol
2023-06-17 12:00 ` Thilo Borgmann
2023-06-17 14:02 ` Leo Izen
2023-06-17 14:26 ` Thilo Borgmann
2023-06-17 14:48 ` Leo Izen
2023-06-18 21:21 ` Leo Izen [this message]
2023-06-19 8:14 ` Thilo Borgmann
2023-06-19 15:35 ` Leo Izen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5a29982-c12e-1611-7f36-6ffc2ac1772e@gmail.com \
--to=leo.izen@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git