From: Mark Thompson <sw@jkqxz.net>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/7] avformat/apvenc: Only allow APV
Date: Sun, 27 Apr 2025 20:41:20 +0100
Message-ID: <a51b592d-eaab-417f-9ae6-21da1c0d17f5@jkqxz.net> (raw)
In-Reply-To: <GV1P250MB0737F0E6261E13C3667C923B8F862@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
On 27/04/2025 19:42, Andreas Rheinhardt wrote:
> Patches attached.
>
> - Andreas
> [PATCH 1/7] avformat/apvenc: Only allow APV
Oops, sure.
> [PATCH 2/7] avformat/apvenc: Remove unused header
Sure.
> [PATCH 3/7] avformat/apvdec: Use ffio_read_size()
Is there a cleaner way to discard very short files without reading them? The minimum size of a valid is significantly larger than this, and an early failure would be nice rather than it get packetised and something later has to realise it's bad.
> [PATCH 4/7] avformat/apvdec: Remove inappropriate flags
What does the GENERIC_INDEX flag affect here?
Currently mpv does successfully seek in a raw file (to already-seen places), but this may or may not be related.
> [PATCH 5/7] avformat/apvenc: Add AVFMT_NOTIMESTAMPS flag
Sure.
> [PATCH 6/7] avcodec/apv_decode: Fix shadowing
Ambivalent about whether this is an improvement, but no objection.
> [PATCH 7/7] avcodec/apv_decode: Remove redundant log message
Sure.
Thanks,
- Mark
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-04-27 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-27 18:42 Andreas Rheinhardt
2025-04-27 19:41 ` Mark Thompson [this message]
2025-04-27 20:48 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a51b592d-eaab-417f-9ae6-21da1c0d17f5@jkqxz.net \
--to=sw@jkqxz.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git