From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id F06794CE78 for <ffmpegdev@gitmailbox.com>; Sat, 15 Mar 2025 02:15:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 140F168E316; Sat, 15 Mar 2025 04:15:04 +0200 (EET) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EAF5A68E16D for <ffmpeg-devel@ffmpeg.org>; Sat, 15 Mar 2025 04:14:57 +0200 (EET) Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5e5cded3e2eso4127436a12.0 for <ffmpeg-devel@ffmpeg.org>; Fri, 14 Mar 2025 19:14:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742004897; x=1742609697; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=v7MFHHs7TCH0jYbb39k/y1D/Dhu/z4GvdPGitwpEmzA=; b=ZB9J7o4abqyMqTGRhh0t71V7is+3c90YwpZdmVEZT65yBhpvKPJL2ob8NcnySG8Tpi zJTMn3YQAf/RNte+tK3s7/CHVHWQZ6RNNhZwVqnetV8qAMrg7mIaSQyuBeaDdB+u20XQ Fkp+k3EUXL6USJ4NSB0qPdvIycJwr7ME8UVu4CN2ICy9W/x2Yn0fZjFZYM7h4HaNMjFl nq/HL4G32rb0NwlzApN9xxcHXopg319bOJnZtO9cs9xQkomCLbObh4k7bpUf3oezSq+v hauYqQmquNvRqnOSeno0Jov1NzkwQf4cdi5WMx7pEiuJSFzQ4sw8bBg7EBweNa231IXE p5aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742004897; x=1742609697; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v7MFHHs7TCH0jYbb39k/y1D/Dhu/z4GvdPGitwpEmzA=; b=VjYrxylCiZ/WigcZ/X/u2jxUYSLn3QpZJtY3fQlODN6M6slCuR7Fz8vkxsIn4qmhJj 2Xw45shhDtC739cyq+wQCOQLZD69Cl+iyPmCPlZWvydia+Oisbvynoci+PUT0eUg2FMl lsuYjh9xrmQqrYPArc+qvmgHHGEhf0Kr/xXhUmw4+cfMGtvoLVmhoeUnZ88x5ij5euxo tLq9r6DND7x82ngIXINimKoWy47g06bkPb24KJEYT631w9IZlySt9z8fXLTvCyEia52r D7B6ogpO9zxa1RuNRD1hI6Umm+b+Bkb7x5kBweYMTdDDUBdeH99BXCPH9SHvbFHaLect Z2dQ== X-Gm-Message-State: AOJu0Yxg74MjPMwEIUh8tOSj/BVL+WFBRfybfnhjnOeWEQjoHvSD71xV fWLBW+ix6whS0N+xeMPbohBDOvoh5e/JB66QzV2gdRyNz0vqxtzV/x7wSAR5 X-Gm-Gg: ASbGncvFkhAaJuKMJsMeD1TdI5Yw1SBbuGzy9IoH0jC1IxQux1TmN5QwVxY7gJT0207 TNO7izDiFZSN1H60lARReUeU+wtK8ptMqheUG0yFzbkxpPLeS4SnyO5CTHBKsTNKTVMNu3vDufV DKd1HptA7dYHr2CpA70sRD3VT+0j46htXRoRPFmx29Jd6oAkwDEYubgb2Q1QHTu2KBEcoHoHp10 E+la+FY+Pdv8vW4vHU4/Qxtv8Pj1Y43z8lJ6AxyssBsyi+mARuqzhlmMh5+BP1FMKcpHE2Whl0s t8u58twlA2u+IlHJZ8L1y1xxm6GSwdq2EB4z/6N0FxJRvL7HkkxTaFfRO5cMlucOqgUT1HcUryM IDoc9ghCU7Hb28u4W X-Google-Smtp-Source: AGHT+IFccpO/+hcQSvzlPbQCmt860Bwqfn+PLh7di1nHV6o5i/Xji63Lu05q1TPBuVZs6y2pIClDLw== X-Received: by 2002:a17:907:6ea9:b0:ac0:f164:31cc with SMTP id a640c23a62f3a-ac330129ef3mr584007066b.8.1742004896444; Fri, 14 Mar 2025 19:14:56 -0700 (PDT) Received: from [192.168.1.42] (20.238-74-193.fia-dyn.isp.proximus.be. [193.74.238.20]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac314a9b4easm299947966b.161.2025.03.14.19.14.54 for <ffmpeg-devel@ffmpeg.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Mar 2025 19:14:54 -0700 (PDT) Message-ID: <a507a648-2d97-422d-8a5a-4ee482761b4d@gmail.com> Date: Sat, 15 Mar 2025 03:14:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <AS8P250MB0744AB018F8859A608A641C88FD32@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> Content-Language: en-US From: Ramiro Polla <ramiro.polla@gmail.com> In-Reply-To: <AS8P250MB0744AB018F8859A608A641C88FD32@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> Subject: Re: [FFmpeg-devel] [PATCH 1/7] avcodec/pcm: Remove always-false check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/a507a648-2d97-422d-8a5a-4ee482761b4d@gmail.com/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> On 3/13/25 06:49, Andreas Rheinhardt wrote: > Patches attached. [PATCH 2/7] avcodec/pcm: Cache sample_size value > diff --git a/libavcodec/pcm.c b/libavcodec/pcm.c > index 5d8dcb8ff0..620acf0f46 100644 > --- a/libavcodec/pcm.c > +++ b/libavcodec/pcm.c > @@ -328,17 +335,14 @@ static int pcm_decode_frame(AVCodecContext *avctx, AVFrame *frame, > int buf_size = avpkt->size; > PCMDecode *s = avctx->priv_data; > int channels = avctx->ch_layout.nb_channels; > - int sample_size, c, n, ret, samples_per_block; > + int sample_size = s->sample_size, c, n, ret, samples_per_block; > uint8_t *samples; > int32_t *dst_int32_t; Could you put sample_size on its own line? It gets a little confusing with the first variable being initialized, but the subsequent variables being uninitialized. [PATCH 3/7] avcodec/pcm: Remove duplication from FFCodec define macros > diff --git a/libavcodec/pcm.c b/libavcodec/pcm.c > index 620acf0f46..6c1feecca3 100644 > --- a/libavcodec/pcm.c > +++ b/libavcodec/pcm.c [...] > +// AV_CODEC_ID_* pcm_* name > +// AV_SAMPLE_FMT_* long name > +PCM_CODEC (ALAW, S16, alaw, "PCM A-law / G.711 A-law"); > +PCM_DECODER(F16LE, FLT, f16le, "PCM 16.8 floating point little-endian"); The labels don't align with the fields. And in the next patch ([PATCH 4/7] avcodec/pcm: Don't allocate LUT when unused), with the introduction of PCM_CODEC_EXT(), the alignment of PCM_CODEC/PCM_DECODER/PCM_CODEC_EXT is lost. Ramiro _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".