From: Derek Buitenhuis <derek.buitenhuis@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define X264_API_IMPORTS when compiling static
Date: Fri, 20 May 2022 14:13:03 +0100
Message-ID: <a46103f0-a3e8-8f5c-3a57-612987f5fca0@gmail.com> (raw)
In-Reply-To: <BN0P223MB035816ECC9591ED307A34112BAD39@BN0P223MB0358.NAMP223.PROD.OUTLOOK.COM>
On 5/20/2022 2:06 PM, Soft Works wrote:
>> As per Thilo's explanation, I think this is a more appropraite fix:
>>
>> http://ffmpeg.org/pipermail/ffmpeg-devel/2021-October/287426.html
>
> You say you think this is a more appropriate fix "as per Timo's explanation"
> because of the following message:
>
>> No, not wrong. I was alluding to: http://ffmpeg.org/pipermail/ffmpeg-
>> devel/2022-May/296605.html - and not the link.
>
>
> ...where Timo said "This doesn't seem right"?
The fix he suggests, using pkg-config, is what the patch I linked does.
I don't know why it is important who is 'right' here, so I'll conclude replying,
as it is rather unpleasant.
- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-05-20 13:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 22:52 softworkz
2022-05-20 8:49 ` Derek Buitenhuis
2022-05-20 9:36 ` Soft Works
2022-05-20 10:18 ` Timo Rothenpieler
2022-05-20 10:39 ` Soft Works
2022-05-20 11:37 ` Timo Rothenpieler
2022-05-20 12:07 ` Soft Works
2022-05-20 12:49 ` Derek Buitenhuis
2022-05-20 12:51 ` Derek Buitenhuis
2022-05-20 12:54 ` Soft Works
2022-05-20 13:00 ` Derek Buitenhuis
2022-05-20 13:06 ` Soft Works
2022-05-20 13:13 ` Derek Buitenhuis [this message]
2022-05-20 13:24 ` Soft Works
2022-05-20 13:14 ` Soft Works
2022-05-20 15:23 ` [FFmpeg-devel] [PATCH v2] avcodec/libx264: allow to disable definition of X264_API_IMPORTS macro softworkz
2022-05-20 16:22 ` Derek Buitenhuis
2022-05-20 16:34 ` Hendrik Leppkes
2022-05-20 16:37 ` Soft Works
2022-05-20 16:47 ` Derek Buitenhuis
2022-05-20 16:51 ` Martin Storsjö
2022-05-20 16:55 ` Derek Buitenhuis
2022-05-20 17:47 ` Soft Works
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a46103f0-a3e8-8f5c-3a57-612987f5fca0@gmail.com \
--to=derek.buitenhuis@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git